1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-01-19 07:08:09 +01:00

27 Commits

Author SHA1 Message Date
Marc Alexander
b094c79996 [feature/passwords] Move combined hashing methods to manager
This will get rid of the circular dependency between the passwords manager
and the passwords helper. The combined_hash_password() method was also
slightly changed to allow both the definitions of service names or prefixes
for the hash types.

PHPBB3-11610
2014-02-02 14:57:43 +01:00
Marc Alexander
08a8bd8e6f [feature/passwords] Add support for passwords driver service name in hash()
This will allow users to specify both the hash type by prefix and by its
service name.

PHPBB3-11610
2014-02-02 14:13:21 +01:00
Marc Alexander
292961a277 [feature/passwords] Get rid of set_name/get_name methods for passwords drivers
PHPBB3-11610
2014-02-02 14:09:09 +01:00
Marc Alexander
4b832cf2bd [feature/passwords] Intialize output array before usage in passwords helper
PHPBB3-11610
2013-12-29 17:57:17 +01:00
Marc Alexander
1465915830 [feature/passwords] Remove unneeded definitions of full namespace
PHPBB3-11610
2013-12-29 17:56:41 +01:00
Marc Alexander
8383d1f1d3 [feature/passwords] Add missing documentation to docblocks
Also contains some minor spacing changes.

PHPBB3-11610
2013-12-29 17:55:00 +01:00
Marc Alexander
141bef75cb [feature/passwords] Undo simplification to bcrypt driver
By simplifying, a needed part was removed that is actually required.

PHPBB3-11610
2013-12-29 17:04:38 +01:00
Marc Alexander
808c54fa89 [feature/passwords] Get rid of unneeded code complexity
Simplified a little bit of code as pointed out by imkingdavid on github.

PHPBB3-11610
2013-12-29 16:33:09 +01:00
Marc Alexander
555cd025b2 [feature/passwords] Remove unnecessary specification of namespace in drivers
PHPBB3-11610
2013-12-29 16:17:37 +01:00
Marc Alexander
b37549ce63 [feature/passwords] Remove IN_PHPBB check from passwords files
PHPBB3-11610
2013-12-29 14:07:27 +01:00
Marc Alexander
5193b3279c [feature/passwords] Pass list of default types to passwords manager
This list is in the order of how the driver types would be used. If a driver
is not supported we will try the subsequent one.

PHPBB3-11610
2013-10-27 14:18:02 +01:00
Marc Alexander
bb836b65e3 [feature/passwords] Integrate convert_flag with db auth provider
PHPBB3-11610
2013-10-25 15:21:09 +02:00
Marc Alexander
87bd628241 [feature/passwords] Minor cleanup in passwords files
PHPBB3-11610
2013-10-14 14:31:00 +02:00
Marc Alexander
ce51f878eb [feature/passwords] Add phpass copyright notice to salted md5 driver
PHPBB3-11610
2013-10-11 09:43:30 +02:00
Marc Alexander
fdf9ae7c18 [feature/passwords] Increase test coverage to 100% of methods
Obsolete code that is impossible to hit has been removed and the logic
of the salted md5 driver has been changed to correctly implement the
phpBB 3.0 phpbb_hash() function.

PHPBB3-11610
2013-10-10 12:01:10 +02:00
Marc Alexander
cd74fb0946 [feature/passwords] Increase test coverage to 35 out ouf 36 methods
Only one small code part in the salted md5 driver can't be tested right now.
Passwords helper and passwords driver helper are now fully covered by tests.

PHPBB3-11610
2013-10-09 22:53:13 +02:00
Marc Alexander
f1d2949985 [feature/passwords] Move check for 8-bit characters to bcrypt driver
PHPBB3-11610
2013-10-07 16:00:52 +02:00
Marc Alexander
afb7d2e616 [feature/passwords] Rename manager methods to check() and hash()
These method names are more straightforward than the previous ones.

PHPBB3-11610
2013-10-02 13:30:36 +02:00
Marc Alexander
61e4c0f251 [feature/passwords] Do not hash passwords longer than 4096 bytes
PHPBB3-11610
2013-10-01 17:38:52 +02:00
Marc Alexander
3ebff0a960 [feature/passwords] Pass config via service container to driver helper
This will get rid of the global $config in the driver helper

PHPBB3-11610
2013-09-28 12:42:11 +02:00
Marc Alexander
de087d537e [feature/passwords] A few more corrections in methods due to namespacing
PHPBB3-11610
2013-09-28 12:41:02 +02:00
Marc Alexander
3f63b9b470 [feature/passwords] Modify passwords files for namespacing changes
PHPBB3-11610
2013-09-27 11:16:47 +02:00
Marc Alexander
01512104b5 [feature/passwords] Use dependency injection for passwords driver helper
The passwords driver helper is now injected into the driver base instead
of being manually loaded.

PHPBB3-11610
2013-09-22 22:53:10 +02:00
Marc Alexander
f5eb0d744e [feature/passwords] Use dependency injection for helper
This will now be used instead of manually loading the passwords helper
instance in the passwords manager.

PHPBB3-11610
2013-09-22 21:17:30 +02:00
Marc Alexander
a00854c406 [feature/passwords] Do not pass phpbb_container to passwords manager
PHPBB3-11610
2013-09-20 17:31:32 +02:00
Marc Alexander
beafef0000 [feature/passwords] Add missing function documentation
Additionally, a new line has been added to make the code look nicer.

PHPBB3-11610
2013-09-14 14:17:14 +02:00
Marc Alexander
19512b2595 [feature/passwords] Rename "crypto" files to "passwords" files
PHPBB3-11610
2013-09-14 14:04:48 +02:00