mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 03:54:10 +01:00
Code Issues Releases Wiki Activity
22,580 Commits 17 Branches 190 Tags
Commit Graph

35 Commits

Author SHA1 Message Date
Nils Adermann
b203b4afa1 Merge remote-tracking branch 'github-marc1706/ticket/11148' into develop-ascraeus 
* github-marc1706/ticket/11148:
  [ticket/11148] Remove unneeded variable mimetype and use type octet-stream
  [ticket/11148] Change expected output with disallowed content in test
  [ticket/11148] Always use the output of the mimetype guesser in get_mimetype
  [ticket/11148] Get rid of extra line in mimetype guesser setter doc block
  [ticket/11148] Add missing parts to docblock of get_mimetype() method
  [ticket/11148] Default to application/octet-stream if no mimetype given
  [ticket/11148] Use mimetype guesser for uploaded avatars
  [ticket/11148] Pass mimetype guesser to upload_attachment() function
  [ticket/11148] Add mimetype guesser to filespec and fileupload class
 2014-08-07 12:06:33 +02:00
Joas Schilling
b7e1959d56 [ticket/12099] Remove config again 
PHPBB3-12099
 2014-06-29 20:54:41 +02:00
Pico88
f383d4221c [ticket/12099] Add request argument to path_helper service 
PHPBB3-12099
 2014-06-29 20:54:38 +02:00
Marc Alexander
c22983cbdb [ticket/11148] Use mimetype guesser for uploaded avatars 
PHPBB3-11148
 2014-06-23 21:39:24 +02:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers 
PHPBB3-12594
 2014-05-27 20:51:13 +02:00
Joas Schilling
d9de4fc72c [ticket/12504] Use local variables where possible 
PHPBB3-12504
 2014-05-05 18:31:01 +02:00
Joas Schilling
f27e4a44b8 [ticket/12504] Use defined variables 
PHPBB3-12504
 2014-05-05 18:27:00 +02:00
Joas Schilling
5d8d42d88a [ticket/12504] Remove unused request object from avatar manager test 
PHPBB3-12504
 2014-05-05 18:25:44 +02:00
Joas Schilling
baef26f7ed [ticket/12503] All tests should extend \phpbb_test_case 
PHPBB3-12503
 2014-05-05 18:16:50 +02:00
Nils Adermann
52845b22f2 Merge pull request #1815 from marc1706/ticket/11525 
[ticket/11525] Only remove group or user prefix from given avatar data
 2013-11-13 09:52:21 -08:00
Marc Alexander
13a4ceedb1 [ticket/11525] Use foreach instead of array_walk in method clean_row() 
This approach is cleaner and probably even faster the previous ways that
included using array_walk() or array_map() and other helper functions
and methods.

PHPBB3-11525
 2013-11-13 18:27:40 +01:00
Joas Schilling
a74c560eca [ticket/11525] Fix expected value of group avatar test 
PHPBB3-11525
 2013-11-11 00:02:12 +01:00
Joas Schilling
32ba402c34 [ticket/11525] Compare correct array to expected value 
PHPBB3-11525
 2013-11-11 00:01:31 +01:00
Marc Alexander
b2f638b793 [ticket/11857] Use passed service collection instead of container in manager 
The service collection that was already passed to the avatar manager should
be used in the avatar manager method get_driver() instead of the container
itself.

PHPBB3-11857
 2013-10-27 15:08:58 +01:00
Marc Alexander
9d4d212e0f [ticket/11525] Only remove group or user prefix from given avatar data 
Until now, the user data had both user_id and group_id keys in the avatar
data. As both group_ and user_ prefixes were removed the group_id was
collapsed onto the user_id and therefore all users in the same group had
the same prefix for their uploaded avatars. This patch will make sure
that the correct id is used depending on whether it's a group's or user's
avatar data.

PHPBB3-11525
 2013-10-24 13:55:23 +02:00
Marc Alexander
d7bf50bc80 [ticket/11930] Move path_helper in front of optional cache argument 
Optional method arguments should be after any mandatory ones.

PHPBB3-11930
 2013-10-21 10:20:12 +02:00
Marc Alexander
3f0ce78a25 [ticket/11930] Fix tests after adding phpbb\path_helper to avatar drivers 
PHPBB3-11930
 2013-10-17 20:49:10 +02:00
Nils Adermann
43c5ed570f [ticket/11700] Fix avatar tests 
PHPBB3-11700
 2013-09-16 00:29:14 +02:00
Nils Adermann
b95fdacdd3 [ticket/11700] Move all recent code to namespaces 
PHPBB3-11700
 2013-09-16 00:25:27 +02:00
Nils Adermann
da2752e400 [ticket/11700] Modify all code to use the new interface names 
PHPBB3-11700
 2013-07-14 13:30:52 -04:00
Marc Alexander
5afcb1d5f4 [ticket/11600] Remove duplicate test case 
PHPBB3-11600
 2013-07-04 21:15:02 +02:00
Marc Alexander
6fc997924c [ticket/11600] Use lowercase null and remove duplicate test cases 
PHPBB3-11600
 2013-06-25 11:44:37 +02:00
Marc Alexander
72377075f4 [ticket/11600] Use local variable for $user in test_localize_errors 
PHPBB3-11600
 2013-06-25 11:35:04 +02:00
Marc Alexander
25acf3f74c [ŧicket/11600] Split get driver tests into tests for all and only enabled ones 
PHPBB3-11600
 2013-06-25 11:31:15 +02:00
Marc Alexander
3703de63dd [ticket/11600] Increase code test coverage of avatar manager 
Currently, not all methods and their possible behaviors are tested with unit tests.
Add them for better code coverage.

PHPBB3-11600
 2013-06-10 16:45:27 +02:00
Marc Alexander
4ad8fcbd58 [ticket/11404] Remove version ID from manager_test.php file header 
PHPBB3-11404
 2013-03-11 10:35:18 +01:00
Marc Alexander
fb1984dadb [ticket/11404] Add tests for phpbb_avatar_manager::clean_row() 
PHPBB3-11404
 2013-03-11 10:34:25 +01:00
Marc Alexander
2ec0dc5b34 [ticket/11404] Convert manager_test to UNIX line endings 
PHPBB3-11404
 2013-03-11 10:34:12 +01:00
Marc Alexander
caa3516d13 [feature/avatars] Differentiate tests for get drivers functions 
Tests for get_all_drivers() and get_enabled_drivers() should be different.

PHPBB3-10018
 2013-01-08 21:58:03 +01:00
Marc Alexander
023d7a972d [feature/avatars] Remove $request property and pass as argument if needed 
Remove the $request property from the phpbb_avatar_driver class and rather
pass it as function argument if it's needed in a function. Currently this
is only the case for the class methods prepare_form() and process_form().

PHPBB3-10018
 2013-01-07 23:02:07 +01:00
Marc Alexander
ea6bf00977 [feature/avatars] Improve testing to also check for enabled drivers 
PHPBB3-10018
 2012-12-27 20:39:02 +01:00
Marc Alexander
fb139a8820 [feature/avatars] Fix behavior of avatar manager and variables 
The $force_all variable was only partially removed and the behavior was
not consistent in all files.

PHPBB3-10018
 2012-12-04 15:12:04 +01:00
Marc Alexander
fc4069f81d [feature/avatars] Use seperate function for retrieving all drivers 
PHPBB3-10018
 2012-12-04 00:59:37 +01:00
Marc Alexander
232fa5b588 [feature/avatars] Do not use gravatar avatar in tests 
PHPBB3-10018
 2012-12-02 01:19:10 +01:00
Marc Alexander
d771453b52 [feature/avatars] Add tests for avatar manager 
PHPBB3-10018
 2012-12-01 21:37:57 +01:00