Andreas Fischer
82cf239294
Merge pull request #2610 from brunoais/ticket/12699
...
[Ticket/12699] Remove magic numbers in the message textarea keydown callback
* brunoais/ticket/12699:
[ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
[ticket/12699] Add tab key to keymap
2014-06-17 18:13:12 +02:00
brunoais
e1b72c0b86
[ticket/12699] Replace magic numbers for the TAB and for ENTER keydown
...
Replaced the magic numbers 9 and 13 in the keydown for the text editor
with constants in the existing keymap for phpBB.
PHPBB3-12699
2014-06-17 17:07:32 +01:00
Shitiz Garg
d38816fc14
[ticket/12514] Minor fault in type_bool_test.php
...
Had a double new line before get_profile_value_data
PHPBB3-12514
2014-06-17 15:09:13 +05:30
Shitiz Garg
70db69cb8c
[ticket/12514] Remove tests/profiles as they're no longer required
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
2fc5c51d9a
[ticket/12514] Fix type_int_test to correctly respect boundaries
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
995690e192
[ticket/12514] Multi value GET parameters are invalid for phpBB
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
165d7c4b98
[ticket/12514] Add unit test for type_url custom profile field
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
8be079bd66
[ticket/12514] Add unit test for type_date custom profile field
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
6534e13c33
[ticket/12514] Add unit test for type_bool custom profile field
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
e08a4eaf9a
[ticket/12514] Cleanup for type_dropdown_test.php
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
87729c81fc
[ticket/12514] Add newline at the end of file for type_dropdown_test.php
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
e8a6fee743
[ticket/12514] Move requires to the top of the files
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
86754cf572
[ticket/12514] Use @return null instead of @return void
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
cee46f2405
[ticket/12514] Add unit test for drop down type custom profile field
...
PHPBB3-12514
2014-06-17 14:59:26 +05:30
Shitiz Garg
3cb04756bf
[ticket/12514] custom_string_test is no longer required
...
PHPBB3-12514
2014-06-17 14:59:25 +05:30
Shitiz Garg
16f6edc02a
[ticket/12514] Add unit test for type_string and type_string_common field types
...
PHPBB3-12514
2014-06-17 14:59:25 +05:30
Shitiz Garg
b1da3e9c7e
[ticket/12514] Add test for "int" type custom profile field
...
PHPBB3-12514
2014-06-17 14:59:25 +05:30
Dhruv Goel
7ee3e3f73f
Merge pull request #2588 from nickvergessen/ticket/12705
...
Ticket/12705 Fix make_clickable when called with different server_urls
2014-06-17 14:56:55 +05:30
Matt Friedman
09de0c3df9
[ticket/12728] Enforce box model sizing on image attachment thumbnails
...
PHPBB3-12728
2014-06-16 17:53:09 -07:00
Andreas Fischer
89af115071
Merge pull request #2603 from Nicofuma/ticket/12721
...
[ticket/12721] Improve the code sniffer: simple rules
* Nicofuma/ticket/12721:
[ticket/12721] Update rules descriptions
[ticket/12721] Add Generic.NamingConventions.ConstructorName in strict
[ticket/12721] Add Squiz.Functions.LowercaseFunctionKeywords in legacy
[ticket/12721] Add Squiz.ControlStructures.ForLoopDeclaration in legacy
[ticket/12721] Add Squiz.ControlStructures.ForEachLoopDeclaration
[ticket/12721] Add Squiz.ControlStructures.ElseIfDeclaration in legacy
[ticket/12721] Add Generic.Functions.OpeningFunctionBraceBsdAllman
[ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
[ticket/12721] Add Generic.Files.LowercasedFilename in the legacy ruleset
2014-06-17 00:42:39 +02:00
Tristan Darricau
afcca62784
[ticket/12721] Update rules descriptions
...
PHPBB3-12721
2014-06-16 23:07:28 +02:00
Tristan Darricau
6b52155a2a
[ticket/12721] Add Generic.NamingConventions.ConstructorName in strict
...
PHPBB3-12721
2014-06-16 22:35:46 +02:00
Tristan Darricau
13c03b6fcf
[ticket/12721] Add Squiz.Functions.LowercaseFunctionKeywords in legacy
...
PHPBB3-12721
2014-06-16 22:35:45 +02:00
Tristan Darricau
a94581e7ca
[ticket/12721] Add Squiz.ControlStructures.ForLoopDeclaration in legacy
...
PHPBB3-12721
2014-06-16 22:35:44 +02:00
Tristan Darricau
99a2f2fdb4
[ticket/12721] Add Squiz.ControlStructures.ForEachLoopDeclaration
...
PHPBB3-12721
2014-06-16 22:35:42 +02:00
Tristan Darricau
09fc008e62
[ticket/12721] Add Squiz.ControlStructures.ElseIfDeclaration in legacy
...
PHPBB3-12721
2014-06-16 22:35:41 +02:00
Tristan Darricau
06bf864c41
[ticket/12721] Add Generic.Functions.OpeningFunctionBraceBsdAllman
...
PHPBB3-12721
2014-06-16 22:35:39 +02:00
Tristan Darricau
34a4ba36cd
[ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
...
PHPBB3-12721
2014-06-16 22:35:12 +02:00
Tristan Darricau
1aec0d29fd
[ticket/12721] Add Generic.Files.LowercasedFilename in the legacy ruleset
...
PHPBB3-12721
2014-06-16 22:35:11 +02:00
Andreas Fischer
4d6afb2638
Merge pull request #2604 from Nicofuma/ticket/12722
...
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
* Nicofuma/ticket/12722:
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
2014-06-16 22:24:59 +02:00
Tristan Darricau
ca3cdadd08
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
...
PHPBB3-12722
2014-06-16 19:05:09 +02:00
Andreas Fischer
0b106ab0e3
Merge branch 'develop-olympus' into develop-ascraeus
...
* develop-olympus:
[ticket/12720] Allow commit heading to begin with lowercase letters
2014-06-16 15:28:26 +02:00
Andreas Fischer
d2aee6d2ea
Merge pull request #2608 from dhruvgoel92/ticket/12720
...
[ticket/12720] Allow commit heading to begin with lowercase letters
* dhruvgoel92/ticket/12720:
[ticket/12720] Allow commit heading to begin with lowercase letters
2014-06-16 15:28:25 +02:00
Dhruv
6db849cba5
[ticket/12720] Allow commit heading to begin with lowercase letters
...
PHPBB3-12720
2014-06-16 18:55:19 +05:30
Andreas Fischer
9531691537
Merge pull request #2607 from Noxwizard/ticket/12643
...
Ticket/12643 Fixes deletion of columns that have the target column as a prefix
* Noxwizard/ticket/12643:
[ticket/12643] Properly handle changing columns on tables with constraints
[ticket/12643] Tests dropping similarly named columns
[ticket/12643] Ensure that similarly named columns are not removed
2014-06-16 15:14:10 +02:00
Patrick Webster
754e36e378
[ticket/12643] Properly handle changing columns on tables with constraints
...
PHPBB3-12643
2014-06-15 19:07:32 -05:00
Andreas Fischer
663c375f5c
Merge pull request #2605 from Nicofuma/ticket/12724
...
[ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
* Nicofuma/ticket/12724:
[ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
2014-06-16 01:37:21 +02:00
Tristan Darricau
5a320adc75
[ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset
...
PHPBB3-12724
2014-06-16 01:26:59 +02:00
Andreas Fischer
f27be59cf1
Merge pull request #2600 from Nicofuma/ticket/12715
...
[ticket/12715] Fix mistakes in the doc blocks
* Nicofuma/ticket/12715: (30 commits)
[ticket/12715] Add missing new line in the notification manager
[ticket/12715] Cleanup comments in \phpbb\symfony_request
[ticket/12715] Cleanup comments in \phpbb\permissions
[ticket/12715] Cleanup comments in \phpbb\path_helper
[ticket/12715] Cleanup comments in \phpbb\pagination
[ticket/12715] Cleanup comments in \phpbb\datetime
[ticket/12715] Cleanup comments in \phpbb\content_visibility
[ticket/12715] Cleanup comments in \phpbb\tree\*
[ticket/12715] Cleanup comments in \phpbb\template\*
[ticket/12715] Cleanup comments in \phpbb\plupload\*
[ticket/12715] Cleanup comments in \phpbb\profilefields\*
[ticket/12715] Cleanup comments in \phpbb\passwords\*
[ticket/12715] Cleanup comments in \phpbb\notification\*
[ticket/12715] Cleanup comments in \phpbb\mimetype\*
[ticket/12715] Cleanup comments in \phpbb\message\*
[ticket/12715] Cleanup comments in \phpbb\log\*
[ticket/12715] Cleanup comments in \phpbb\lock\*
[ticket/12715] Cleanup comments in \phpbb\groupposition\*
[ticket/12715] Cleanup comments in \phpbb\feed\*
[ticket/12715] Cleanup comments in \phpbb\extension\*
...
2014-06-16 01:12:03 +02:00
Tristan Darricau
f4ef1ab6bd
[ticket/12715] Add missing new line in the notification manager
...
PHPBB3-12715
2014-06-16 01:01:10 +02:00
Patrick Webster
e6a8df7f7e
[ticket/12643] Tests dropping similarly named columns
...
PHPBB3-12643
2014-06-15 14:18:39 -05:00
BorisBerdichevski
2dc389c936
[ticket/12643] Ensure that similarly named columns are not removed
...
PHPBB3-12643
2014-06-15 14:15:42 -05:00
Tristan Darricau
bae1724476
[ticket/12715] Cleanup comments in \phpbb\symfony_request
...
PHPBB3-12715
2014-06-15 19:15:23 +02:00
Tristan Darricau
1eb50c67df
[ticket/12715] Cleanup comments in \phpbb\permissions
...
PHPBB3-12715
2014-06-15 19:15:21 +02:00
Tristan Darricau
cfa399110d
[ticket/12715] Cleanup comments in \phpbb\path_helper
...
PHPBB3-12715
2014-06-15 19:15:18 +02:00
Tristan Darricau
9bd23917dc
[ticket/12715] Cleanup comments in \phpbb\pagination
...
PHPBB3-12715
2014-06-15 19:15:16 +02:00
Tristan Darricau
7f3e0e5e42
[ticket/12715] Cleanup comments in \phpbb\datetime
...
PHPBB3-12715
2014-06-15 19:15:13 +02:00
Tristan Darricau
706484c80d
[ticket/12715] Cleanup comments in \phpbb\content_visibility
...
PHPBB3-12715
2014-06-15 19:15:11 +02:00
Tristan Darricau
dba01c5690
[ticket/12715] Cleanup comments in \phpbb\tree\*
...
PHPBB3-12715
2014-06-15 19:15:09 +02:00
Tristan Darricau
0d0113e6da
[ticket/12715] Cleanup comments in \phpbb\template\*
...
PHPBB3-12715
2014-06-15 19:15:06 +02:00