mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 20:13:22 +01:00
Code Issues Releases Wiki Activity
15,002 Commits 17 Branches 190 Tags
Commit Graph

15002 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Oleg Pudeyev
6c7f1f7bde [feature/template-events] Cosmetic changes. 
PHPBB3-9550
 2012-11-17 16:40:00 -05:00
Nathan Guse
4ed9e4124e [feature/template-events] Wording: wrongly -> improperly. 
PHPBB3-9550
 2012-11-17 16:40:00 -05:00
Nathan Guse
2fb4006056 [feature/template-events] Indentation fix. 
PHPBB3-9550
 2012-11-17 16:40:00 -05:00
Oleg Pudeyev
9c31a0ffc7 [feature/template-events] Rename template_name to style_name. 
"Style name" makes a lot more sense and should be in line with
recent style/template changes.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
0df0c6199b [feature/template-events] Switch template event test to data providers. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
667f8d581f [feature/template-events] Add a universal template event test. 
Also drop the irrelevant includejs code and add a simple
template event test. The simple test is not working yet however
due to the template engine not correctly tracking which template
it is rendering.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
09b4cf2f4c [feature/template-events] Report when templates cannot be compiled. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
4b28b413f2 [feature/template-events] Update EVENT tag documentation. 
It should now fairly closely reflect what actually happens.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
faf96a1b40 [feature/template-events] Delete old comments/test code. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
bd63b17d00 [feature/template-events] Move comment to the function docblock. 
PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
1b36fc3a60 [feature/template-events] Handle user access correctly. 
Pass through $user from template to filter.

Allow $user to be null for standalone usage of the template engine.

PHPBB3-9550
 2012-11-17 16:39:59 -05:00
Oleg Pudeyev
45a1219886 [feature/template-events] Always commit suicide for invalid event names. 
Note: suicide happens for syntactically invalid event names,
e.g. event names containing punctuation.

Event names for which there are no events are silently dropped.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Oleg Pudeyev
f46f48a2cf [feature/template-events] Chase template/style renames and changes. 
PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
7bd5f7641f [feature/template-events] Fix typo (waring -> warning) 
PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
2add66c0eb [feature/template-events] Add additional space for editors 
Use `' ?'. '>'` rather than `' ?>'` as the latter causes problems
in some editors.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
6fc0c889fd [feature/template-events] Remove comment 
Remove comment per Nils in the PR.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
132bbede2b [feature/template-events] Handle incorrect template event identifiers 
If the template event identifier is wrongly formatted phpBB will
triggern an `E_USER_NOTICE` if the `DEBUG` constant is set, otherwise
the location is ignored.

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Vjacheslav Trushkin
db688c2574 [feature/template-events] Template events unit test 
Adding template events test

PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Erik Frèrejean
f836277638 [feature/template-events] RUNHOOKS -> EVENT 
PHPBB3-9550
 2012-11-17 16:39:58 -05:00
Nathan Guse
04f55ba306 [feature/template-events] Correct indentation 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Michael Cullum
8d58e69ed3 [feature/template-events] Rename RUNHOOKS to EVENT 
Rename the way to add template events

PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
ecdb54fc04 [feature/template-events] PHP does not parse <?php?>, avoid generating it. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
bdbb382a26 [feature/template-events] Invoke template hooks that are template-specific. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
a6c7fbc59d [feature/template-events] Pass top-level template name to template filter. 
This will be used to invoke template-specific hooks.

PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
dd7c5183fb [feature/template-events] Add template_compile to template filter params. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
ea094dd91a [feature/template-events] Rename universal to all (for template fragments). 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
b6f6add9d4 [feature/template-events] Fix property name for extension manager. 
PHPBB3-9550
 2012-11-17 16:39:57 -05:00
Oleg Pudeyev
66232031e4 [feature/template-events] Really basic template hook implementation. 
PHPBB3-9550
 2012-11-17 16:39:56 -05:00
Oleg Pudeyev
09aae1ea30 [feature/template-events] Inject template compile into template filter. 
This is needed for hooks in order for the filter to compile
template files from extensions.

PHPBB3-9550
 2012-11-17 16:39:56 -05:00
Oleg Pudeyev
d6c881d0c6 [feature/template-events] Inject extension manager into template class. 
Template class passes extension manager to template compiler.

Template compiler passes extension manager to template filter.

Template filter will use extension manager to locate hooks
as it is compiling templates.

All extension manager arguments are optional. If an extension
manager is not given, template hooks will not be invoked.

PHPBB3-9550
 2012-11-17 16:39:54 -05:00
Oleg Pudeyev
ed548ae8ff [feature/template-events] Outline for RUNHOOKS template tag. 
Ported to the new develop, hopefully this is still sensible.

PHPBB3-9550
 2012-11-17 16:38:25 -05:00
Igor Wiedler
b5e069f879 Merge remote-tracking branch 'p/ticket/10933' into develop 
* p/ticket/10933:
  [ticket/10933] Prose for get_first_file_location.
  [ticket/10933] Remaining documentation for added functions in resource locator
  [ticket/10933] Update template locator test to use style resource locator.
  [ticket/10933] Dispose of locate function in template class.
  [ticket/10933] Add mutators for template_path to style resource locator.
  [ticket/10933] Delete template_path assignment.
  [ticket/10933] Delete template_path from template class.
  [ticket/10933] Add get_first_template_location.
 2012-11-17 19:49:03 +01:00
Oleg Pudeyev
e07db8fb8c Merge PR #1097 branch 'igorw/ticket/11212' into develop 
* igorw/ticket/11212:
  [ticket/11212] Cosmetic surgery done right
  [ticket/11212] Cosmetics
  [ticket/11212] Rename get_http_version to phpbb_request_http_version()
  [ticket/11212] Allow dispatcher to be absent during garbage_collection()
  [ticket/11212] Do not rely on $request in send_status_line()
 2012-11-17 12:24:15 -05:00
Igor Wiedler
b8cf74217a [ticket/11212] Cosmetic surgery done right 
PHPBB3-11212
 2012-11-17 05:29:49 +01:00
Igor Wiedler
1affc35be9 [ticket/11212] Cosmetics 
PHPBB3-11212
 2012-11-17 05:29:49 +01:00
Igor Wiedler
b534a7a579 [ticket/11212] Rename get_http_version to phpbb_request_http_version() 
PHPBB3-11212
 2012-11-17 05:29:49 +01:00
Igor Wiedler
98921e0b87 [ticket/11213] Add missing global in install_update.php 
PHPBB3-11213
 2012-11-17 05:27:36 +01:00
Igor Wiedler
0372ecf141 [ticket/11015] Make phpbb_convert_30_dbms_to_31 more future proof 
It should allow any class name in the future, as long as that class
exists. And it should give a useful error message otherwise.

PHPBB3-11015
 2012-11-17 01:40:35 +01:00
Igor Wiedler
9cdef7984f [ticket/11212] Allow dispatcher to be absent during garbage_collection() 
PHPBB3-11212
 2012-11-17 01:17:23 +01:00
Igor Wiedler
5fad4006e1 [ticket/11212] Do not rely on $request in send_status_line() 
PHPBB3-11212
 2012-11-17 01:15:50 +01:00
Igor Wiedler
5bc0f4b3d4 [ticket/11015] Move db driver class name fixing to function 
PHPBB3-11015
 2012-11-17 00:24:32 +01:00
David King
4efbb893b7 [feature/controller] Fix line endings and permissions, and check responses 
PHPBB3-10864
 2012-11-16 17:36:39 -05:00
David King
abf2575bdb [feature/controller] Remove URL rewriting by default 
PHPBB3-10864
 2012-11-16 17:06:02 -05:00
David King
5b013ddf5c [feature/controller] Add controller functional test with template 
PHPBB3-10864
 2012-11-16 17:06:01 -05:00
David King
ba1acdca03 [feature/controller] Use warning instead of echo for copy() and unlink() 
PHPBB3-10864
 2012-11-16 17:06:00 -05:00
David King
1952a4f276 [feature/controller] Flip method parameters, require $message 
PHPBB3-10864
 2012-11-16 17:06:00 -05:00
David King
d41b1146e8 [feature/controller] Rename $root_path class property to $phpbb_root_path 
PHPBB3-10864
 2012-11-16 17:05:59 -05:00
David King
c2f352ab35 [feature/controller] Fix param block for controller callable 
PHPBB3-10864
 2012-11-16 17:05:58 -05:00
David King
0c75d3d7da [feature/controller] Add test for missing argument in controller class 
PHPBB3-10864
 2012-11-16 17:05:57 -05:00
David King
230897723c [feature/controller] Reword comment for clarification 
PHPBB3-10864
 2012-11-16 17:05:57 -05:00