mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 04:23:38 +01:00
Code Issues Releases Wiki Activity
15,211 Commits 17 Branches 190 Tags
Commit Graph

70 Commits

Author SHA1 Message Date
Marc Alexander
b5cc1ed683 [ticket/10949] Converted missing code to new JS coding guidelines 
A few missing semi-colons were also added where needed.

PHPBB3-10949
 2013-01-04 22:46:12 +01:00
Marc Alexander
46c33e08b5 Merge remote-tracking branch 'callumacrae/ticket/10949' into ticket/10949 
Conflicts:
	phpBB/assets/javascript/core.js
 2013-01-04 20:46:56 +01:00
Oleg Pudeyev
300b8236eb Merge PR #1153 branch 'marc1706/ticket/10805' into develop 
# By Marc Alexander
# Via Marc Alexander
* marc1706/ticket/10805:
  [ticket/10805] Compare phpbbAlertTimer against null
  [ticket/10805] Clear loading alert timeout after ajax request finished
 2013-01-02 16:56:38 -05:00
Marc Alexander
e211009eb7 [ticket/11302] Correctly select first timezone or selected timezone 
While registering, we should default to a given timezone. By selecting the
first timezone by default, this is fulfilled. This doesn't happen
currently, as only the "Select a timezone" selection appears.
If a user selects a timezone during the registration process we should
also make sure that the selected element is still selected; even if we
have to return to the registration page, i.e. if there was an error while
submitting the form. This is currently not the case.
With this patch the javascript code will behave correctly.
Additionally, a duplicate inclusion of timezone.js has been removed as it
was not needed.

PHPBB3-11302
 2013-01-02 22:05:14 +01:00
Marc Alexander
48b6e45f7c [ticket/10805] Compare phpbbAlertTimer against null 
PHPBB3-10805
 2013-01-02 16:44:05 +01:00
Marc Alexander
5d07ddffaf [ticket/10805] Clear loading alert timeout after ajax request finished 
The timeout for the "request timed out" popup should be cleared if it
finished. Since it is currently not cleared, the timeout alert appears as
an extra overlay if another ajaxified function is ran within 5 seconds of
the initial function call. This patch will take care of clearing the
timeout if either the success (function return_handler()) or error
(function error_handler()) functions are called.

PHPBB3-10805
 2013-01-01 20:29:30 +01:00
Marc Alexander
693778fa07 [ticket/10803] Show failure message until user dismisses it 
PHPBB3-10803
 2012-12-18 23:42:14 +01:00
Oleg Pudeyev
51cd1129be Merge PR #890 branch 'nickvergessen/ticket/10982' into develop 
* nickvergessen/ticket/10982:
  [ticket/10982] Correctly check, whether data-overlay is set
  [ticket/10982] Remove overlay on first up/down move of forums in ACP
  [ticket/10982] Allow setting dimming control overlay also as data-overlay
 2012-10-16 21:47:13 -04:00
Joas Schilling
fd40e841cb [ticket/11004] Always update suggestion button in timezone_preselect_select 
Suggestion must also be updated when the suggestion is selected at first,
so we can display a correct button, when the suggestion is not selected anymore.

PHPBB3-11004
 2012-07-24 17:09:26 +02:00
Joas Schilling
5bdec7669b [ticket/11003] Ability to show full list of timezones with JavaScript enabled 
This also fixes the problem with Chrome which displayed all timezones.

PHPBB3-11007
PHPBB3-11003
 2012-07-23 18:13:22 +02:00
Joas Schilling
d099ef8cad [feature/new-tz-handling] Display suggestion when a different value is selected 
PHPBB3-9558
 2012-07-19 14:24:59 +02:00
Joas Schilling
f4136eacdc Merge branch 'develop' of git://github.com/phpbb/phpbb3 into feature/new-tz-handling 2012-07-18 11:07:32 +02:00
Joas Schilling
c4c95fddaa [ticket/10982] Correctly check, whether data-overlay is set 
PHPBB3-10982
 2012-07-11 15:06:44 +02:00
Joas Schilling
95298de5ae [ticket/10982] Allow setting dimming control overlay also as data-overlay 
PHPBB3-10982
 2012-07-11 14:53:50 +02:00
Joas Schilling
f1056a9b2f [ticket/10811] Make toogle_subscribe more generic so it can toogle all links 
PHPBB3-10811
 2012-07-05 01:03:19 +02:00
Callum Macrae
d5a788ae5b [ticket/10949] Converted AJAX coding standards to new guidelines. 
Basically, moved parentheses to same line and changed variable names to
camel case.

PHPBB3-10949
 2012-06-21 19:16:05 +01:00
Joas Schilling
7b4f9765f8 [feature/new-tz-handling] Move js functions into assets core.js 
PHPBB3-9558
 2012-06-19 18:57:20 +02:00
Joas Schilling
53a47fdcc3 [ticket/10811] Make subscribe/unsubscribe repeatable with AJAX 
PHPBB3-10811
 2012-04-29 12:33:55 +02:00
Joas Schilling
286aebd93b [ticket/10811] Fix AJAX callback alt_text so it can be repeated. 
PHPBB3-10811
 2012-04-19 13:37:07 +02:00
Marc Alexander
7a9d9f97ef [ticket/10784] Do not show ajax overlay unless needed 
PHPBB3-10784
 2012-04-12 21:03:47 +02:00
Callum Macrae
64df9d1406 [ticket/10272] Removed code that was prevent event propogation in AJAX. 
PHPBB3-10272
 2012-03-31 02:10:16 +02:00
Callum Macrae
ba56e34b6d [ticket/10291] Fixed a bug in the quick reply AJAX. 
It wasn't submitting, as jQuery was ignoring the submit value.

PHPBB3-10291
 2012-03-31 02:10:15 +02:00
Igor Wiedler
2f44850a28 [feature/ajax] Fix filter check, quick mod tools data-attribute 
PHPBB3-10270
 2012-03-31 02:10:14 +02:00
Igor Wiedler
ea4362fc4c [feature/ajax] Use the error handler 
PHPBB3-10270
 2012-03-31 02:09:26 +02:00
Igor Wiedler
27199bb509 [feature/ajax] Generic error handling with a phpbb.alert box 
PHPBB3-10270
 2012-03-31 02:09:26 +02:00
Igor Wiedler
2f25173d93 [feature/ajax] Change filter semantics, some minor adjustments 
PHPBB3-10270
 2012-03-31 02:09:26 +02:00
Igor Wiedler
de82608e6f [feature/ajax] Refactor phpbb.ajaxify event callback 
PHPBB3-10270
 2012-03-31 02:09:26 +02:00
Igor Wiedler
4848d6c9e8 [feature/ajax] Bind to form.submit instead of form input.click 
PHPBB3-10270
 2012-03-31 02:09:25 +02:00
Igor Wiedler
b8a6a50f5c [feature/ajax] Rename exception to filter 
PHPBB3-10270
 2012-03-31 02:09:25 +02:00
Igor Wiedler
6ad4015a37 [feature/ajax] Add a missing semicolon 
PHPBB3-10270
 2012-03-31 02:09:25 +02:00
Igor Wiedler
fc0d2425dc [feature/ajax] Fix the alt_text ajax callback 
PHPBB3-10270
 2012-03-31 02:09:25 +02:00
Igor Wiedler
7ed2cbef75 [feature/ajax] Make phpbb.ajaxify signature use single object (more explicit) 
PHPBB3-10270
 2012-03-31 02:09:25 +02:00
Igor Wiedler
d96b07a745 [feature/ajax] Only allow object argument for phpbb.ajaxify 
PHPBB3-10270
 2012-03-31 02:09:24 +02:00
Igor Wiedler
a12b7a5c64 [feature/ajax] Fix alt_text and overlay closing 
PHPBB3-10270
 2012-03-31 02:09:24 +02:00
Igor Wiedler
d53c36684d [feature/ajax] JavaScript strict mode 
PHPBB3-10270
 2012-03-31 02:09:24 +02:00
Igor Wiedler
628074bf70 [feature/ajax] Stylistic JavaScript adjustments 
PHPBB3-10270
 2012-03-31 02:09:24 +02:00
Igor Wiedler
b100bb9a69 [feature/ajax] Replace return false with explicit preventDefault() 
PHPBB3-10270
 2012-03-31 02:09:23 +02:00
Igor Wiedler
30888ff2a0 [feature/ajax] Use attr('data-foo') instead of data('foo') 
data() is slower and does additional unwanted things like
caching and type conversion. Just reading the value is safer.

PHPBB3-10270
 2012-03-31 02:09:23 +02:00
Igor Wiedler
265907b115 [feature/ajax] Replace keyboard vars with a keymap 
PHPBB3-10270
 2012-03-31 02:09:23 +02:00
Callum Macrae
3e53dff95c [ticket/10271] Added some documentation to phpbb.ajaxify. 
PHPBB3-10271
 2012-03-31 02:09:23 +02:00
Callum Macrae
eee0624a69 [ticket/10271] Renamed an unhelpful variable name in core.js. 
PHPBB3-10271
 2012-03-31 02:09:23 +02:00
Callum Macrae
2189efadc6 [ticket/10270] Moved the AJAX error langyage entries to the footer. 
PHPBB3-10270
 2012-03-31 02:09:22 +02:00
Callum Macrae
f9ddeacd8e [ticket/10272] Renamed l-err-processing-req to l-timeout-processing-req. 
PHPBB3-10272
 2012-03-31 02:09:22 +02:00
Callum Macrae
8da463ac9e [ticket/10270] Recoded some potentially buggy code in phpbb.confirm. 
The code before could have removed event handlers defined by other code.

PHPBB3-10270
 2012-03-31 02:09:21 +02:00
Callum Macrae
03d4ae20d1 [ticket/10271] Started using .call for javascript callbacks. 
Previously, they were just being called by appending parentheses and
functions. Now, they're being called and the element is being set as the
context instead of a parameter. It's a lot cleaner.

PHPBB3-10271
 2012-03-31 02:09:21 +02:00
Callum Macrae
e0d6814772 [ticket/10270] Fixed a bug with the close button in phpbb.confirm. 
PHPBB3-10270
 2012-03-31 02:09:21 +02:00
Callum Macrae
cdfd746a25 [ticket/10271] Fixed the comment for phpbb.parse_querystring. 
PHPBB3-10271
 2012-03-31 02:09:20 +02:00
Callum Macrae
eabc6d29c4 [ticket/10271] Reduced calls to $ in phpbb.ajaxify. 2012-03-31 02:09:20 +02:00
Callum Macrae
415d33f20d [ticket/10271] Renamed the "act" js variable to "action". 
PHPBB3-10271
 2012-03-31 02:09:20 +02:00
Callum Macrae
8a2f5f3269 [ticket/10271] Improved the comments on return_handler. 
PHPBB3-10271
 2012-03-31 02:09:20 +02:00