1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-19 08:01:27 +02:00
Commit Graph

4287 Commits

Author SHA1 Message Date
Andreas Fischer
f460287856 [ticket/12575] Workaround for offsetExists seems not required for the Iterator.
PHPBB3-12575
2014-06-14 18:06:43 +02:00
Andreas Fischer
87a13a8c77 [ticket/12575] Pass service_collection instead of ContainerInterface.
PHPBB3-12575
2014-06-14 15:00:35 +02:00
Tristan Darricau
482f60f1bd [ticket/12575] Use strict comparison
PHPBB3-12575
2014-06-14 12:04:25 +02:00
Tristan Darricau
d33ed1edf6 [ticket/12575] Add missing property
PHPBB3-12575
2014-06-14 09:42:32 +02:00
Tristan Darricau
232a1c4fcb [ticket/12575] Usethe new header
PHPBB3-12575
2014-06-14 01:52:12 +02:00
Tristan Darricau
30a62d2e11 [ticket/12575] Fix 2 typos in comments
PHPBB3-12575
2014-06-14 01:45:29 +02:00
Tristan Darricau
0e4c7dbda5 [ticket/12575] Fix typos in comments
PHPBB3-12575
2014-06-14 01:45:27 +02:00
Tristan Darricau
d4cc6990e4 [ticket/12575] Skip sniffer issue triggered by the solution of a php bug
https://bugs.php.net/bug.php?id=66834
https://bugs.php.net/bug.php?id=67067

PHPBB3-12575
2014-06-14 01:45:25 +02:00
Tristan Darricau
6e47886227 [ticket/12575] Remove inline assignments
PHPBB3-12575
2014-06-14 01:45:23 +02:00
Tristan Darricau
bea9372efa [ticket/12575] Fix the tests
PHPBB3-12575
2014-06-14 01:45:21 +02:00
Tristan Darricau
a0985c7a22 [ticket/12575] Move service_collection_iterator to its own file
PHPBB3-12575
2014-06-14 01:45:19 +02:00
Tristan Darricau
a4c15bbf4f [ticket/12575] Speed up load_class()
Load the services referenced in a service_collection only when
they are used to avoid to load some unsuded services.

PHPBB3-12575
2014-06-14 01:45:17 +02:00
Andreas Fischer
7642fbbd63 Merge pull request #2527 from dhruvgoel92/ticket/11445
[ticket/11445] optimize no of queries in get_global_subscriptions( )

* dhruvgoel92/ticket/11445:
  [ticket/11445] Move get user's notification code into its own method
  [ticket/11445] Remove unused foreach key $group_name
  [ticket/11445] Improve unit tests for get_global_subscriptions
  [ticket/11445] Optimize no of queries in get_global_subscriptions
2014-06-14 00:16:52 +02:00
Nils Adermann
694f8391c9 Merge remote-tracking branch 'github-marc1706/ticket/12352' into develop-ascraeus
* github-marc1706/ticket/12352: (33 commits)
  [ticket/12352] Do not check hashes that don't have the necessary length
  [ticket/12352] Update file headers to fit new format
  [ticket/12352] Use custom provider collection for auth providers
  [ticket/12352] Add checks for existing user_pass_convert to migrations
  [ticket/12352] Remove usages of user_pass_convert column
  [ticket/12352] Update schema json file
  [ticket/12352] Remove user_pass_convert column from database
  [ticket/12352] Check each newly added passwords driver in manager_test
  [ticket/12352] Add get_settings_only method to passwords driver base
  [ticket/12352] Add passwords driver for xenforo 1.0, 1.1 passwords
  [ticket/12352] Add tests for wcf1 and wcf2 drivers
  [ticket/12352] Add driver for woltlab community framework 1 passwords
  [ticket/12352] Add driver for woltlab community framework 2 passwords
  [ticket/12352] Add missing $ to md5_mybb and md5_vb driver
  [ticket/12352] Fix spacing in passwords tests
  [ticket/12352] Add passwords driver for vB passwords
  [ticket/12352] Use correct hashing method in md5_mybb driver
  [ticket/12352] Add driver for myBB md5 passwords
  [ticket/12352] Rename phpbb2_md5 driver to fit filenames of other drivers
  [ticket/12352] Add passwords driver for sha1 password hashes
  ...
2014-06-11 14:27:57 +02:00
Joas Schilling
0134acd53f [ticket/12508] Ignore extensions in migration_tips dev tool
PHPBB3-12508
2014-06-10 11:50:11 +02:00
Joas Schilling
c82ae94f8a [ticket/12508] Fix doc block
PHPBB3-12508
2014-06-10 11:47:43 +02:00
Joas Schilling
1e9492bcaa [ticket/12508] Add new line to separate the if and foreach better
PHPBB3-12508
2014-06-10 11:47:42 +02:00
Joas Schilling
6980fbd27b [ticket/12508] Only take a list of names for set_extensions()
PHPBB3-12508
2014-06-10 11:47:41 +02:00
Joas Schilling
e1707b27ca [ticket/12508] Fix class doc block
PHPBB3-12508
2014-06-10 11:47:41 +02:00
Joas Schilling
183492b019 [ticket/12508] Move \phpbb\extension\finder to \phpbb\finder
PHPBB3-12508
2014-06-10 11:47:40 +02:00
Joas Schilling
d45c681b40 [ticket/12508] Fix usages of the finder
PHPBB3-12508
2014-06-10 11:47:39 +02:00
Joas Schilling
c20653dfbe [ticket/12508] Remove extension manager from finder
PHPBB3-12508
2014-06-10 11:47:36 +02:00
Andreas Fischer
2964fb37e8 [ticket/12664] Refactor develop/migration_tips.php into a console command.
PHPBB3-12664
2014-06-10 01:57:59 +02:00
Nils Adermann
b6232aa9b2 Merge remote-tracking branch 'github-nickvergessen/ticket/10073' into develop-ascraeus
* github-nickvergessen/ticket/10073: (36 commits)
  [ticket/10073] Fix button descriptions
  [ticket/10073] Do not check disable boxes by default
  [ticket/10073] Store values with config_text in the ACP
  [ticket/10073] Move config values to config_text
  [ticket/10073] Fix request usage
  [ticket/10073] Deduplicate template variable names
  [ticket/10073] Get service from container
  [ticket/10073] Fix more "Contact Us" strings
  [ticket/10073] Move template code into the template
  [ticket/10073] Make contact page available when board is disabled
  [ticket/10073] Change name of the ACP module
  [ticket/10073] Deduplicate posting buttons code in ACP
  [ticket/10073] Use phpbb_validate_email to verify email address
  [ticket/10073] Add tests for new validate_email()
  [ticket/10073] Split email validation from email ban and taken checks
  [ticket/10073] Deduplicate the if statement
  [ticket/10073] Fallback to board_contact when contact page is disabled
  [ticket/10073] Remove language string from rebase conflict
  [ticket/10073] Add ACP module to add bbcode text for contact admin info
  [ticket/10073] Add new configs to the schema
  ...
2014-06-09 17:55:25 +02:00
Joas Schilling
e3c3a5d2a7 [ticket/10073] Do not check disable boxes by default
PHPBB3-10073
2014-06-09 01:36:19 +02:00
Joas Schilling
1a6d8dd94d [ticket/12099] Prepend ./ to path to fix assets
PHPBB3-12099
2014-06-09 01:10:18 +02:00
Joas Schilling
edc5908e48 [ticket/12099] Deduplicate path generation
PHPBB3-12099
2014-06-09 00:48:02 +02:00
Dhruv
f5415619eb [ticket/11445] Move get user's notification code into its own method
PHPBB3-11445
2014-06-07 01:34:20 +05:30
Dhruv
ac74dc876c [ticket/11445] Remove unused foreach key $group_name
PHPBB3-11445
2014-06-07 01:00:09 +05:30
Andreas Fischer
fc4275ab2b Merge pull request #2543 from Nicofuma/ticket/12655
[ticket/12655] Run phpbbcli as a shell when --shell or -s is used

* Nicofuma/ticket/12655:
  [ticket/12655] Set register_container_commands as public
  [ticket/12655] Don't try to restore the definition in the help
  [ticket/12655] Fix coding style
  [ticket/12655] Make the --shell option available only for phpbbcli.php
  [ticket/12655] Fix coding style in \phpbb\console\application
  [ticket/12655] Set the arguments of \phpbb\console\application as required
  [ticket/12655] Don't require acp/common again in the commands
  [ticket/12655] Run the shell when --shell is used
2014-06-06 19:49:29 +02:00
Andreas Fischer
69e50dffae Merge pull request #2509 from Stephannos/ticket/12602
[ticket/12602] Add command to print the cron list

* Stephannos/ticket/12602:
  [ticket/12602] Fix language key removal.
  [ticket/12602] Rectify language keys.
  [ticket/12602] Fix test mistake.
  [ticket/12602] Fix language var mistakes.
  [ticket/12602] Add types, change description of cron:list.
  [ticket/12602] Fix internationalisation of cron_list.php
  [ticket/12602] Fix spaces issues.
  [ticket/12602] Coding style correction.
  [ticket/12602] Fix coding style mistakes.
  [ticket/12602] Headers updated.
  [ticket/12602] Changes to respect coding style and to factorize code.
  [ticket/12602] Cleanup tests
  [ticket/12602] Add function get_tasks.
  [ticket/12602] Correction of the output message for the cron list
  [ticket/12602] Add files to print the cron list and test files.
2014-06-06 19:43:09 +02:00
Etienne Baroux
347de7f060 [ticket/12602] Rectify language keys.
PHPBB3-12602
2014-06-06 14:55:37 +02:00
Etienne Baroux
8f0a04f318 [ticket/12602] Fix language var mistakes.
PHPBB3-12602
2014-06-06 10:21:00 +02:00
Marc Alexander
4d24681259 [ticket/12666] Use "None" for images in root of gallery avatar path
"None" serves no real purpose right now. After this it will be used instead
of "Main" for images in the root of the gallery avatar path.

PHPBB3-12666
2014-06-05 23:28:00 +02:00
Etienne Baroux
c6999481e7 [ticket/12602] Add types, change description of cron:list.
PHPBB3-12602
2014-06-05 15:11:15 +02:00
PayBas
c3b24e2005 [ticket/12613] Improved pagination
PHPBB3-12613
2014-06-05 09:59:31 +02:00
Andreas Fischer
d79ad22a21 Merge pull request #2539 from marc1706/ticket/12457
[ticket/12457] Default to first category if none is selected in gallery avatar

* marc1706/ticket/12457:
  [ticket/12457] Default to first category if none is selected in gallery avatar
2014-06-05 02:26:48 +02:00
Tristan Darricau
5b51acf245 [ticket/12655] Set register_container_commands as public
PHPBB3-12655
2014-06-05 01:03:16 +02:00
Tristan Darricau
5e9c8a0cea [ticket/12655] Don't try to restore the definition in the help
PHPBB3-12655
2014-06-05 01:00:33 +02:00
Tristan Darricau
012702307b [ticket/12655] Fix coding style
PHPBB3-12655
2014-06-05 00:21:53 +02:00
Andreas Fischer
f9c0a6b96e Merge pull request #2526 from Nicofuma/ticket/12639
[ticket/12639] Delete entry in admin-log leads to mysql-error

* Nicofuma/ticket/12639:
  [ticket/12639] Add a space in the code generated by generate_sql_keyword()
  [ticket/12639] Handle $conditions['keywords'] outside of the loop
  [ticket/12639] Don't make a copy of $marked when deleting logs in acp_logs
  [ticket/12639] Send a correct IN entry when deleting marked logs
  [ticket/12639] Use assertSame
  [ticket/12639] Remove old commented tests
  [ticket/12639] Order the results correctly in the test
  [ticket/12639] Fix tests on postgres
  [ticket/12639] Update tests to use a dataProvider
  [ticket/12639] Add a test case with an empty keywords list
  [ticket/12639] Delete entry in admin-log leads to mysql-error
2014-06-04 23:59:20 +02:00
Tristan Darricau
ce104e2c72 [ticket/12655] Make the --shell option available only for phpbbcli.php
PHPBB3-12655
2014-06-04 22:33:05 +02:00
Etienne Baroux
442e12828b [ticket/12602] Fix spaces issues.
PHPBB3-12602
2014-06-04 21:56:55 +02:00
Tristan Darricau
99ebf4b8dd [ticket/12655] Fix coding style in \phpbb\console\application
PHPBB3-12655
2014-06-04 21:08:11 +02:00
Tristan Darricau
fb46e42ab3 [ticket/12639] Add a space in the code generated by generate_sql_keyword()
PHPBB3-12639
2014-06-04 20:22:22 +02:00
Etienne Baroux
7c22d653e9 [ticket/12602] Coding style correction.
PHPBB3-12602
2014-06-04 15:50:09 +02:00
Tristan Darricau
a14d16172c [ticket/12655] Set the arguments of \phpbb\console\application as required
PHPBB3-12655
2014-06-04 15:34:11 +02:00
Tristan Darricau
6c9518ea32 [ticket/12655] Don't require acp/common again in the commands
PHPBB3-12655
2014-06-04 14:47:00 +02:00
Tristan Darricau
5efd55a348 [ticket/12655] Run the shell when --shell is used
PHPBB3-12655
2014-06-04 14:46:40 +02:00
Etienne Baroux
5aca27e8cf [ticket/12602] Fix coding style mistakes.
PHPBB3-12602
2014-06-03 10:54:28 +02:00