Removing whitespace, cast the items from the json file straight into template vars (not via variables) and fixing some double quotes to single quotes.
PHPBB3-10631
* Fyorl/feature/attach-dl: (75 commits)
[feature/attach-dl] Removed the use of some abbreviations
[feature/attach-dl] Changed $files_added checks
[feature/attach-dl] Renamed $post_id to $post_msg_id
[feature/attach-dl] Fixed a comment
[feature/attach-dl] Optimised an sql query
[feature/attach-dl] Fixed the logic in an sql statement
[feature/attch-dl] $forum_id cast to int
[feature/attach-dl] Fixed $file_added to $files_added
[feature/attach-dl] Moved definition of $archive_name
[feature/attach-dl] Swapped the order of an if statement
[feature/attach-dl] Cast variables to int
[feature/attach-dl] Added $archive_path
[feature/attach-dl] Used COMMA_SEPARATOR instead of actual comma
[feature/attach-dl] Renamed $count to $files_added
[feature/attach-dl] Removed sprintf() use
[feature/attach-dl] Removed need for array_keys()
[feature/attach-dl] Added multiple attachment downloads to PMs
[feature/attach-dl] Removed reliance on current($row)
[feature/attach-dl] Renamed to phpbb_download_handle_forum_auth
[feature/attach-dl] Moved PM authentication handling into own function
...
For some reason, all errors are just flipped on before connecting to the
database, despite the system as a whole having a different setting for
displayable errors. Had to add & ~E_STRICT in PHP 5.4.5 to suppress Strict
Standards messages, but I would assume that the db piece shouldn't be involved
with setting error_reporting at all.
PHPBB3-11066
* dhruvgoel92/ticket/11048:
[ticket/11048] use protected instead of private in pgsql fulltext
[ticket/11048] use protected instead of private in native search
[ticket/11048] remove @access from all docblocks
[ticket/11048] use protected instead of private in mysql fulltext
[ticket/11048] use protected instead of private in sphinx
[ticket/11048] add access specifiers to phpbb native search properties
[ticket/11048] add access specifiers to sphinx search
[ticket/11048] add access specifiers to phpbb native search
[ticket/11048] add access specifiers to mysql search
[ticket/11048] add access specifiers to pgsql search
