1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-29 18:50:25 +02:00

1132 Commits

Author SHA1 Message Date
Joas Schilling
af9f30cd52 [ticket/11469] Use method to check config count, instead of repeating it
PHPBB3-11469
2013-03-27 14:09:04 +01:00
Joas Schilling
8dd26dee83 [ticket/11469] Add some basic unit tests for phpbb_db_sql_insert_buffer
PHPBB3-11469
2013-03-27 14:00:46 +01:00
Joas Schilling
bdd2062a66 [ticket/11474] Add test user with only global m_approve permissions
PHPBB3-11405
PHPBB3-11474
2013-03-27 11:12:33 +01:00
Nils Adermann
b7778f7fde Merge remote-tracking branch 'github-bantu/ticket/11460' into develop
* github-bantu/ticket/11460:
  [ticket/11460] Add default behaviour tests for notification and email types.
  [ticket/11460] Configure functional test board email using dummy SMTP data.
  [ticket/11460] Add test for whether post_email and topic_email are checked.
  [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
  [ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
2013-03-27 06:31:53 +01:00
Joas Schilling
8a94e08e30 [ticket/11405] Add unit tests for post_in_queue
PHPBB3-11405
2013-03-26 20:17:26 +01:00
Joas Schilling
0f204595d9 [ticket/11405] Fix "only variables should be passed by reference"
PHPBB3-11405
2013-03-26 20:17:24 +01:00
Joas Schilling
e20b0a4234 [ticket/11405] Use different fixtures so it's not a total mess
PHPBB3-11405
2013-03-26 13:06:04 +01:00
Joas Schilling
7e2f80ec0a [ticket/11405] Add unit tests for bookmarking
PHPBB3-11405
2013-03-26 12:59:35 +01:00
Joas Schilling
cdd45cb8ba [ticket/11405] Move test to submit_post_base.php and use data sets for testing
PHPBB3-11405
2013-03-26 12:58:14 +01:00
Joas Schilling
053c75543d [ticket/11405] Correctly prefill the tables (missed the posts and not-types)
PHPBB3-11405
2013-03-25 15:34:18 +01:00
Joas Schilling
060876e627 [ticket/11405] Add a base class to avoid duplicated setUp() code
PHPBB3-11405
2013-03-25 15:16:29 +01:00
Joas Schilling
499eded880 [ticket/11405] Add unit tests for quoted users notifications
PHPBB3-11405
2013-03-25 15:07:05 +01:00
Joas Schilling
7d5949ae3d [ticket/11405] Fix some coding style issues
PHPBB3-11405
2013-03-25 14:37:22 +01:00
Joas Schilling
a91ffe06c7 [ticket/11405] Send post notifications to forum subscribers
Like in 3.0 we should also send notifications about new posts to users
that subscribed to the forum. (Subscriptions are verbose)

PHPBB3-11405
2013-03-25 09:28:53 +01:00
Andreas Fischer
d3decaeedf [ticket/11460] Add default behaviour tests for notification and email types.
PHPBB3-11460
2013-03-24 23:42:13 +01:00
Joas Schilling
bc5f8e30d0 [ticket/11405] Add some basic tests for notifications in submit_post()
Poster, should NOT receive a notification
Topic subscribed, should receive a notification
Topic subscribed, but unauthed to read, should NOT receive a notification
Topic subscribed, but already notified, should NOT receive a new notification
Topic and forum subscribed, should receive ONE notification
Forum subscribed, should receive a notification
Forum subscribed, but already notified, should NOT receive a new notification

PHPBB3-11405
2013-03-23 13:20:32 +01:00
Andreas Fischer
02817158fc [ticket/11460] Configure functional test board email using dummy SMTP data.
PHPBB3-11460
2013-03-22 22:42:05 +01:00
Andreas Fischer
69df6b49db [ticket/11460] Add test for whether post_email and topic_email are checked.
PHPBB3-11460
2013-03-22 22:16:24 +01:00
Andreas Fischer
15aec0bbb2 [ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
PHPBB3-11460
2013-03-21 03:07:50 +01:00
Andreas Fischer
3c99a33e87 [ticket/11457] Remove check and include for set_var function. It's not used.
PHPBB3-11457
2013-03-17 18:58:43 +01:00
Andreas Fischer
51c1ba12c1 Merge remote-tracking branch 'nickvergessen/ticket/11443' into develop
* nickvergessen/ticket/11443:
  [ticket/11443] Fix Migrator Modules Tool by creating a phpbb_log object
  [ticket/11443] Add _test suffix to migration test filenames
2013-03-16 01:44:36 +01:00
Joas Schilling
4168cfd7e6 [ticket/11443] Fix Migrator Modules Tool by creating a phpbb_log object
PHPBB3-11443
2013-03-16 01:24:50 +01:00
Joas Schilling
afd3681208 Merge remote-tracking branch 'bantu/ticket/11441' into develop
* bantu/ticket/11441:
  [ticket/11441] Split user loader tests into multiple test methods.
  [ticket/11441] Use setUp() in phpbb_user_loader_test.
  [ticket/11441] Update/correct copyright year of user loader test.
  [ticket/11441] Correct/fix class name of user loader test.
  [ticket/11441] Add _test prefix to user loader test filename.
2013-03-15 19:06:54 +01:00
Joas Schilling
3b0cdc5362 [ticket/11334] Allow parameters to be specified in the route
PHPBB3-11334
2013-03-15 15:21:15 +01:00
Joas Schilling
9157095cda [ticket/11334] Fix copyright year in test file
PHPBB3-11334
2013-03-15 09:18:15 -04:00
Joas Schilling
076711d9a9 [ticket/11334] Use mocks instead of making parameters optional
PHPBB3-11334
2013-03-15 09:18:14 -04:00
Joas Schilling
9259e635ca [ticket/11334] Move unit tests for helper->url() into own file
PHPBB3-11334
2013-03-15 09:18:13 -04:00
Joas Schilling
cd697e6812 [ticket/11334] Include functions.php and fix class name in tests
PHPBB3-11334
2013-03-15 09:18:11 -04:00
David King
48aefb13b0 [ticket/11334] Make $phpbb_dispatcher global, as done in append_sid test
PHPBB3-11334
2013-03-15 09:18:09 -04:00
David King
d3e2fae66d [ticket/11334] Add a test for the controller helper URL method
PHPBB3-11334
2013-03-15 09:18:07 -04:00
Joas Schilling
2cd1c62403 [ticket/11443] Add _test suffix to migration test filenames
PHPBB3-11443
2013-03-15 10:23:14 +01:00
Andreas Fischer
15cade3dc5 [ticket/11439] Add _test suffix to notification test filename.
PHPBB3-11439
2013-03-15 10:21:09 +01:00
Andreas Fischer
ba460d98f1 [ticket/11441] Split user loader tests into multiple test methods.
PHPBB3-11441
2013-03-15 01:36:05 +01:00
Andreas Fischer
ef1caf6933 [ticket/11441] Use setUp() in phpbb_user_loader_test.
PHPBB3-11441
2013-03-15 01:32:33 +01:00
Andreas Fischer
e1e9138c3b [ticket/11441] Update/correct copyright year of user loader test.
PHPBB3-11441
2013-03-15 01:28:27 +01:00
Andreas Fischer
3c09612d36 [ticket/11441] Correct/fix class name of user loader test.
PHPBB3-11441
2013-03-15 01:26:26 +01:00
Andreas Fischer
eabcbb9baf [ticket/11441] Add _test prefix to user loader test filename.
PHPBB3-11441
2013-03-15 01:25:10 +01:00
Joas Schilling
1fd5be859e [ticket/11362] Add unit test for ../ in directory paths
PHPBB3-11362
2013-03-12 22:45:44 +01:00
Nathan Guse
d4ee7718b9 Merge remote-tracking branch 'remotes/Marc/ticket/11404' into develop
# By Marc Alexander
# Via Marc Alexander
* remotes/Marc/ticket/11404:
  [ticket/11404] Remove version ID from manager_test.php file header
  [ticket/11404] Add tests for phpbb_avatar_manager::clean_row()
  [ticket/11404] Convert manager_test to UNIX line endings
  [ticket/11404] Use a default data row if $row is empty in clean_row()
  [ticket/11404] Return empty array of avatar data if $row is empty
2013-03-12 14:48:07 -05:00
Marc Alexander
4ad8fcbd58 [ticket/11404] Remove version ID from manager_test.php file header
PHPBB3-11404
2013-03-11 10:35:18 +01:00
Marc Alexander
fb1984dadb [ticket/11404] Add tests for phpbb_avatar_manager::clean_row()
PHPBB3-11404
2013-03-11 10:34:25 +01:00
Marc Alexander
2ec0dc5b34 [ticket/11404] Convert manager_test to UNIX line endings
PHPBB3-11404
2013-03-11 10:34:12 +01:00
Nathaniel Guse
3f5d938a95 Merge remote-tracking branch 'remotes/marc/ticket/11323' into develop
# By Marc Alexander
# Via Marc Alexander
* remotes/marc/ticket/11323:
  [ticket/11323] Reduce additional code and revert regex to previous one
  [ticket/11323] Enable tests for inclusion of defined variables
  [ticket/11323] Correctly treat variables in template defines
2013-03-09 19:02:44 -06:00
Andreas Fischer
32ff2348f1 [ticket/10202] Rename method names _all() to _array().
PHPBB3-10202
2013-03-05 23:15:46 +01:00
Andreas Fischer
828c6c01bb [ticket/10202] Add tests for phpbb_config_db_text.
PHPBB3-10202
2013-03-05 22:59:57 +01:00
Nathaniel Guse
cb4bd3f881 Merge remote-tracking branch 'remotes/nickv/ticket/10714' into develop
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/10714: (56 commits)
  [ticket/10714] Get log from container in install, update and download/file
  [ticket/10714] Use $phpbb_adm_relative_path instead of hardcoded adm/
  [ticket/10714] Logs are disabled for this page call only
  [ticket/10714] Update add_log docs block with @param and @deprecated
  [ticket/10714] Remove fallback code from previous commits and move global
  [ticket/10714] Fix missing parameter and global phpbb_log in unit tests
  [ticket/10714] Add getter for is_in_admin and use it
  [ticket/10714] Fix more comments
  [ticket/10714] Cast values to integer before using them in the query
  [ticket/10714] Fix several doc blocks and comments
  [ticket/10714] Fix missing 8th argument in unit tests
  [ticket/10714] Use new core.adm_relative_path to create the object.
  [ticket/10714] Fix several comments and variable names
  [ticket/10714] Fix database driver class name
  [ticket/10714] Forgot most important, use container to create $phpbb_log
  [ticket/10714] Remove type hinting to allow the usage of mocks in tests
  [ticket/10714] Fix dependency injections in unit tests with mocks
  [ticket/10714] Use dependencies instead of globals
  [ticket/10714] Compare log_type to false, rather then null
  [ticket/10714] Add global variables for the unit tests
  ...
2013-03-04 18:11:42 -06:00
Nathaniel Guse
c1840c78c5 Merge branch 'develop' of git://github.com/phpbb/phpbb3 into ticket/11386-3
Conflicts:
	phpBB/includes/db/migrator.php
2013-03-04 13:48:29 -06:00
Nathaniel Guse
941b7287b7 Merge remote-tracking branch 'remotes/marc/feature/avatars' into develop
# By Marc Alexander (100) and others
# Via Marc Alexander (8) and Igor Wiedler (3)
* remotes/marc/feature/avatars: (138 commits)
  [feature/avatars] Update module_auth of ucp module and fix small issues
  [feature/avatars] Add migrations data file for avatars
  [feature/avatars] Reduce module auth of ucp avatar settings
  [feature/avatars] Auto-clear avatar dimensions when first changing avatars
  [feature/avatars] Use "Main" as category for avatars in root of gallery
  [feature/avatars] Remove trailing whitespace from avatar code
  [feature/avatars] Pass phpbb_user to prepare and process form functions
  [feature/avatars] Document the use of the allowed extensions array
  [feature/avatars] Use array for allowed extensions and implode if needed
  [feature/avatars] Use deprecated for compatibility function
  [feature/avatars] Correct license, copyright and package info
  [feature/avatars] Move list of supported formats to avatar driver class
  [feature/avatars] Add include of functions_display.php in BC function
  [feature/avatars] Add note about when compatibility function was added
  [feature/avatars] Add compatibility function for get_user_avatar()
  [feature/avatars] Move definition of driver_collection to avatars.yml
  [feature/avatars] Remove the obsolete request argument for avatar drivers
  [feature/avatars] Add missing @var to docblocks in avatar manager
  [feature/avatars] Remove not needed inline style
  [feature/avatars] Differentiate tests for get drivers functions
  ...
2013-03-04 13:33:42 -06:00
Nathaniel Guse
029f096411 Merge remote-tracking branch 'remotes/nickv/ticket/10411-2' into develop
# By Joas Schilling
# Via Joas Schilling
* remotes/nickv/ticket/10411-2: (33 commits)
  [ticket/10411] Fix call to function on non-object $db->...()
  [ticket/10411] Remove ajax delete, so the page is refreshed
  [ticket/10411] Update schema file with new table and remove the column
  [ticket/10411] Add unit tests for move() with values >1
  [ticket/10411] Add migrations file for teampage table
  [ticket/10411] Revert database_update.php changes from for easier update
  [ticket/10411] Add maxlength to category name input field
  [ticket/10411] Test for thrown exceptions when group does not exist
  [ticket/10411] Catch exceptions from grouppositions
  [ticket/10411] Throw exceptions instead of using trigger_error()
  [ticket/10411] Add return values to add/delete function
  [ticket/10411] Add return value to move functions
  [ticket/10411] Fix typehinting and change private to protected
  [ticket/10411] Use template loops instead of defining the html in php files
  [ticket/10411] Ensure we only get services that do exist
  [ticket/10411] Add a comment why we left join the group table
  [ticket/10411] Rename template variable CUR_ to CURRENT_
  [ticket/10411] Move globals to the top and use array for cache destroy
  [ticket/10411] Use new ajax callback name row_up/row_down
  [ticket/10411] Fix logic error when editing/creating a group
  ...
2013-03-04 13:25:53 -06:00
Joas Schilling
e512ad6726 Merge branch 'develop' of https://github.com/phpbb/phpbb3 into ticket/10714
* 'develop' of https://github.com/phpbb/phpbb3: (255 commits)
  [ticket/6723] Show info that message has been deleted before delivery
  [ticket/11385] Fix issue with migration module tool not getting extension module info
  [ticket/11386] Fix failing tests from constructor changes
  [ticket/11386] Fix circular reference error & serialize error
  [ticket/11386] Remove tests that check if finder cache is working
  [ticket/11386] Forgot to get the migration classes
  [ticket/11386] Update tests with new constructors for ext.manager/migrator
  [ticket/11386] Use finder to find migration files
  [ticket/11363] Fix to make get_module_infos get from all extensions
  [ticket/11381] Make finder able to search in all available extensions
  [ticket/11103] Revert whitespace changes
  [ticket/11103] Few more minor language things
  [ticket/11103] Don't call generate_board_url many times
  [ticket/11103] Case time in queries as an int
  [ticket/11103] Fix effectively installed check
  [ticket/11103] Remove padding from notifications for now.
  [ticket/11363] Fix a couple bugs and throw errors if the file not found
  [ticket/11372] Migrator should only check if effectively installed if not
  [ticket/11363] Load module info files for extensions too
  [ticket/11103] Notifications Migration file
  ...

Conflicts:
	phpBB/config/services.yml
	phpBB/config/tables.yml
2013-03-04 05:11:32 +01:00