1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-15 12:05:21 +02:00

27 Commits

Author SHA1 Message Date
Joas Schilling
c72f5bf487 [ticket/11495] Explain use of set_subset_zero on remove_subset()
PHPBB3-11495
2013-04-25 16:24:31 +02:00
Joas Schilling
804f139be0 [ticket/11495] Use default exceptions
PHPBB3-11495
2013-04-25 16:17:58 +02:00
Joas Schilling
9d7d962c0d [ticket/11495] Explain what "given item" means
PHPBB3-11495
2013-04-25 14:08:06 +02:00
Joas Schilling
fe97915fc9 [ticket/11495] Split get_branch_data into multiple methods
PHPBB3-11495
2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f [ticket/11495] Rename set_parent to change_parent()
PHPBB3-11495
2013-04-25 13:48:19 +02:00
Joas Schilling
3efae6d8af [ticket/11495] Explain whether move_children prepends/appends/overwrittes
PHPBB3-11495
2013-04-25 13:44:52 +02:00
Joas Schilling
4bff28a0ee [ticket/11495] Rename fix function to regenerate_left_right_ids()
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set

When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.

PHPBB3-11495
2013-04-25 13:40:25 +02:00
Joas Schilling
61e72d3a10 [ticket/11495] Explain move() more
An item is only moved up/down within the same parent. If the delta is larger
then the number of children, the item is moved to the top/bottom of the list
of children within this parent.

PHPBB3-11495
2013-04-25 13:09:00 +02:00
Joas Schilling
e8b192fa32 [ticket/11495] Do not compare to null anymore (left over from item class)
PHPBB3-11495
2013-04-25 12:57:21 +02:00
Joas Schilling
87dc3b1e55 [ticket/11495] Use item ids instead of requiring all data
The data is grabbed again in most cases anyway, so it just makes the system
easier to use.

PHPBB3-11495
2013-04-19 21:07:42 +02:00
Joas Schilling
f66b5323a7 [ticket/11495] Cast some values to int
PHPBB3-11495
2013-04-19 19:09:22 +02:00
Joas Schilling
3d54a81ed9 [ticket/11495] Use item_id only as parameter for delete() and remove()
The data is acquired again anyway

PHPBB3-11495
2013-04-19 16:19:01 +02:00
Joas Schilling
d24ff2329f [ticket/11495] Use item_id only as parameter for get_branch_data()
PHPBB3-11495
2013-04-19 16:18:03 +02:00
Joas Schilling
f3ff8b36be [ticket/11495] Fix Spacing and lowercase on docs
PHPBB3-11495
2013-04-19 01:14:38 +02:00
Joas Schilling
5cb7342dd3 [ticket/11495] Remove acquire locks from forum implementation
PHPBB3-11495
2013-04-18 22:17:05 +02:00
Joas Schilling
b28180be1d [ticket/11495] Acquire locks for operations that manipulate the tree
PHPBB3-11495
2013-04-18 22:16:14 +02:00
Joas Schilling
153b29c6c9 [ticket/11495] Remove item class as its no longer required
PHPBB3-11495
2013-04-18 19:31:08 +02:00
Joas Schilling
a183fc1118 [ticket/11495] Manually specify the table columns
PHPBB3-11495
2013-04-18 00:54:26 +02:00
Joas Schilling
514bcb2fac [ticket/11495] Move nestedset default values to new method
PHPBB3-11495
2013-04-18 00:50:30 +02:00
Joas Schilling
e0393a3062 [ticket/11495] Fix column variable names
PHPBB3-11495
2013-04-18 00:34:09 +02:00
Joas Schilling
86937e03ec [ticket/11495] Remove item classes
PHPBB3-11495
2013-04-18 00:15:02 +02:00
Joas Schilling
8c3443ba99 [ticket/11495] Use array directly instead of phpbb_nestedset_item_interface
PHPBB3-11495
2013-04-18 00:13:19 +02:00
Joas Schilling
5c379db085 [ticket/11495] Fix description of get_sql_where
PHPBB3-11495
2013-04-17 22:56:12 +02:00
Joas Schilling
f831e3c66e [ticket/11495] Use unique properties for the column names
PHPBB3-11495
2013-04-17 22:52:17 +02:00
Joas Schilling
57a05e7cf5 [ticket/11495] Add forum implementation of nestedset
PHPBB3-11495
2013-04-16 23:09:21 +02:00
Joas Schilling
0d5efcc1d5 [ticket/11495] Add abstract implementation of the interface
PHPBB3-11495
2013-04-16 23:08:35 +02:00
Joas Schilling
a1183a5889 [ticket/11495] Add basic interface with nestedset operations
PHPBB3-11495
2013-04-16 23:07:48 +02:00