1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-05-28 10:09:15 +02:00

90 Commits

Author SHA1 Message Date
Chris Smith
67a70f7fd4 - Removed redundant code and unnecessary queries in forum management. #42265
- Fixed use of <b> instead of <strong> in ACP


git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9344 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-02-27 16:29:29 +00:00
Jim Wigginton
06a47f8d8b Fixed bug #39005 - check forum_image whether it exists
Authorised by: acydburn

git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9309 89ea8834-ac86-4346-8a33-228a782c2dd0
2009-01-27 19:16:29 +00:00
Meik Sievertsen
0b0da7b333 do not allow categories to be locked by accident (Bug #14548)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8898 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-19 17:07:13 +00:00
Meik Sievertsen
5f7e847b57 Prevent integer overflow - Bug #19895
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8876 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-18 14:26:56 +00:00
Meik Sievertsen
80254760d1 Do not allow setting forums parent to the forum itself. (Bug #18855)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8870 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-18 13:21:16 +00:00
Meik Sievertsen
5c4870fcce Fix one design failure in phpBB3. Do not count non-approved posts to the user_posts. Before, a user was able to circumvent basically any protection based on post counts.
At the same time implement the queue_trigger feature.

git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8805 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-09-02 06:36:24 +00:00
Meik Sievertsen
d22e2697e9 Fix some instances where we left db connections open (registration -> captcha for example)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8655 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-06-13 19:39:01 +00:00
Henry Sudhof
0a37e9a929 Using new validation options;
#15539


git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8407 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-02-27 15:10:10 +00:00
Nils Adermann
cc24876726 merging r8373 into 3.0 branch: adding a new option to hide the entire list of subforums on listforums
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8374 89ea8834-ac86-4346-8a33-228a782c2dd0
2008-02-03 22:55:10 +00:00
Henry Sudhof
da7fc3d188 #15554
#15464
#15384
Yes, there is a lang change.


git-svn-id: file:///svn/phpbb/trunk@8253 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-11-27 15:13:50 +00:00
Henry Sudhof
83251720de indeed.
#14789


git-svn-id: file:///svn/phpbb/trunk@8197 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-15 18:06:40 +00:00
Meik Sievertsen
6e0dd97c60 *** empty log message ***
git-svn-id: file:///svn/phpbb/trunk@8194 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-14 23:10:22 +00:00
Meik Sievertsen
1f8dec8c69 use language variable
git-svn-id: file:///svn/phpbb/trunk@8186 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-14 17:50:37 +00:00
Meik Sievertsen
0b0a1f974e tiny tiny tiny
git-svn-id: file:///svn/phpbb/trunk@8172 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-13 10:30:51 +00:00
Henry Sudhof
39ff42edae Lets put it back where it belongs.
git-svn-id: file:///svn/phpbb/trunk@8171 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-13 10:26:13 +00:00
Henry Sudhof
b5b2610a1f errm, we actually want that.
git-svn-id: file:///svn/phpbb/trunk@8170 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-13 10:07:02 +00:00
Meik Sievertsen
7de5bb3498 dumdidum... sorry. ;)
git-svn-id: file:///svn/phpbb/trunk@8147 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-05 14:36:34 +00:00
Henry Sudhof
7baf3ed140 #i43
git-svn-id: file:///svn/phpbb/trunk@8143 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-05 13:14:58 +00:00
Henry Sudhof
4defd8a830 Ok, here comes a big one. Poor updater. Also requires testing.
#i91
#i92
#i93
#i94
#i95
#i96


git-svn-id: file:///svn/phpbb/trunk@8120 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-10-03 15:05:54 +00:00
Meik Sievertsen
e3882844ec #i62 - #i65
gone through every javascript invocation and making sure we adhere to our coding guidelines.


git-svn-id: file:///svn/phpbb/trunk@8099 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-22 18:31:50 +00:00
Henry Sudhof
c8ecf341b9 Maybe - just maybe - it might a good idea to only allow users actually allowed to change permissions to do so.
git-svn-id: file:///svn/phpbb/trunk@8083 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-09-07 14:01:18 +00:00
Meik Sievertsen
1d004b925f necessary changes...
git-svn-id: file:///svn/phpbb/trunk@8072 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-08-30 21:21:16 +00:00
Meik Sievertsen
ec1da5b1fd try to normalize everything...
git-svn-id: file:///svn/phpbb/trunk@7920 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-22 20:11:45 +00:00
Henry Sudhof
9113553d83 err
git-svn-id: file:///svn/phpbb/trunk@7916 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-21 11:55:21 +00:00
Henry Sudhof
f1ba99ec0d #13663
git-svn-id: file:///svn/phpbb/trunk@7915 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-21 11:39:09 +00:00
Meik Sievertsen
683930ca4a - Handle forum links/redirects within viewforum if no read permission given (to display login box or error message) (Bug #13467)
- Prevent changing postable forum having subforums to link forum without moving subforums out first


git-svn-id: file:///svn/phpbb/trunk@7895 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-07-16 14:02:06 +00:00
Meik Sievertsen
455536773f ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
git-svn-id: file:///svn/phpbb/trunk@7736 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-06-09 11:11:20 +00:00
Henry Sudhof
20993d5cf1 Introduced checks to stop negative postcounts (Bug #11561, #11421)
Allow IP v4/v6 urls for remote avatars (Bug #11633)
 Delete avatar files automatically (Bug #11631)
 Automatically add selected columsn to group by statements in the converter (Bug #11465)


git-svn-id: file:///svn/phpbb/trunk@7677 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-25 16:03:40 +00:00
Meik Sievertsen
d5477a53da language change and reset locked status for link forum type.
git-svn-id: file:///svn/phpbb/trunk@7652 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-20 10:07:05 +00:00
Meik Sievertsen
0d7b31e884 added subforum read/unread icons (thanks to thatbitextra for providing them).
fixed issue with forum passwords only alloweing ASCII in administration while allowing non-ASCII on user-entered passwords


git-svn-id: file:///svn/phpbb/trunk@7581 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-15 10:55:17 +00:00
Meik Sievertsen
08f9803457 sync topics before forum.
git-svn-id: file:///svn/phpbb/trunk@7517 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-09 17:37:20 +00:00
Meik Sievertsen
aca6d695c8 fix moving forums around. :o
git-svn-id: file:///svn/phpbb/trunk@7498 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-07 15:17:01 +00:00
David M
dfe674ffa1 - changed the way we do forum accounting in phpBB, far less intensive and much faster. sync() recalculates the number of topics and posts using just the topics table instead of having to join topics and posts together. However, even this can be avoided if we know what operation is happening and an auto sync is not in action. Since MCP operations are "known", we can provide very fast MCP operations.
- changed the way we decide if a DB gets multi value support. Old method uses switch/case, new method assumes a DB can't unless the DB says it can via a property

I hope nothing is broken :P


git-svn-id: file:///svn/phpbb/trunk@7466 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-05 04:53:43 +00:00
Meik Sievertsen
a465b06923 added class for disabled options in ACP
E_USER_ERROR now using language keys if available [related to #10445]
UCP/MCP title tags [#10441]
Check $start parameter in viewforum [#10435]
Check for postable forum for moving user posts within users ACP [#10433]
Show error if admin tries to put forums beneath linked forums [related to #10433]
Correctly catch attachments while moving posts [#10431]
language change in install.html [#10425]
Updated AUTHORS file


git-svn-id: file:///svn/phpbb/trunk@7456 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-05-04 12:30:21 +00:00
David M
c411c05060 #9551
git-svn-id: file:///svn/phpbb/trunk@7318 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-04-09 19:44:25 +00:00
David M
c3418452fa *** empty log message ***
git-svn-id: file:///svn/phpbb/trunk@7189 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-14 20:53:25 +00:00
Meik Sievertsen
067bf38515 - fixed a bug in syncing forums/topics in ACP
- now also syncing moved topics having no information at all (this may only be triggered while converting)


git-svn-id: file:///svn/phpbb/trunk@7188 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-14 18:52:18 +00:00
Dominik Dröscher
44fab30002 Be gone thou hardcoded image dimensions! There is not enough room for both of us!
git-svn-id: file:///svn/phpbb/trunk@7137 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-03-06 16:06:19 +00:00
Meik Sievertsen
576bb754e9 fixing some bugs, most being submitted grammatical/spelling errors.
git-svn-id: file:///svn/phpbb/trunk@6915 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-01-21 18:33:45 +00:00
Meik Sievertsen
ff7686797a fixing some bugs
git-svn-id: file:///svn/phpbb/trunk@6905 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-01-18 14:41:13 +00:00
Meik Sievertsen
a841fe70a8 ok, handled some bugs... the most important being validate_username (the variable passed to validate_data([...]array('username', [...])) and updating group listings while doing relevant group actions. Oh, and PM icons are working now. :o
git-svn-id: file:///svn/phpbb/trunk@6894 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-01-17 18:41:49 +00:00
David M
3a2a61baa4 #6772
- some other random things


git-svn-id: file:///svn/phpbb/trunk@6880 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-01-11 05:44:22 +00:00
Meik Sievertsen
46c9da77a4 - do not allow setting the parent to currently assigned childs [Bug #6708]
- Allow the display_on_index setting to be specified for link forums [Bug #6660]
- Rank code in functions_display.php [Bug #6656]
- Added some new locations for the viewonline page [Related to bug #6484]
- Do not display attached images inline if user disabled image display in posts; the same with flash files [Bug #6226]


git-svn-id: file:///svn/phpbb/trunk@6829 89ea8834-ac86-4346-8a33-228a782c2dd0
2007-01-02 16:35:48 +00:00
Meik Sievertsen
d6ef968a67 - made sure ranks are displayed correctly (used RANK instead of RANK_TITLE)
- #6630
- hide a few links from bots (forum/topic marking, memberlist, post/reply/quote/edit/etc. buttons) [#6354]
- #5698


git-svn-id: file:///svn/phpbb/trunk@6818 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-12-28 16:21:17 +00:00
Meik Sievertsen
945afbc5fa Unused Code inside function update_forum_data [Bug #6606]
Copy permissions protection for groups [Bug #6594]
HTML issues in ACP [Bug #6580, #6578]
Always send the correct encoding [related to bug #6576]
Mass email fixes for first loop iteration [Bug #6570]
Extension groups to be allowed in PM's and/or Posts [Bug #6558]
Extension allowance checking clarified (no longer using forum id 0 for private messaging)
Using request_var() array method for some variables [Bug #6556]
Added confirmation for deletion of ranks/smilies/icons/word censores [Bug #6548, #6530, #6512, #6466]
Only show postable forums in dropdown list for moving posts on forum deletion as well as correct re-indexing [Bug #6510, #6476, #6384]
Jabber password being password field in jabber settings screen [Bug #6478]
user activity language variable if viewing not own profile [Bug #6432]
Show moderator group/user-name colour [Bug #6402]
Log rank creation/updating/removing [Bug #6398]
Update check permission changed from a_ to a_board [Bug #6392]


git-svn-id: file:///svn/phpbb/trunk@6816 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-12-27 17:43:55 +00:00
Meik Sievertsen
e264a62b73 - a handful of mcp fixed, the most important one is the change for check_ids() - it is now supporting ids from more than one forum too, making it possible to use some mcp features as designed initially. We really need to get our moderator team testing the mcp extensively.
- fixed some other tiny glitches
- if a forum category with subforums get changed to a link type forum give options of what to do with the subforums (#5334)
- other bugfixes


git-svn-id: file:///svn/phpbb/trunk@6601 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-11-18 16:27:35 +00:00
Meik Sievertsen
548cc2c10b - fixes for the following bugs:
#5326
#5318
#5304
#5290
#5288
#5278
#5276
#5272
#5266
- also fixed the "Call-time pass-by-reference" bug #5252
- within this step changed the normalize calls to require references.
- added captcha size variables to the class scope (suggestion was posted at area51)


git-svn-id: file:///svn/phpbb/trunk@6584 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-11-15 15:35:50 +00:00
David M
ad8fa012f5 This was caused by the removal of DEFAULT on some TEXT columns (MySQL really does not allow this). Only those using MySQL felt this issue :P
git-svn-id: file:///svn/phpbb/trunk@6524 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-10-23 22:32:37 +00:00
Meik Sievertsen
4afaca12dc - store sql_layer directly within the layer itself
- new method sql_multi_insert to circumvent db-specific hacks
(hopefully not introduced any parsing errors)


git-svn-id: file:///svn/phpbb/trunk@6497 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-10-14 14:56:46 +00:00
Meik Sievertsen
0b2aaae28b - forum image being an additional image instead of replacing forum indicators
- reasons fixes


git-svn-id: file:///svn/phpbb/trunk@6470 89ea8834-ac86-4346-8a33-228a782c2dd0
2006-10-08 19:04:49 +00:00