1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-07-11 04:06:31 +02:00
Commit Graph

111 Commits

Author SHA1 Message Date
rxu
800411e514 [ticket/14893] Fix undefined variable on reporting PM notification
PHPBB3-14893
2016-12-07 00:40:21 +07:00
4533dd9fa0 [ticket/14859] Notifications for PM reports send to users with correct permissions
Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-14859

This addresses the problem that notifications of new PM reports were not sent out to moderators that weren't global moderators but did have the permission "Can close/delete PM reports". 

PHPBB3-14859
2016-11-07 16:06:50 +01:00
06c980f1ec [ticket/14799] purge_notifications() should not leave open transactions.
When running purge_notifications(), if a notification type does not exist
then a db transaction is started but never completed.

On an error in get_notification_type_id(), end the transaction.

PHPBB3-14799
2016-09-27 11:45:23 -04:00
f68e98c064 [ticket/14745] Removed unneeded HTML ampersand
Changed the HTML ampersand entity in U_NOTIFICATION_SETTINGS into a bare
ampersand character.

PHPBB3-14745
2016-08-15 15:20:23 -04:00
c103c42857 [ticket/11446] Make get_notification_type_ids work with string too
PHPBB3-11446
2016-05-27 12:59:30 +02:00
7e6371ea8e [ticket/11446] Use sql_in_set properly in phpbb_notification_manager
PHPBB3-11446
2016-05-23 18:13:17 +02:00
3e278bcf0a [ticket/14533] U_NOTIFICATION_SETTINGS doesn't return the correct URL
PHPBB3-14533
2016-03-12 20:53:42 +01:00
7c45ed0733 Merge pull request #4206 from marc1706/ticket/14519
[ticket/14519] Skip query if all unread notifications are retrieved
2016-03-08 22:09:02 +01:00
10004c4032 [ticket/14132] Use transaction for adding notifications to type table
This will prevent a race condition that might occur by two posts being
submitted at the same time with the notification type IDs not being
cached.

PHPBB3-14132
2016-03-08 12:36:29 +01:00
9fcd0b116b [ticket/14519] Skip query if all unread notifications are retrieved
PHPBB3-14519
2016-03-08 12:15:21 +01:00
fdd5a18763 [ticket/14443] Introduce additional parameter to messenger
PHPBB3-14443
2016-02-01 23:11:39 +01:00
aaca64e13e [ticket/13892] Replace other uses of self with static.
PHPBB3-13892
2015-10-15 02:39:55 -07:00
9de5668b80 [ticket/13892] Respect "Someone reports a post" notification setting.
report_post inherits from post_in_queue, therefore using self:: instead of
static:: results in the incorrect notification type being used to determine
which users to exclude from the notification.

PHPBB3-13892
2015-10-15 02:28:55 -07:00
771090f13e [ticket/13711] Notifications are sent to inactive users
PHPBB3-13711
2015-07-27 06:27:25 -04:00
dc9245dd7a Merge pull request #3653 from callumacrae/ticket/13882
[ticket/13882] Lazy load the notification avatars.
2015-06-16 12:33:17 +02:00
be1d1c7d05 [ticket/13882] Lazy load the notification avatars.
This moves them further down the waterfall, making the page load
quicker.

PHPBB3-13882
2015-05-28 18:05:07 +02:00
a462f14aa3 [ticket/13790] Update phpcs
PHPBB3-13790
2015-05-19 22:19:18 +02:00
9b5493372d [ticket/13644] Always type hint dispatch_interface
PHPBB3-13644
2015-02-22 17:01:37 +01:00
a166f6f42c [ticket/13569] Add missing sql_freeresults and remove unneeded results
PHPBB3-13569
2015-02-02 17:36:39 +01:00
0929267e72 [ticket/13154] Wrong variable name in the comment block
PHPBB3-13154
2014-12-19 11:23:23 +00:00
dd9c415020 [ticket/13154] space before @var
Not a tab.

PHPBB3-13154
2014-12-19 10:03:57 +00:00
13320a08ef [ticket/13154] Forgot the $this->
PHPBB3-13154
2014-12-17 23:17:12 +00:00
458f9cade6 [ticket/13154] Adding phpBB dispatcher to notifications manager
PHPBB3-13154
2014-12-17 23:10:54 +00:00
7512efed9e [ticket/13154] Allow filtering the list of users to be notified
PHPBB3-13154
2014-12-17 15:17:44 +00:00
556565d072 [ticket/13337] Allow empty array passed to sql_in_set()
is_array() will evaluate to true even if the array is just an empty array.
Make sure we also expect an empty array passed to sql_in_set().

PHPBB3-13337
2014-11-14 11:08:35 +01:00
cb65cd363a [ticket/12703] Only query database for subscription types once
PHPBB3-12703
2014-10-26 13:56:34 -07:00
rxu
5431aa6391 [ticket/13223] Fix USERNAME email template variable in notification
admin_activate_user.php notification type is assigning usernames to email
template variables using user_loader->get_username() in 'no_profile' mode,
which in its turn calls get_username_string() function in 'no_profile' mode.
This causes HTML markup in emails for username colour.

PHPBB3-13223
2014-10-26 12:47:57 -07:00
fe80967535 [ticket/12990] Use the full services name for the notification's types
PHPBB3-12990
2014-08-16 21:46:03 +02:00
496b804a0f [ticket/12742] Add sorting back to bookmark notification list of users
PHPBB3-12742
2014-08-09 17:48:59 +02:00
57d94b7bb4 [ticket/12742] Add sort options for notification types requiring sorting
PHPBB3-12742
2014-08-09 17:43:28 +02:00
0de1d65804 [ticket/12742] Remove unneeded sort of users
It doesn't matter which user will get the notification first so we shouldn't
sort the users array.

PHPBB3-12742
2014-08-09 12:49:32 +02:00
6a13f983a4 [ticket/12742] Replace authenticated with authorised
PHPBB3-12742
2014-08-09 12:42:14 +02:00
cccd54dde8 [ticket/12742] Add check for empty $users and add method to fitting methods
The method might now return an empty array in case of an empty users array,
too. The notification types then check if the returned array is empty and
return this if it is empty and if the notification types would otherwise
carry out other operations afterwards.

PHPBB3-12742
2014-08-08 16:54:23 +02:00
80788980aa [ticket/12742] Add method for getting authenticated recipients
PHPBB3-12742
2014-08-08 16:43:31 +02:00
9133b913ec [ticket/12557] Fix post data description for notifications
PHPBB3-12557
2014-08-07 13:03:11 +03:00
6ac8d17af6 [ticket/12557] Fix doc block errors found by Sami
More corrections.

PHPBB3-12557
2014-08-03 07:13:20 +03:00
f34bc924a6 [ticket/12557] Notification fixes
PHPBB3-12557
2014-08-03 07:03:08 +03:00
74a37259f7 Merge remote-tracking branch 'PayBas/ticket/12608' into develop-ascraeus
* PayBas/ticket/12608:
  [ticket/12608] Change CSS classes to prevent styling conflicts
  [ticket/12608] Add subSilver
  [ticket/12608] Changed get_styling() to get_style_class()
  [ticket/12608] Remove somewhat redundant reported color style
  [ticket/12608] Improved LTR and various bugfixes
  [ticket/12608] Clean up whitespace
  [ticket/12608] Add styling (CSS class) options to notifications
  [ticket/12608] Updated tests
  [ticket/12608] Improve notifications drop-down menu styling in header
2014-06-22 15:44:06 -07:00
1a3c1d5b9a [ticket/12608] Change CSS classes to prevent styling conflicts
PHPBB3-12608
2014-06-22 22:41:56 +02:00
f4ef1ab6bd [ticket/12715] Add missing new line in the notification manager
PHPBB3-12715
2014-06-16 01:01:10 +02:00
52e8359497 [ticket/12715] Cleanup comments in \phpbb\notification\*
PHPBB3-12715
2014-06-15 19:14:56 +02:00
8e06d76aaa [ticket/12608] Changed get_styling() to get_style_class()
PHPBB3-12608
2014-06-15 10:02:11 +02:00
976bda83db [ticket/12608] Improved LTR and various bugfixes
PHPBB3-12608
2014-06-15 10:02:10 +02:00
49a1896a76 [ticket/12608] Clean up whitespace
PHPBB3-12608
2014-06-15 10:02:10 +02:00
693cbd247c [ticket/12608] Add styling (CSS class) options to notifications
This will allow different notifications to have different styles

PHPBB3-12608
2014-06-15 10:02:09 +02:00
d5f4d288e9 [ticket/12608] Improve notifications drop-down menu styling in header
PHPBB3-12608
2014-06-15 10:02:08 +02:00
f5415619eb [ticket/11445] Move get user's notification code into its own method
PHPBB3-11445
2014-06-07 01:34:20 +05:30
ac74dc876c [ticket/11445] Remove unused foreach key $group_name
PHPBB3-11445
2014-06-07 01:00:09 +05:30
572debd0e8 [ticket/11445] Optimize no of queries in get_global_subscriptions
PHPBB3-11445
2014-06-01 13:38:37 +05:30
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00