Joas Schilling
d24ff2329f
[ticket/11495] Use item_id only as parameter for get_branch_data()
...
PHPBB3-11495
2013-04-19 16:18:03 +02:00
Joas Schilling
f3ff8b36be
[ticket/11495] Fix Spacing and lowercase on docs
...
PHPBB3-11495
2013-04-19 01:14:38 +02:00
Joas Schilling
5cb7342dd3
[ticket/11495] Remove acquire locks from forum implementation
...
PHPBB3-11495
2013-04-18 22:17:05 +02:00
Joas Schilling
b28180be1d
[ticket/11495] Acquire locks for operations that manipulate the tree
...
PHPBB3-11495
2013-04-18 22:16:14 +02:00
Joas Schilling
153b29c6c9
[ticket/11495] Remove item class as its no longer required
...
PHPBB3-11495
2013-04-18 19:31:08 +02:00
Joas Schilling
a183fc1118
[ticket/11495] Manually specify the table columns
...
PHPBB3-11495
2013-04-18 00:54:26 +02:00
Joas Schilling
514bcb2fac
[ticket/11495] Move nestedset default values to new method
...
PHPBB3-11495
2013-04-18 00:50:30 +02:00
Joas Schilling
e0393a3062
[ticket/11495] Fix column variable names
...
PHPBB3-11495
2013-04-18 00:34:09 +02:00
Joas Schilling
86937e03ec
[ticket/11495] Remove item classes
...
PHPBB3-11495
2013-04-18 00:15:02 +02:00
Joas Schilling
8c3443ba99
[ticket/11495] Use array directly instead of phpbb_nestedset_item_interface
...
PHPBB3-11495
2013-04-18 00:13:19 +02:00
Joas Schilling
5c379db085
[ticket/11495] Fix description of get_sql_where
...
PHPBB3-11495
2013-04-17 22:56:12 +02:00
Joas Schilling
f831e3c66e
[ticket/11495] Use unique properties for the column names
...
PHPBB3-11495
2013-04-17 22:52:17 +02:00
Joas Schilling
57a05e7cf5
[ticket/11495] Add forum implementation of nestedset
...
PHPBB3-11495
2013-04-16 23:09:21 +02:00
Joas Schilling
0d5efcc1d5
[ticket/11495] Add abstract implementation of the interface
...
PHPBB3-11495
2013-04-16 23:08:35 +02:00
Joas Schilling
a1183a5889
[ticket/11495] Add basic interface with nestedset operations
...
PHPBB3-11495
2013-04-16 23:07:48 +02:00
Marc Alexander
c1dedabdfb
[ticket/11488] Use correct base class in email notification method
...
In ticket/11451 this was not correctly changed to reflect the new class
phpbb_notifcation_method_messenger_base. Additionally, an undefined
variable error has been fixed in messenger_base.php (change should be
confirmed by bantu though).
PHPBB3-11488
2013-04-15 12:50:21 +02:00
Nils Adermann
653666c76e
Merge branch 'develop-olympus' into develop
...
* develop-olympus:
[ticket/11358] Removed all trailing white spaces.
[ticket/11358] Fixed the code according to coding guidlines.
2013-04-12 14:03:56 +02:00
Nils Adermann
0ce94fde77
Merge branch 'ticket/11358' into develop-olympus
...
* ticket/11358:
[ticket/11358] Removed all trailing white spaces.
[ticket/11358] Fixed the code according to coding guidlines.
2013-04-12 14:03:24 +02:00
erangamapa
7d8bbcd596
[ticket/11358] Removed all trailing white spaces.
...
Removed all trailing white spaces with new lines.
PHPBB3-11358
2013-04-12 14:03:06 +02:00
erangamapa
00b45fa4dc
[ticket/11358] Fixed the code according to coding guidlines.
...
Added proper indentation and new line after break in switch
statement.
PHPBB3-11358
2013-04-12 14:02:51 +02:00
rechosen
694eb3ccb5
[ticket/11116] Made ACP "extension not available" error message E_USER_WARNING
...
The error message generated when an administrator tries to enable an
incompatible extension used to be displayed in the green of the default
E_USER_NOTICE. Changed it to E_USER_WARNING to make it appear in red, as
requested in the ticket.
PHPBB3-11116
2013-04-11 13:13:50 +02:00
Nils Adermann
3985bdbc1b
Merge pull request #1199 from imkingdavid/ticket/11334
...
[ticket/11334] Properly generate controller URL with helper url() method
2013-04-03 06:44:15 -07:00
Nils Adermann
a7cf2bdace
Merge pull request #1323 from t-backoff/ticket/11477
...
Ticket/11477
2013-03-31 15:57:26 -07:00
Tabitha Backoff
5d669ed1c5
Changing effectively_installed function to check if the config var is set.
2013-03-31 18:46:25 -04:00
Nils Adermann
78dc1c84c8
Merge pull request #1316 from nickvergessen/ticket/11405
...
Ticket/11405 Users that are subscribed to a forum, should receive notifications for new replies
2013-03-31 15:02:48 -07:00
Nils Adermann
8231b881ad
Merge pull request #1287 from erangamapa/ticket/11106
...
[ticket/11106] Undefined index EDITED_TIME_TOTAL notice.
2013-03-31 14:54:23 -07:00
Nils Adermann
fd7db5cc1f
Merge pull request #1296 from bantu/ticket/11440
...
[ticket/11440] Cast values of the $user_ids array to integer before sql_in_set.
2013-03-31 14:42:43 -07:00
Nils Adermann
133307b6bf
Merge pull request #1300 from bantu/ticket/11451
...
[ticket/11445] Add abstract class phpbb_notification_method_messenger_ba...
2013-03-29 08:58:40 -07:00
Andreas Fischer
b156b22f35
[ticket/11403] Use an instance of phpbb_db_sql_insert_buffer instead.
...
PHPBB3-11403
2013-03-29 16:53:50 +01:00
Andreas Fischer
6910d44154
[ticket/11403] phpbb_notification_manager: Use SQL multi insert in batches.
...
PHPBB3-11403
2013-03-29 16:37:04 +01:00
Tabitha Backoff
a8f5695666
Migration file and change board_home_text to board_index_text
2013-03-28 17:53:14 -04:00
Tabitha Backoff
9e5cde7f66
Ticket# 11477 - Allow customisation of "Board index"
2013-03-28 02:34:36 -04:00
Andreas Fischer
4bd5f279dc
[ticket/11469] Add comment about using bitwise operator.
...
PHPBB3-11469
2013-03-28 00:28:51 +01:00
Andreas Fischer
1bd13acb75
[ticket/11469] Use multi insert property from DB. Do not copy value to buffer.
...
PHPBB3-11469
2013-03-28 00:28:50 +01:00
Andreas Fischer
4132573088
[ticket/11469] Use buffer with a single element instead of extra code path.
...
PHPBB3-11469
2013-03-28 00:28:50 +01:00
Joas Schilling
c9f059c4f2
[ticket/11469] Cast $result to boolean in insert_all()
...
|= returns integer values
PHPBB3-11469
2013-03-27 20:55:48 +01:00
Andreas Fischer
53f9e2131c
[ticket/11469] Add note about calling flush() after batch insert is done.
...
PHPBB3-11469
2013-03-27 19:27:27 +01:00
Andreas Fischer
dc766f29b4
[ticket/11469] Have all methods of phpbb_db_sql_insert_buffer provide feedback.
...
PHPBB3-11469
2013-03-27 19:19:26 +01:00
Andreas Fischer
8c5fcac232
[ticket/11469] Add benefits over collecting huge insert arrays to class doc.
...
PHPBB3-11469
2013-03-27 18:22:59 +01:00
Andreas Fischer
55fb87ff18
Merge remote-tracking branch 'nickvergessen/ticket/bantu/11469' into ticket/11469
...
* nickvergessen/ticket/bantu/11469:
[ticket/11469] Use method to check config count, instead of repeating it
[ticket/11469] Return after sql_multi_insert when multi_insert is false
[ticket/11469] Add some basic unit tests for phpbb_db_sql_insert_buffer
2013-03-27 18:11:49 +01:00
Andreas Fischer
43b6ae3fee
Merge remote-tracking branch 'phpbb/develop' into ticket/11469
...
* phpbb/develop:
[ticket/11476] Remove pass-by-reference from sql_mutli_insert
[ticket/11466] Remove old database driver files from PHPUnit exclude
[ticket/11448] Use of $user_id parameter to mark a user's notifications read
[ticket/11460] Add default behaviour tests for notification and email types.
[ticket/11460] Configure functional test board email using dummy SMTP data.
[ticket/11460] Add test for whether post_email and topic_email are checked.
[ticket/11460] Add methods for checkbox handling to phpbb_functional_test_case.
[ticket/11460] Drop incorrect phpbb_notification_{type,method}_ prefix.
2013-03-27 18:11:38 +01:00
Andreas Fischer
94a15f85a6
[ticket/11469] Add example code to class documentation.
...
PHPBB3-11469
2013-03-27 18:11:31 +01:00
Joas Schilling
c629b2c7b3
[ticket/11476] Remove pass-by-reference from sql_mutli_insert
...
The method never writes to the array passed by reference. So it can be
passed by value instead to avoid certain problems.
PHPBB3-11476
2013-03-27 15:01:36 +01:00
Joas Schilling
bf6f2c5875
[ticket/11469] Return after sql_multi_insert when multi_insert is false
...
PHPBB3-11469
2013-03-27 14:00:47 +01:00
David King
6dddc22ec7
[ticket/11448] Use of $user_id parameter to mark a user's notifications read
...
Currently, the $user_id is a parameter but is not used. This patch fixes that.
PHPBB3-11448
2013-03-26 17:07:20 -04:00
Joas Schilling
d8a63047aa
[ticket/11474] Clarify comment with "global" and forum_id = 0
...
Forum ID 0 in permission checks, checks the global moderator permission.
PHPBB3-11405
PHPBB3-11474
2013-03-26 20:20:51 +01:00
Joas Schilling
1af89968dd
[ticket/11474] Check read permission before sending *_in_queue notifications
...
PHPBB3-11405
PHPBB3-11474
2013-03-26 20:20:26 +01:00
Joas Schilling
81cf02e057
[ticket/11405] Order users in bookmark, in order to pass postgres tests
...
PHPBB3-11405
2013-03-26 13:54:33 +01:00
Andreas Fischer
fc8bf3f3c7
[ticket/11469] Add comment about using sql_multi_insert when not buffering.
...
PHPBB3-11469
2013-03-25 17:01:44 +01:00
Joas Schilling
1259117d21
[ticket/11405] Sort $users array in order to prevent issues on postgres
...
PHPBB3-11405
2013-03-25 15:07:06 +01:00