mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-24 12:03:21 +01:00
Code Issues Releases Wiki Activity
16,279 Commits 17 Branches 190 Tags
Commit Graph

14726 Commits

Author SHA1 Message Date
Joas Schilling
d7787682df [ticket/11495] Throw exception when item that should be deleted does not exist 
PHPBB3-11495
 2013-04-30 22:19:35 +02:00
Joas Schilling
6a7378ecbd [ticket/11495] Some more doc changes 
PHPBB3-11495
 2013-04-30 18:39:22 +02:00
Joas Schilling
2f54a63b0f [ticket/11495] Fix more grammar issues in doc blocks 
PHPBB3-11495
 2013-04-30 18:24:54 +02:00
Joas Schilling
98e6207c35 [ticket/11495] Fix "as well" typo and remove brackets 
PHPBB3-11495
 2013-04-30 18:13:32 +02:00
Joas Schilling
5c4d69581a [ticket/11495] Do not reset item_parent if not required 
PHPBB3-11495
 2013-04-30 18:06:29 +02:00
Joas Schilling
f3f7be4cd1 [ticket/11495] Fix @return doc of get_sql_where() 
PHPBB3-11495
 2013-04-30 17:11:55 +02:00
Joas Schilling
6055a3cc7e [ticket/11495] Remove useless release_lock() method 
PHPBB3-11495
 2013-04-30 16:19:25 +02:00
Joas Schilling
78b0d3e723 [ticket/11495] Use $lock->owns_lock() instead of own property 
PHPBB3-11495
 2013-04-30 15:50:14 +02:00
Joas Schilling
714092ab4e [ticket/11495] Add owns_lock() method to lock classes 
PHPBB3-11495
 2013-04-30 15:48:29 +02:00
Joas Schilling
055ee41065 [ticket/11495] Remove useless cast 
PHPBB3-11495
 2013-04-30 15:16:41 +02:00
Joas Schilling
529e4c00fb [ticket/11495] Move lock code into two methods to allow easier handling 
This also allows to simply remove the lock handling by overwriting the two
methods acquire_lock() and release_lock().

PHPBB3-11495
 2013-04-30 15:15:50 +02:00
Joas Schilling
202484ebb4 [ticket/11495] Fix docs of add_item_to_nestedset() and take id as argument 
PHPBB3-11495
 2013-04-30 14:45:22 +02:00
Joas Schilling
863d0c7687 [ticket/11495] Fix some more comments and the package tag 
PHPBB3-11495
 2013-04-30 14:36:26 +02:00
Joas Schilling
87e8e60d3c [ticket/11495] Correctly distinguish between children and descendants 
PHPBB3-11495
 2013-04-30 14:12:45 +02:00
Joas Schilling
67f2edae17 [ticket/11495] Use descendants and ancestors instead of parents/children 
PHPBB3-11495
 2013-04-30 13:58:03 +02:00
Joas Schilling
4810c61fd7 [ticket/11495] Remove get_parent_data from interface and rename it 
The method is implementation specific and has no use, apart from cache, that is
not covered by get_path_data().

PHPBB3-11495
 2013-04-30 10:37:59 +02:00
Joas Schilling
8a4260703f [ticket/11495] Fix some docs and replace branch with other terms 
PHPBB3-11495
 2013-04-30 10:32:01 +02:00
Joas Schilling
2afa673023 [ticket/11495] Fix doc blocks once more 
PHPBB3-11495
 2013-04-26 08:42:44 +02:00
Joas Schilling
a9f02d1efa [ticket/11495] Make method names for add/remove more descriptive 
PHPBB3-11495
 2013-04-26 00:04:58 +02:00
Joas Schilling
baff4287e5 [ticket/11495] Fix comments and package docs 
PHPBB3-11495
 2013-04-25 22:39:24 +02:00
Joas Schilling
0def8b7d9c [ticket/11495] Use constructor arguments over properties in implementation 
PHPBB3-11495
 2013-04-25 18:09:21 +02:00
Joas Schilling
abfb7bc51f [ticket/11495] Remove add/remove from the interface 
PHPBB3-11495
 2013-04-25 17:24:18 +02:00
Joas Schilling
73d8735484 [ticket/11495] Remove fixing function from tree interface 
The fixing function is implementation dependent.

PHPBB3-11495
 2013-04-25 17:19:52 +02:00
Joas Schilling
b334a2ce0f [ticket/11495] Move classes to tree/ as they all implement a tree 
PHPBB3-11495
 2013-04-25 17:04:37 +02:00
Joas Schilling
c72f5bf487 [ticket/11495] Explain use of set_subset_zero on remove_subset() 
PHPBB3-11495
 2013-04-25 16:24:31 +02:00
Joas Schilling
804f139be0 [ticket/11495] Use default exceptions 
PHPBB3-11495
 2013-04-25 16:17:58 +02:00
Joas Schilling
9d7d962c0d [ticket/11495] Explain what "given item" means 
PHPBB3-11495
 2013-04-25 14:08:06 +02:00
Joas Schilling
fe97915fc9 [ticket/11495] Split get_branch_data into multiple methods 
PHPBB3-11495
 2013-04-25 14:05:41 +02:00
Joas Schilling
ab7054445f [ticket/11495] Rename set_parent to change_parent() 
PHPBB3-11495
 2013-04-25 13:48:19 +02:00
Joas Schilling
3efae6d8af [ticket/11495] Explain whether move_children prepends/appends/overwrittes 
PHPBB3-11495
 2013-04-25 13:44:52 +02:00
Joas Schilling
4bff28a0ee [ticket/11495] Rename fix function to regenerate_left_right_ids() 
This method regenerates the left/right ids for the nested set based on the
parent/child relations. This function executes three queries per item, so
it should only be called, when the set has one of the following problems:
- The set has a duplicated value inside the left/right id chain
- The set has a missing value inside the left/right id chain
- The set has items that do not have a left/right is set

When regenerating the items, the items are sorted by parent id and their
current left id, so the current child/parent relationships are kept and
running the function on a working set will not change any orders.

PHPBB3-11495
 2013-04-25 13:40:25 +02:00
Joas Schilling
61e72d3a10 [ticket/11495] Explain move() more 
An item is only moved up/down within the same parent. If the delta is larger
then the number of children, the item is moved to the top/bottom of the list
of children within this parent.

PHPBB3-11495
 2013-04-25 13:09:00 +02:00
Joas Schilling
e8b192fa32 [ticket/11495] Do not compare to null anymore (left over from item class) 
PHPBB3-11495
 2013-04-25 12:57:21 +02:00
Joas Schilling
87dc3b1e55 [ticket/11495] Use item ids instead of requiring all data 
The data is grabbed again in most cases anyway, so it just makes the system
easier to use.

PHPBB3-11495
 2013-04-19 21:07:42 +02:00
Joas Schilling
f66b5323a7 [ticket/11495] Cast some values to int 
PHPBB3-11495
 2013-04-19 19:09:22 +02:00
Joas Schilling
3d54a81ed9 [ticket/11495] Use item_id only as parameter for delete() and remove() 
The data is acquired again anyway

PHPBB3-11495
 2013-04-19 16:19:01 +02:00
Joas Schilling
d24ff2329f [ticket/11495] Use item_id only as parameter for get_branch_data() 
PHPBB3-11495
 2013-04-19 16:18:03 +02:00
Joas Schilling
f3ff8b36be [ticket/11495] Fix Spacing and lowercase on docs 
PHPBB3-11495
 2013-04-19 01:14:38 +02:00
Joas Schilling
5cb7342dd3 [ticket/11495] Remove acquire locks from forum implementation 
PHPBB3-11495
 2013-04-18 22:17:05 +02:00
Joas Schilling
b28180be1d [ticket/11495] Acquire locks for operations that manipulate the tree 
PHPBB3-11495
 2013-04-18 22:16:14 +02:00
Joas Schilling
153b29c6c9 [ticket/11495] Remove item class as its no longer required 
PHPBB3-11495
 2013-04-18 19:31:08 +02:00
Joas Schilling
a183fc1118 [ticket/11495] Manually specify the table columns 
PHPBB3-11495
 2013-04-18 00:54:26 +02:00
Joas Schilling
514bcb2fac [ticket/11495] Move nestedset default values to new method 
PHPBB3-11495
 2013-04-18 00:50:30 +02:00
Joas Schilling
e0393a3062 [ticket/11495] Fix column variable names 
PHPBB3-11495
 2013-04-18 00:34:09 +02:00
Joas Schilling
86937e03ec [ticket/11495] Remove item classes 
PHPBB3-11495
 2013-04-18 00:15:02 +02:00
Joas Schilling
8c3443ba99 [ticket/11495] Use array directly instead of phpbb_nestedset_item_interface 
PHPBB3-11495
 2013-04-18 00:13:19 +02:00
Joas Schilling
5c379db085 [ticket/11495] Fix description of get_sql_where 
PHPBB3-11495
 2013-04-17 22:56:12 +02:00
Joas Schilling
f831e3c66e [ticket/11495] Use unique properties for the column names 
PHPBB3-11495
 2013-04-17 22:52:17 +02:00
Joas Schilling
57a05e7cf5 [ticket/11495] Add forum implementation of nestedset 
PHPBB3-11495
 2013-04-16 23:09:21 +02:00
Joas Schilling
0d5efcc1d5 [ticket/11495] Add abstract implementation of the interface 
PHPBB3-11495
 2013-04-16 23:08:35 +02:00