mirror/php-phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 20:44:01 +01:00
Code Issues Releases Wiki Activity
16,559 Commits 17 Branches 190 Tags
Commit Graph

16559 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nathaniel Guse
07c972f5d7 [ticket/11413] Remove changes for ticket 11420 from this branch 
PHPBB3-11413
 2013-05-02 15:39:26 -05:00
hjpotter92
6d4a75b3cb [ticket/11517] Fix list numbering 
PHPBB3-11517
 2013-05-02 06:29:32 +05:30
Oleg Pudeyev
32f247ed60 [ticket/11435] Fit comment into 80 columns and link to php manual. 
PHPBB3-11435
 2013-05-01 17:21:49 -04:00
Nathaniel Guse
87b01fc854 [ticket/11415] Make migrator/ext.manager dependencies of the base ext class 
PHPBB3-11415
 2013-05-01 15:18:53 -05:00
Nathaniel Guse
60e3272839 [ticket/11415] Remove migrator dependency from extension manager 
PHPBB3-11415
 2013-05-01 14:09:08 -05:00
Nathaniel Guse
7ed21cc6f2 [ticket/11415] Move migrator to base extension class from ext.manager 
PHPBB3-11415
 2013-05-01 14:02:13 -05:00
Oleg Pudeyev
954edb3eb4 Merge PR #1372 branch 'EXreaction/ticket/11435' into develop 
# By Nathan Guse (2) and Nathaniel Guse (1)
# Via Nathaniel Guse
* EXreaction/ticket/11435:
  [ticket/11435] Mark extension spacing test as incomplete
  [ticket/11435] Create test to make sure template/event output is equal
  [ticket/11435] Fix comments in events test
 2013-05-01 14:16:41 -04:00
Nathaniel Guse
9db4e856db [ticket/11415] Move while loop from ext manager to acp_extensions.php 
Now enable_step works as it's supposed to (do one step at a time) and
less refreshes are required for the user.

PHPBB3-11415
 2013-05-01 13:00:43 -05:00
Nathaniel Guse
356bc00a29 [ticket/11435] Mark extension spacing test as incomplete 
This test fails until 11435 is fixed

Add newlines at EOF

PHPBB3-11435
 2013-04-30 23:21:50 -05:00
Nathaniel Guse
9004676810 [ticket/11413] Include mock class 
PHPBB3-11413
 2013-04-30 22:02:10 -05:00
Nathaniel Guse
2f2feaa4e8 [ticket/11413] Don't use the database for the convert test 
Different databases seem to work slightly differently here and are causing
errors

PHPBB3-11413
 2013-04-30 21:38:40 -05:00
Nathaniel Guse
f2e618a05d [ticket/11413] Test get_notification_type_id and _ids functions 
PHPBB3-11413
 2013-04-30 21:10:04 -05:00
Nathaniel Guse
81b2ad158c [ticket/11413] Use sql_insert_buffer 
PHPBB3-11413
 2013-04-30 21:01:46 -05:00
Nathaniel Guse
00ea297b61 [ticket/11413] Create test for notification conversion 
PHPBB3-11413
 2013-04-30 20:54:01 -05:00
Joas Schilling
d7787682df [ticket/11495] Throw exception when item that should be deleted does not exist 
PHPBB3-11495
 2013-04-30 22:19:35 +02:00
Dhruv
1d0c8a1fe8 [ticket/10325] use assert_response_success parts 
PHPBB3-10325
 2013-04-30 23:09:28 +05:30
Dhruv
a90a0b087c [ticket/10325] fix language in acp and ucp 
PHPBB3-10325
 2013-04-30 22:59:32 +05:30
Dhruv
a5b5e4b31d [ticket/10325] add assert_response_success in test 
PHPBB3-10325
 2013-04-30 22:29:20 +05:30
Joas Schilling
6a7378ecbd [ticket/11495] Some more doc changes 
PHPBB3-11495
 2013-04-30 18:39:22 +02:00
Joas Schilling
d1d59dc5cc [ticket/11495] Remove unneccessary values from tests 
PHPBB3-11495
 2013-04-30 18:33:28 +02:00
Joas Schilling
2f54a63b0f [ticket/11495] Fix more grammar issues in doc blocks 
PHPBB3-11495
 2013-04-30 18:24:54 +02:00
Joas Schilling
98e6207c35 [ticket/11495] Fix "as well" typo and remove brackets 
PHPBB3-11495
 2013-04-30 18:13:32 +02:00
Joas Schilling
fe02218a2d [ticket/11495] Remove forum_parents from tests where it is not required 
PHPBB3-11495
 2013-04-30 18:11:24 +02:00
Joas Schilling
5c4d69581a [ticket/11495] Do not reset item_parent if not required 
PHPBB3-11495
 2013-04-30 18:06:29 +02:00
Joas Schilling
39ff3ed15f [ticket/11495] Add proper testing of item_parent to tests 
PHPBB3-11495
 2013-04-30 18:05:44 +02:00
Joas Schilling
f3f7be4cd1 [ticket/11495] Fix @return doc of get_sql_where() 
PHPBB3-11495
 2013-04-30 17:11:55 +02:00
Joas Schilling
6055a3cc7e [ticket/11495] Remove useless release_lock() method 
PHPBB3-11495
 2013-04-30 16:19:25 +02:00
Joas Schilling
78b0d3e723 [ticket/11495] Use $lock->owns_lock() instead of own property 
PHPBB3-11495
 2013-04-30 15:50:14 +02:00
Joas Schilling
714092ab4e [ticket/11495] Add owns_lock() method to lock classes 
PHPBB3-11495
 2013-04-30 15:48:29 +02:00
Joas Schilling
055ee41065 [ticket/11495] Remove useless cast 
PHPBB3-11495
 2013-04-30 15:16:41 +02:00
Joas Schilling
529e4c00fb [ticket/11495] Move lock code into two methods to allow easier handling 
This also allows to simply remove the lock handling by overwriting the two
methods acquire_lock() and release_lock().

PHPBB3-11495
 2013-04-30 15:15:50 +02:00
Joas Schilling
202484ebb4 [ticket/11495] Fix docs of add_item_to_nestedset() and take id as argument 
PHPBB3-11495
 2013-04-30 14:45:22 +02:00
Joas Schilling
863d0c7687 [ticket/11495] Fix some more comments and the package tag 
PHPBB3-11495
 2013-04-30 14:36:26 +02:00
Joas Schilling
87e8e60d3c [ticket/11495] Correctly distinguish between children and descendants 
PHPBB3-11495
 2013-04-30 14:12:45 +02:00
Joas Schilling
67f2edae17 [ticket/11495] Use descendants and ancestors instead of parents/children 
PHPBB3-11495
 2013-04-30 13:58:03 +02:00
Joas Schilling
4810c61fd7 [ticket/11495] Remove get_parent_data from interface and rename it 
The method is implementation specific and has no use, apart from cache, that is
not covered by get_path_data().

PHPBB3-11495
 2013-04-30 10:37:59 +02:00
Joas Schilling
8a4260703f [ticket/11495] Fix some docs and replace branch with other terms 
PHPBB3-11495
 2013-04-30 10:32:01 +02:00
Vjacheslav Trushkin
947550df8f [ticket/10741] Docblock for phpbb.resizeTextArea 
Better description of phpBB.resizeTextArea with detailed
explanation of all optional parameters.

Removed unnecessary semicolons

PHPBB3-10741
 2013-04-30 11:27:43 +03:00
Nathaniel Guse
878df5f280 [ticket/11413] Fix test fixtures and tests 
PHPBB3-11413
 2013-04-29 23:10:38 -05:00
Nathaniel Guse
78c22248fa [ticket/11413] Fix some more tests 
PHPBB3-11413
 2013-04-29 22:41:08 -05:00
Nathaniel Guse
4cd0914f89 [ticket/11413] Fix notification tests 
Send types/methods the cache service, not the driver (not sure why the
driver was sent before)

PHPBB3-11413
 2013-04-29 22:16:46 -05:00
Nathaniel Guse
7bda5a016a [ticket/11413] Prevent recursive function calls 
PHPBB3-11413
 2013-04-29 21:42:14 -05:00
Nathaniel Guse
33287a7360 [ticket/11413] Undo editing the user_notifications table 
item_type is not equivalent to notification_type_name, it can be a generic
string (typically used to be able to subscribe to multiple notification
types while only subscribing to one item

PHPBB3-11413
 2013-04-29 21:22:07 -05:00
Nathaniel Guse
4c5e51e379 [ticket/11413] Rename columns in notification/manager.php 
PHPBB3-11413
 2013-04-28 23:40:48 -05:00
Nathaniel Guse
198b992dce [ticket/11413] Schema changes and migration file 
Notifications tables are dropped because phpBB currently does not have
any way to make the necessary changes to the DB schema (and no release
has yet been made with these changes).

This will fix the following bugs:
PHPBB3-11411
PHPBB3-11413
PHPBB3-11414
PHPBB3-11416
PHPBB3-11420

PHPBB3-11413
 2013-04-28 22:53:05 -05:00
marc1706
cb13add269 [ticket/11442] Use correct button class for ajaxified confirm_box 
In commit 001572f the HTML code for the ajaxified confirm_box was moved
from overall_footer.html to confirm_body.html. While copying, the CSS
class of the "Yes" button was changed from button1 to button2. Due to the
fact that the phpbb.confirm() method uses the class button1 to check if
"Yes" was clicked, this broke the ajaxified confirm box in the ACP. With
this small patch the confirm boxes in the ACP should work properly again.

PHPBB3-11442
 2013-04-28 22:54:48 +02:00
Oleg Pudeyev
c182ab0e7b Merge PR #1371 branch 'EXreaction/ticket/11236' into develop 
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11236:
  [ticket/11236] Change PRUNE_USERS_GROUP_EXPLAIN language
  [ticket/11236] Do not require group selection in prune users
  [ticket/11236] Correct HTML
 2013-04-26 22:35:13 -04:00
Oleg Pudeyev
efd9e331bc Merge PR #1370 branch 'EXreaction/ticket/11237' into develop 
# By Nathaniel Guse
# Via Nathaniel Guse
* EXreaction/ticket/11237:
  [ticket/11237] Fix PHP error in acp_prune.php
 2013-04-26 22:34:55 -04:00
Joas Schilling
2afa673023 [ticket/11495] Fix doc blocks once more 
PHPBB3-11495
 2013-04-26 08:42:44 +02:00
Joas Schilling
a9f02d1efa [ticket/11495] Make method names for add/remove more descriptive 
PHPBB3-11495
 2013-04-26 00:04:58 +02:00