1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-07 06:55:25 +02:00

32 Commits

Author SHA1 Message Date
rxu
3e37770b61
Merge branch 'ticket/17142' into ticket/17142-master 2023-06-08 10:20:24 +07:00
rxu
7adee3c50d
[ticket/17142] Fix DBMS+cache related PHP warnings while installing
PHPBB3-17142
2023-06-08 00:59:32 +07:00
Marc Alexander
80e55b2ec8
Merge branch '3.3.x' 2023-04-11 22:22:26 +02:00
Marc Alexander
b5c316c9c3
[ticket/8071] Make nextid alias of sql_last_inserted_id and add deprecation
PHPBB3-8071
2023-01-31 17:17:42 +01:00
Marc Alexander
948023078b
[ticket/16955] Clean up code in db classes
PHPBB3-16955
2022-12-28 08:37:20 +01:00
lionel-rowe
9fb98201f2 [ticket/8071] Add sql_last_inserted_id alias for sql_nextid
Fixes [DBAL function sql_nextid - name is
misleading](https://tracker.phpbb.com/browse/PHPBB3-8071).

Per the tracker issue:
> This function gets the ID of the last inserted row, not the ID of the next row
to be inserted (which is difficult due to different autoincrement steps and also
lends itself nicely to race conditions).

@iwisdom replied that the naming is consistent with how PHP itself names this
functionality, but the link they posted doesn't support that (I guess this is
referring to a much older version of PHP? The comment is from 2009).

PHPBB3-8071
2022-04-26 15:03:42 +01:00
rxu
3d5639a844
[ticket/16749] Explicitly set default MySQLi error mode
PHPBB3-16749
2021-04-04 17:11:59 +07:00
rxu
0bc9d87891
[ticket/16538] Add identifiers quoting
If reserved word is used as identifier, it must be quoted.
If alias is used elsewhere in SQL statement, it must be quoted.

PHPBB3-16535
PHPBB3-16538
2020-08-14 04:51:11 +07:00
Marc Alexander
a7c02304a5
Merge branch '3.2.x' into 3.3.x 2019-09-20 22:23:06 +02:00
Marc Alexander
4555817a8b
[ticket/security/247] Disable loading of local files on client side
SECURITY-247
2019-08-11 21:31:59 +02:00
Jakub Senko
139eb17bb7
[ticket/12624] Add debug.load_time parameter
PHPBB3-12624
2019-05-09 18:40:15 +02:00
Jakub Senko
b4d4336ef4
[ticket/12627] Add debug.sql_explain parameter
PHPBB3-12627
2019-05-09 18:29:22 +02:00
luzpaz
a9a28859d4
[ticket/15424] Multiple typo fixes in docs & comments
Fixed typos in some docs, guidelines, some non-user-facing files.

PHPBB3-15424
2019-05-08 22:20:56 +02:00
Andreas Fischer
978b96cbf5 Merge branch '3.1.x'
* 3.1.x:
  [ticket/13570] Remove unnecessary ternary condition from mysqli driver
2015-02-17 22:24:15 +01:00
Jakub Senko
f23d2ec42f [ticket/13570] Remove unnecessary ternary condition from mysqli driver
PHPBB3-13570
2015-02-16 20:25:11 +01:00
Joas Schilling
58d1dcc7f2 Merge pull request from Nicofuma/ticket/12387
[ticket/12387] Cleanup *_free_result call and remove @ on that call

* Nicofuma/ticket/12387:
  [ticket/12387] Fix a call to sql_freeresult in full_text_native
  [ticket/12387] Fix \phpbb\db\driver\mysqli::sql_freeresult
  [ticket/12387] Use the hash as query_id for caching
  [ticket/12387] Remove unnecessary checks
  [ticket/12387] mssql_query return true if a select query returns 0 row
  [ticket/12387] Cleanup *_free_result call and remove @ on that call
2014-08-07 12:09:01 +02:00
Marc Alexander
40a65abc3a [ticket/12764] Properly handle errors upon connecting to MySQLi database
As the db_connect_id gets set up by mysql_init(), the db_connect_id will be an
object with empty settings instead of just empty. Even if mysql_real_connect()
encounters an error upon connecting, the db_connect_id is still set. This
will result in trying to just access the database which obviously does
nothing.
By setting db_connect_id to an empty string, the script will not try to query
th database and properly handle any errors that occur upon connecting.

PHPBB3-12764
2014-06-26 14:33:08 +02:00
Tristan Darricau
bc3659a186 [ticket/12387] Fix \phpbb\db\driver\mysqli::sql_freeresult
PHPBB3-12387
2014-06-22 23:36:57 +02:00
Joas Schilling
de04304e94 Merge pull request from rxu/ticket/12704
[ticket/12704] Improve the load time information in the footer when enabled

* rxu/ticket/12704:
  [ticket/12704] Improve the load time information in the footer when enabled
2014-06-22 23:09:21 +02:00
Tristan Darricau
2276c1c0f2 [ticket/12387] Cleanup *_free_result call and remove @ on that call
PHPBB3-12387
2014-06-22 18:16:21 +02:00
Tristan Darricau
89a7a55190 [ticket/12756] Fix mysqli_fetch_assoc on hhvm
PHPBB3-12756
2014-06-21 16:50:17 +02:00
rxu
f850d5fa90 [ticket/12704] Improve the load time information in the footer when enabled
PR  has added new constant to display load time information without
debug mode is being on (https://tracker.phpbb.com/browse/PHPBB3-12687).
This patch expands the total load time info with SQL/PHP load times,
while hiding the additional info with <abbr> element.

PHPBB3-12704
2014-06-20 20:57:32 +08:00
Yuriy Rusko
1d61bcedfd Merge remote-tracking branch 'upstream/develop-ascraeus' into ticket/12594
Conflicts:
	phpBB/docs/hook_system.html
2014-05-27 21:55:40 +02:00
Yuriy Rusko
a759704b39 [ticket/12594] Remove @package tags and update file headers
PHPBB3-12594
2014-05-27 20:51:13 +02:00
Joas Schilling
fcdf1101cb [ticket/12570] Keep MySQLi procedural
PHPBB3-12570
2014-05-26 21:43:40 +02:00
Joas Schilling
b92eac71e4 [ticket/12570] Fix MySQLi affectedrows by specifying MYSQLI_CLIENT_FOUND_ROWS
PHPBB3-12570
2014-05-26 21:43:38 +02:00
Joas Schilling
1f28451d58 [ticket/12282] Use {@inheritDoc} for inherited methods
PHPBB3-12282
2014-04-01 19:17:40 +02:00
Andreas Fischer
7aa8f6461f [task/code-sniffer] Remove the IN_PHPBB check side-effect from class files.
PHPBB3-11980
2013-10-30 13:05:28 +01:00
Andreas Fischer
02e9f6e284 [task/code-sniffer] Fix argument list spacing.
PHPBB3-11980
2013-10-29 23:38:05 +01:00
Marc Alexander
7f58a4572e [ticket/11981] Fix code sniffer complaints
PHPBB3-11981
2013-10-28 23:05:46 +01:00
Nils Adermann
b95fdacdd3 [ticket/11700] Move all recent code to namespaces
PHPBB3-11700
2013-09-16 00:25:27 +02:00
Nils Adermann
7030578bbe [ticket/11698] Moving all autoloadable files to phpbb/
PHPBB3-11698
2013-07-14 01:32:34 -04:00