Cullen Walsh
593e193bdc
[ticket/9715] Better email regex
...
Using email regex created by James Watts and Francisco Jose Martin Moreno.
This passes many more tests for RFC valid emails.
PHPBB3-9715
2010-07-11 16:22:26 -07:00
Cullen Walsh
a0b9f7806a
[ticket/9715] Extend email unit tests
...
Adding more email tests for a wider range of valid email formats.
PHPBB3-9715
2010-07-11 16:20:27 -07:00
Andreas Fischer
6724b79967
Merge branch 'ticket/nickvergessen/9531' into develop-olympus
...
* ticket/nickvergessen/9531:
[ticket/9531] BBCode-less quotes fallback-option is missing "Author wrote:"
2010-07-12 00:04:33 +02:00
Joas Schilling
5d9948e39c
[ticket/9531] BBCode-less quotes fallback-option is missing "Author wrote:"
...
When quoting from the topic-review the statement "Author wrote:" is missing. The fix for this was not complete: Now it's backwards compatibile and uses the LA_ for the language variables.
PHPBB3-9531
2010-07-11 10:18:45 +02:00
Andreas Fischer
062d8fda04
Merge branch 'ticket/adamreyher/9012' into develop-olympus
...
* ticket/adamreyher/9012:
[ticket/9012] Adjust shadow topic title to the title at the time it was moved.
2010-07-11 02:53:06 +02:00
Adam Reyher
b939ce5940
[ticket/9012] Adjust shadow topic title to the title at the time it was moved.
...
Moved topics which have their title changed in the new forum will now show the
old title in the original viewforum instead of the new title.
PHPBB3-9012
2010-07-11 02:44:07 +02:00
Andreas Fischer
2d9aa45aef
Merge branch 'ticket/jellydoughnut/9637' into develop-olympus
...
* ticket/jellydoughnut/9637:
[ticket/9637] Do not cache SQL server version in all cases
2010-07-11 01:44:59 +02:00
Josh Woody
9c61455d26
[ticket/9637] Do not cache SQL server version in all cases
...
Because the existing cache is global, there is no way to differentiate between
each of two databases which may be two different DBAL objects pointing to
servers with wildly different versions of an RDBMS. phpBB only has this
situation in the UCF, thus only one file changed outside the DBAL. I have
added a second optional parameter, $use_cache to each of the implementations
of dbal::sql_server_info()
PHPBB3-9637
2010-07-11 01:41:38 +02:00
Andreas Fischer
08a34ebe94
Merge branch 'ticket/jellydoughnut/9629' into develop-olympus
...
* ticket/jellydoughnut/9629:
[ticket/9629] Allow style.php to retrieve its session ID from cookies
2010-07-11 01:41:22 +02:00
Josh Woody
c40b2c7601
[ticket/9629] Allow style.php to retrieve its session ID from cookies
...
style.php takes a session ID to ensure it gets the right language for a user,
but that session ID is always passed in GET. This allows change allows the SID
to be read from the cookie, and theoretically makes it friendlier for caching
engines like Varnish.
PHPBB3-9629
2010-07-11 01:35:01 +02:00
Andreas Fischer
c0183cabd0
[ticket/9534] Update function documentation for user_ipwhois().
...
PHPBB3-9534
2010-07-11 01:19:42 +02:00
Andreas Fischer
ed44235d26
[ticket/9534] Adding support for IPv6 addresses in user_ipwhois().
...
whois.arin.net does currently not refer to other servers (using ReferralServer)
when queried for an IPv6 address. whois.sixxs.net however works in this case.
This also adds '.' to the hostname to make sure we're querying the dns root.
PHPBB3-9534
2010-07-11 01:19:27 +02:00
Andreas Fischer
e46745ed34
Merge branch 'ticket/nickvergessen/9678' into develop-olympus
...
* ticket/nickvergessen/9678:
[ticket/9678] Flash attachments are not displayed in subsilver2.
2010-07-10 21:22:33 +02:00
Andreas Fischer
e629929958
Merge branch 'ticket/nickvergessen/9677' into develop-olympus
...
* ticket/nickvergessen/9677:
[ticket/9677] Subsilver2 is missing the bbcode-helpline for inline-attachments.
2010-07-10 21:22:31 +02:00
Andreas Fischer
0c2512bea2
Merge branch 'ticket/jellydoughnut/9650' into develop-olympus
...
* ticket/jellydoughnut/9650:
[ticket/9650] Do not allow banning the anonymous user by username
2010-07-10 21:22:16 +02:00
Nils Adermann
bbc3105466
[ticket/9701] Prevent notices from being hidden by template tests
...
The template tests disable NOTICEs for the duration of template execution since
the current version of the template engine does not generate sufficiently clean
code. The error level is reset aftwards, however that part is skipped when
trigger_error is called which is converted into a regular exception by PHPUnit
and passed down until caught. Such exceptions are now caught to reset the error
level, and then the exception is rethrown.
This uncovered another issue in the template tests which only passed because
NOTICEs were unintentionally disabled at this point. assign_display is also
required to operate without NOTICEs. The respective code has been added around
its callee as well. However no handling of exceptions takes place there. If
another test checking for errors in that function is ever added similar catch
logic will have to be added there.
PHPBB3-9701
2010-07-08 22:46:28 +02:00
Joas Schilling
df99bdbd53
[ticket/9678] Flash attachments are not displayed in subsilver2.
...
PHPBB3-9678
2010-07-08 21:22:54 +02:00
Joas Schilling
fc89d5d7db
[ticket/9677] Subsilver2 is missing the bbcode-helpline for inline-attachments.
...
PHPBB3-9677
2010-07-08 21:13:17 +02:00
Andreas Fischer
c6c4d01fe9
[ticket/9714] Use correct variable name in email regular expression tests.
...
PHPBB3-9714
2010-07-08 20:26:50 +02:00
Josh Woody
ae967d16f1
[ticket/9650] Do not allow banning the anonymous user by username
...
Banning anonymous can result in bad things, like not being able to log in. However, it was possible until now.
PHPBB3-9650
2010-07-08 13:24:45 -05:00
Andreas Fischer
6da582e8be
Merge branch 'ticket/p/9570' into develop-olympus
...
* ticket/p/9570:
[ticket/9570] Changed "system" to "guest" timezone in ACP, added explanation.
2010-07-08 20:02:34 +02:00
Andreas Fischer
29716cd5d5
Merge branch 'ticket/p/9589' into develop-olympus
...
* ticket/p/9589:
[ticket/9589] Added sample nginx configuration file for phpbb.
2010-07-08 20:01:22 +02:00
Andreas Fischer
7a0b554724
Merge branch 'ticket/p/9593' into develop-olympus
...
* ticket/p/9593:
[ticket/9593] A readme file for unit tests and running unit tests.
2010-07-08 20:00:26 +02:00
Andreas Fischer
c3db21bfa2
Merge branch 'ticket/bantu/9451' into develop-olympus
...
* ticket/bantu/9451:
[ticket/9451] Add optional $can_upload parameter to avatar_process_user().
2010-07-08 19:52:29 +02:00
Andreas Fischer
f92c96d424
Merge branch 'ticket/jellydoughnut/9690' into develop-olympus
...
* ticket/jellydoughnut/9690:
[ticket/9690] Add forthcoming Bing Bot to list of recognized bots
2010-07-08 19:49:22 +02:00
Andreas Fischer
c86f9eb25a
Merge branch 'ticket/evil3/9704' into develop-olympus
...
* ticket/evil3/9704:
[ticket/9704] Fix minor typo in coding guidelines.
2010-07-08 19:44:39 +02:00
Igor Wiedler
58cb46d344
[ticket/9704] Fix minor typo in coding guidelines.
...
PHPBB3-9704
2010-07-08 09:15:03 +02:00
Andreas Fischer
c79df9700d
Merge branch 'ticket/nickvergessen/9578' into develop-olympus
...
* ticket/nickvergessen/9578:
[ticket/9578] ACP Posting tab is missing "Post settings" module.
2010-07-08 02:20:25 +02:00
Andreas Fischer
c592cab989
Merge branch 'ticket/nickvergessen/9628' into develop-olympus
...
* ticket/nickvergessen/9628:
[ticket/9628] _add_module 'after'-parameter does not work correctly.
2010-07-08 02:20:05 +02:00
Andreas Fischer
f22f89888d
Merge branch 'ticket/jellydoughnut/9695' into develop-olympus
...
* ticket/jellydoughnut/9695:
[ticket/9695] Correct the improper display of user input in mcp_ban.php
2010-07-08 01:41:16 +02:00
Andreas Fischer
c091a04a55
Merge branch 'ticket/nickvergessen/9697' into develop-olympus
...
* ticket/nickvergessen/9697:
[ticket/9697] Backlink broken when the select parent forum does not exist.
2010-07-08 01:29:47 +02:00
Andreas Fischer
e3fe4d7b56
Merge branch 'ticket/jellydoughnut/9703' into develop-olympus
...
* ticket/jellydoughnut/9703:
[ticket/9703] Correct database leak where deleting user did not rm some PM data
2010-07-08 01:24:18 +02:00
Andreas Fischer
ef753d046d
Merge branch 'ticket/cs278/9712' into develop-olympus
...
* ticket/cs278/9712:
[ticket/9712] Future dates can be formatted as 'less than one minute ago'
2010-07-08 01:21:55 +02:00
Chris Smith
9764a32138
[ticket/9712] Future dates can be formatted as 'less than one minute ago'
...
PHPBB3-9712
2010-07-07 23:04:46 +01:00
Josh Woody
d00f2ec183
[ticket/9690] Add forthcoming Bing Bot to list of recognized bots
...
Microsoft will rename MSN Bot to Bing Bot later this year, and change its user agent. This updates phpBB to be aware of Bing Bot
PHPBB3-9690
2010-07-07 15:51:31 -05:00
Thatbitextra
e130a6bad9
[ticket/9451] Add optional $can_upload parameter to avatar_process_user().
...
Avoid unnecessary overhead in avatar_process_user() by optionally passing in
the value of $can_upload.
PHPBB3-9451
2010-07-07 16:45:00 +02:00
Oleg Pudeyev
030f9c03c6
[ticket/9593] A readme file for unit tests and running unit tests.
...
Added a readme file explaining prerequisites for unit tests, and how to run
unit tests.
PHPBB3-9593
2010-07-07 16:10:13 +02:00
Andreas Fischer
4ac5d5e352
Merge branch 'ticket/naderman/9659' into develop-olympus
...
* ticket/naderman/9659:
[ticket/9659] Signature options in set_user_options
2010-07-07 12:09:04 +02:00
Richard Foote
b64f456c40
[ticket/9659] Signature options in set_user_options
...
The phpBB3 defaults are being used.
PHPBB3-9659
2010-07-06 14:43:50 +02:00
Oleg Pudeyev
097854ca85
[ticket/9570] Changed "system" to "guest" timezone in ACP, added explanation.
...
PHPBB3-9570
2010-07-06 13:14:04 +02:00
Josh Woody
24cc3fd0f9
[ticket/9703] Correct database leak where deleting user did not rm some PM data
...
Users' PM rules and PM folders were being left intact when deleting them.
PHPBB3-9703
2010-07-03 21:21:22 -05:00
Joas Schilling
0db657381b
[ticket/9697] Backlink broken when the select parent forum does not exist.
...
PHPBB3-9697
2010-07-02 12:28:06 +02:00
Josh Woody
0e93d8386b
[ticket/9695] Correct the improper display of user input in mcp_ban.php
...
Correct the improper display of "ban_reason" and "ban_give_reason" in mcp_ban.php
PHPBB3-9695
2010-07-01 17:48:32 -05:00
Andreas Fischer
881c74688b
[ticket/9694] Call error_reporting() in download/file.php when in avatar mode.
...
PHPBB3-9694
2010-07-01 23:30:48 +02:00
Andreas Fischer
32882fd798
[ticket/9694] Make sure string offset 0 exists to avoid E_NOTICE message.
...
PHPBB3-9694
2010-07-01 23:29:25 +02:00
Igor Wiedler
38cc9ce72f
[task/set-permissions] shell script to set file permissions
...
PHPBB3-9689
2010-06-28 18:12:56 +02:00
Andreas Fischer
b7ae0fe4e9
Merge branch 'ticket/bantu/9655' into develop-olympus
...
* ticket/bantu/9655:
[ticket/9655] Pass E_USER_WARNING, so it doesn't look like a successful action.
2010-06-20 22:46:23 +02:00
Andreas Fischer
352c69f7b2
Merge branch 'ticket/bantu/9665' into develop-olympus
...
* ticket/bantu/9665:
[ticket/9665] Allow preview of signature when it is the string "0".
2010-06-20 22:46:14 +02:00
Andreas Fischer
d537dc60ce
Merge branch 'ticket/bantu/9656' into develop-olympus
...
* ticket/bantu/9656:
[ticket/9656] Remove @ from phpinfo() to get correct error_reporting value.
2010-06-20 22:45:55 +02:00
Andreas Fischer
b91950d413
Merge branch 'ticket/bantu/9653' into develop-olympus
...
* ticket/bantu/9653:
[ticket/9653] Valid XHTML with code BBCode in subsilver2 viewtopic signatures
2010-06-20 22:45:47 +02:00