[ticket/12873] Test the correct identifier in \phpbb\db\tools
* Nicofuma/ticket/12873:
[ticket/12873] Add migration to rename the index
[ticket/12873] Don not touch the existing migrations
[ticket/12873] Test the good identifier in \phpbb\db\tools
[ticket/12882] Update search_type when it's not prefixed by phpbb_search
* Nicofuma/ticket/12882:
[ticket/12882] Use a new migration
[ticket/12882] Update search_type when it's not prefixed by phpbb_search
We need to rename the index key because with the default prefix (phpbb_)
this key has a length of 31. And because we don't accept the keys longer
than 30 characters we should ensure that by default no key is longer than
30 characters.
PHPBB3-12873
Using profilefield_base_migration.php to create a custom profile
field with SQlite3 DBMS returns warning:
[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/db/driver/sqlite3.php
on line 218: SQLite3Result::fetchArray(): Unable to execute statement:
constraint failed
This is due passing filed_id and lang_id to the DB driver in
unspecified format. As they are always int we should cast them
in int to prevent the error message appearance.
PHPBB3-12846
[ticket/12786] Extend profilefield_base_migration.php class
* lucifer4o/ticket/12786:
[ticket/12786] Correcting some tabs
[ticket/12786] Array_merge instead copy array parts
[ticket/12786] Some changes of the comments.
[ticket/12786] Dixing a typo
[ticket/12786] Some minor fixes of comments and function naming
[ticket/12786] Add clean_cpf_db_entries
[ticket/12786] White spaces found
[ticket/12786] Add create_language_entries
[ticket/12786] Add get_custom_field_id
[ticket/12786] Extend profilefield_base_migration.php class
If extensions authors will use profilefield_base_migration.php
class as base class for creation of CPFs, the class need to be
extended a bit.
At the moment there are two issues with it:
It does not create entries for PROFILE_FIELDS_LANG_TABLE
(as it can't know what fields to create).
The migration is not "cleaning" the DBMS after purging
the extension and leaves everything except the CPF column.
Adding profilefield_language_data
PHPBB3-12786
[ticket/12764] Properly handle errors upon connecting to MySQLi database
* marc1706/ticket/12764:
[ticket/12764] Properly handle errors upon connecting to MySQLi database
As the db_connect_id gets set up by mysql_init(), the db_connect_id will be an
object with empty settings instead of just empty. Even if mysql_real_connect()
encounters an error upon connecting, the db_connect_id is still set. This
will result in trying to just access the database which obviously does
nothing.
By setting db_connect_id to an empty string, the script will not try to query
th database and properly handle any errors that occur upon connecting.
PHPBB3-12764
The base migration class should create lang entry for the new CPF
but it is supposed to strip it of phpbb_ prefix. As extensions
CPFs do not use phpbb_ prefix it will not create a lang entry.
This is as simple solution as it can be done.
PHPBB3-12771
[ticket/12747] Drop support for Firebird
* nickvergessen/ticket/12747:
[ticket/12747] Remove some methods which are not used anymore
[ticket/12747] Drop support for Firebird
Conflicts:
phpBB/phpbb/db/driver/firebird.php
