[ticket/12782] Use an interface for the phpbb event_dispatcher
* Nicofuma/ticket/12782:
[ticket/12782] Add doc block
[ticket/12782] Use an interface for the phpbb event_dispatcher
[ticket/12334] Add PROFILE_FIELD_VALUE_RAW template var
* Dragooon/ticket/12334:
[ticket/12334] Remove profile fields test group
[ticket/12334] Add additional test for type_string
[ticket/12334] Add string test for type_int
[ticket/12334] Improve type_dropdown's test description
[ticket/12334] Group profile fields test
[ticket/12334] Change get_profile_value_raw_data to profile_value_raw_data
[ticket/12334] Add get_profile_value_raw unit test for type_bool
[ticket/12334] Add get_profile_value_raw unit test for type_date
[ticket/12334] Add get_profile_value_raw unit tests for type_dropdown
[ticket/12334] Add get_profile_value_raw unit test for type_string
[ticket/12334] Add get_profile_value_raw unit test for type_url
[ticket/12334] Add get_profile_value_raw unit tests for type_int
[ticket/12334] Removed tests
[ticket/12334] Dropdowns cannot be tested this way
[ticket/12334] Added test get_profile_value_raw
[ticket/12334] Changed from valueid to value_raw
[ticket/12334] Implemented get_profile_valueid method
[ticket/12334] Added field_novalue fall-back as requested
[ticket/12334] Add PROFILE_FIELD_VALUEID template var
Previously these would be fetched one field at one time, causing a large
number of queries in case there were large number of custom profile fields
and/or unique number of users in areas such as viewing topics. Resolve this
by caching them at once when generating data for displaying them in templates.
PHPBB3-12759
Google+ has a "+" before a custom URL but doesn't for those which are using
their integer ID. To cover that we need to have an extra profile field
PHPBB3-12730
[ticket/12732] Add Skype custom profile field
* Dragooon/ticket/12732:
[ticket/12732] Update schema.json for Skype
[ticket/12732] Add functional test for Skype profile field
[ticket/12732] Values shouldn't be escaped for schema_data.sql
[ticket/12732] Set field_active to 1 for Skype's field
[ticket/12732] Add unit tests for ALPHA_PUNCTUATION
[ticket/12732] Missing comma after validation definition
[ticket/12732] Improve ALPHA_PUNCTUATION description
[ticket/12732] Use user info instead of chat as default Skype action
[ticket/12732] Add Skype custom profile field
Conflicts:
phpBB/install/schemas/schema.json
phpBB/install/schemas/schema_data.sql
phpBB/language/en/memberlist.php
tests/functional/ucp_profile_test.php
tests/profilefields/type_string_test.php
* github-nickvergessen/ticket/12331:
[ticket/12331] Add functional test for saving custom profile fields
[ticket/12331] Fix SQL error when inserting a new entry to profile field data
There was a "Field 'pf_phpbb_interests' doesn't have a default value" error,
because we didn't specify values for the disabled fields.
We can not disable the sql_return_on_error() thou, because it otherwise we run
into "Duplicate entry '2' for key 'PRIMARY'" errors when the user submits the
form again but didn't change any values.
PHPBB3-12331
Currently when an user adds a HTML entity to a custom profile field, the length
gets incremented by 4 since the code reads > instead of <. However, the
length is presentational and not DB storage so it should be treated as a
single character even if it takes four lengths in the DB by being stored as
a HTML entity.
Work around this by decoding html entities before counting. Also, added unit
tests for string field type
PHPBB3-9040
