1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-02 20:45:29 +02:00

7634 Commits

Author SHA1 Message Date
Joas Schilling
6333451455 [ticket/11481] Remove globals and use dependency injection instead
PHPBB3-11481
2013-06-06 20:32:47 +02:00
Joas Schilling
3efe0eb246 [ticket/11481] Use container for all classes and inject dependencies
PHPBB3-11481
2013-06-06 20:04:23 +02:00
Joas Schilling
b5f1484744 [ticket/11481] Move functions from feed into helper class
PHPBB3-11481
2013-06-06 19:35:36 +02:00
Joas Schilling
b25af0fa68 [ticket/11481] Move active topics feed to own file
PHPBB3-11481
2013-06-06 17:06:52 +02:00
Joas Schilling
65a527f877 [ticket/11481] Move topics feed to own file
PHPBB3-11481
2013-06-06 17:06:24 +02:00
Joas Schilling
3e30c731b5 [ticket/11481] Move news feed to own file
PHPBB3-11481
2013-06-06 17:05:59 +02:00
Joas Schilling
caf7c45fb4 [ticket/11481] Move forums feed to own file
PHPBB3-11481
2013-06-06 17:05:41 +02:00
Joas Schilling
ffdb5c9388 [ticket/11481] Move topic feed to own file
PHPBB3-11481
2013-06-06 17:05:22 +02:00
Joas Schilling
d94ec8faab [ticket/11481] Move forum feed to own file
PHPBB3-11481
2013-06-06 17:04:57 +02:00
Joas Schilling
a995deb189 [ticket/11481] Move overall feed to own file
PHPBB3-11481
2013-06-06 17:04:37 +02:00
Joas Schilling
f592072b4b [ticket/11481] Move feed topic base to own file
PHPBB3-11481
2013-06-06 17:04:05 +02:00
Joas Schilling
06a51b09f1 [ticket/11481] Move feed post base to own file
PHPBB3-11481
2013-06-06 17:03:40 +02:00
Joas Schilling
2916ddc38c [ticket/11481] Move feed base to own file
PHPBB3-11481
2013-06-06 17:03:10 +02:00
Joas Schilling
a839896ddd [ticket/11481] Move feed factory to own file
PHPBB3-11481
2013-06-06 17:02:45 +02:00
Dhruv
3931f7f3b9 Merge branch 'develop-olympus' into develop
# By Andreas Fischer
# Via Andreas Fischer (1) and Dhruv (1)
* develop-olympus:
  [ticket/11583] Use a new lang key instead of giving the old one a new meaning.
  [ticket/11583] Allow FULLTEXT indexes on InnoDB when on MySQL 5.6.4 or higher.

Conflicts:
	phpBB/includes/search/fulltext_mysql.php
	phpBB/language/en/acp/search.php
2013-06-05 01:55:49 +05:30
Dhruv
ad8386a64a Merge remote-tracking branch 'bantu/ticket/11583' into develop-olympus
# By Andreas Fischer
# Via Andreas Fischer
* bantu/ticket/11583:
  [ticket/11583] Use a new lang key instead of giving the old one a new meaning.
  [ticket/11583] Allow FULLTEXT indexes on InnoDB when on MySQL 5.6.4 or higher.
2013-06-05 01:41:26 +05:30
Dhruv
e6d521df29 Merge branch 'ticket/10820' into ticket/10820-develop
* ticket/10820:
  [ticket/10820] Inject IE version in function

Conflicts:
	phpBB/download/file.php
2013-06-05 00:27:32 +05:30
Marc Alexander
27bcf25c3b [ticket/11587] Pass legend and teampage settings to group_create()
Without passing those values, the group is removed from the teampage and
the legend while submitting the edit form on the ucp groups manage page.

PHPBB3-11587
2013-06-04 14:25:37 +02:00
Andreas Fischer
5fa25880e2 [ticket/11586] Move $filedata['thumbnail'] to where it might be returned.
PHPBB3-11586
2013-06-03 16:24:12 +02:00
Andreas Fischer
50e3173e8c [ticket/11586] Combine $filedata['post_attach'] assign into a single statement.
PHPBB3-11586
2013-06-03 16:24:12 +02:00
Andreas Fischer
11c80c0402 [ticket/11586] Use a variable for $cat_id == ATTACHMENT_CATEGORY_IMAGE.
PHPBB3-11586
2013-06-03 16:14:22 +02:00
Andreas Fischer
cb54f56c3d [ticket/11586] Combine administrator/moderator checks together.
PHPBB3-11586
2013-06-03 16:07:19 +02:00
Andreas Fischer
99d089ce9f Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11145] Wrong error thrown when uploading a bigger image.
2013-06-03 15:58:32 +02:00
Andreas Fischer
a3d1593804 Merge remote-tracking branch 'erangamapa/ticket/11145' into develop-olympus
* erangamapa/ticket/11145:
  [ticket/11145] Wrong error thrown when uploading a bigger image.
2013-06-03 15:58:21 +02:00
Andreas Fischer
a20a0e06c2 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/10840] Add check_form_key to acp_groups.php
2013-06-03 15:39:07 +02:00
Andreas Fischer
d925c8d0da [ticket/11583] Use a new lang key instead of giving the old one a new meaning.
PHPBB3-11583
2013-06-03 15:16:57 +02:00
Joas Schilling
6206d4aa4e [ticket/8319] Add explanation for RELATIVE_URL and update LOCAL_URL
The explanation now states that links are prefixed with the board URL.

PHPBB3-8319
2013-06-03 12:37:58 +02:00
Joas Schilling
c0e0c13cf1 [ticket/8319] Add new token RELATIVE_URL to allow foreign relative URL parts
PHPBB3-8319
2013-06-03 12:37:54 +02:00
Joas Schilling
81140ec887 [ticket/8319] Prepend Board URL to LOCAL_URL links to prevent abuse
The description says:
"The URL must be relative to the topic page and cannot contain a server name
or protocol."
We now enforce this and will add a new token with the current behaviour back.

PHPBB3-8319
2013-06-03 12:37:54 +02:00
Joas Schilling
0eae9eb75d [ticket/10840] Add check_form_key to acp_groups.php
PHPBB3-10840
2013-06-03 10:54:16 +02:00
Andreas Fischer
d0e45e17dd [ticket/11583] Allow FULLTEXT indexes on InnoDB when on MySQL 5.6.4 or higher.
PHPBB3-11583
2013-06-01 04:09:33 +02:00
Joas Schilling
69e1b402df Merge remote-tracking branch 'Elsensee/ticket/11409' into develop
* Elsensee/ticket/11409:
  [ticket/11409] Add success message after updating group position settings
2013-05-31 18:08:26 +02:00
Joas Schilling
cae1f8bc86 Merge remote-tracking branch 'EXreaction/ticket/11387' into develop
* EXreaction/ticket/11387:
  [ticket/11387] Log module added only after it has been added
2013-05-31 17:21:00 +02:00
Oliver Schramm
faf804c70f [ticket/11409] Add success message after updating group position settings
PHPBB3-11409
2013-05-31 17:16:15 +02:00
Marc Alexander
6d5da402ec [ticket/11579] Remove unnecessary globals from validate_password()
The globals $db and $user are not used in that function.

PHPBB3-11579
2013-05-30 16:09:06 +02:00
Joas Schilling
a3c5809f94 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11578] Add missing underscore after 'validate' function prefix
2013-05-27 23:07:06 +02:00
marc1706
b75f67231f [ticket/11578] Add missing underscore after 'validate' function prefix
The underscore after the 'validate' function prefix for the older
functions was dropped by accident in PR #1407. This patch will add it
back.

PHPBB3-11578
2013-05-27 22:56:49 +02:00
Joas Schilling
0032651729 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11538] Cut functional tests down a bit as these are more expensive.
  [ticket/11538] Compare to '' instead of using empty(), so '0' does not pass.
  [ticket/11538] Add unit tests for phpbb_validate_hex_colour().
2013-05-27 11:52:44 +02:00
Andreas Fischer
401e9466bf [ticket/11538] Compare to '' instead of using empty(), so '0' does not pass.
PHPBB3-11538
2013-05-26 19:24:09 +02:00
Andreas Fischer
06379aece8 Merge branch 'develop-olympus' into develop
* develop-olympus:
  [ticket/11538] Add optional switch as argument to hex colour validation
  [ticket/11538] Modify test colour values
  [ticket/11538] Limit comment in acp_groups to 80 characters per line
  [ticket/11538] Move group ID into abstract test class and add more test cases
  [ticket/11538] Merge calls to validate_data() in acp_groups
  [ticket/11538] Rename phpbb_validate_colour to phpbb_validate_hex_colour
  [ticket/11538] Use abstract class for functional test cases for group colour
  [ticket/11538] Add function phpbb_validate_colour for validating colours
  [ticket/11538] Make sure regex doesn't allow multiple color values
  [ticket/11538] Add tests for acp group manage page
  [ticket/11538] Simplify colour value check and remove support for '#'
  [ticket/11538] Fix incorrect regex and test for duplicate # in color string
  [ticket/11538] Use regex for testing color value and improve tests
  [ticket/11538] Make sure group color can't exceed maximum of 6 characters

Conflicts:
	phpBB/includes/functions_user.php
	phpBB/styles/prosilver/template/ucp_groups_manage.html
2013-05-26 19:19:08 +02:00
Andreas Fischer
2b356e766f Merge remote-tracking branch 'marc1706/ticket/11538' into develop-olympus
* marc1706/ticket/11538:
  [ticket/11538] Add optional switch as argument to hex colour validation
  [ticket/11538] Modify test colour values
  [ticket/11538] Limit comment in acp_groups to 80 characters per line
  [ticket/11538] Move group ID into abstract test class and add more test cases
  [ticket/11538] Merge calls to validate_data() in acp_groups
  [ticket/11538] Rename phpbb_validate_colour to phpbb_validate_hex_colour
  [ticket/11538] Use abstract class for functional test cases for group colour
  [ticket/11538] Add function phpbb_validate_colour for validating colours
  [ticket/11538] Make sure regex doesn't allow multiple color values
  [ticket/11538] Add tests for acp group manage page
  [ticket/11538] Simplify colour value check and remove support for '#'
  [ticket/11538] Fix incorrect regex and test for duplicate # in color string
  [ticket/11538] Use regex for testing color value and improve tests
  [ticket/11538] Make sure group color can't exceed maximum of 6 characters
2013-05-26 18:24:29 +02:00
erangamapa
8191755cca [ticket/11145] Wrong error thrown when uploading a bigger image.
When attaching an image to a post with a size larger than maximum defined in
php.ini, 'ATTACHED_IMAGE_NOT_IMAGE' error is thrown. $file->is_image() is
returning false value when image size is too large. Therefore, moved
not image test down after image size test.

PHPBB3-11145
2013-05-25 10:50:43 +05:30
David King
4b0d51adea Merge remote-tracking branch 'EXreaction/ticket/11435-2' into develop
* EXreaction/ticket/11435-2:
  [ticket/11435] Enable spacing test as it should now pass
  [ticket/11435] Create new template filter option (cleanup)
2013-05-22 16:10:51 -04:00
Nathaniel Guse
3ab222d1c7 Merge remote-tracking branch 'remotes/Senky/ticket/11010' into develop
# By Senky (19) and others
# Via Senky
* remotes/Senky/ticket/11010: (32 commits)
  [ticket/11010] properly tabifying 'max_autologin_time'
  [ticket/11010] resolving latest comments
  [ticket/11010] Fixes for number input in acp
  [ticket/11010] Fix input type for urls
  [ticket/11010] Fix email inputs
  [ticket/11010] updating tests
  [ticket/11010] dealing with dimensions problem, removing extra code
  [ticket/11010] Change input type to search for search forms
  [ticket/11010] Add all HTML5 input types to ACP
  [ticket/11010] Add HTML5 input types to installer
  [ticket/11010] validation to match type
  [ticket/11010] displaying min and max only if they are set
  [ticket/11010] fixing tests
  [ticket/11010] replacing maxlenght with max
  [ticket/11010] applying some of EXreaction notes
  [ticket/11010] Try to keep min < max.
  [ticket/11010] Mock user in order for the test to run standalone.
  [ticket/11010] Progress toward fixing the test suite.
  [ticket/11010] adding type="url" to 'site_home_url'
  [ticket/11010] fixing inputs types in memberlist_search.html
  ...
2013-05-21 09:49:53 -05:00
Senky
721bc03b2b [ticket/11010] properly tabifying 'max_autologin_time'
PHPBB3-11010
2013-05-21 11:57:33 +02:00
Senky
930f4c70ed [ticket/11010] resolving latest comments
PHPBB3-11010
2013-05-21 11:55:45 +02:00
Nathan Guse
421452e6fb Merge remote-tracking branch 'remotes/upstream/develop-olympus' into develop
# By David King
# Via David King (1) and Nathan Guse (1)
* remotes/upstream/develop-olympus:
  [ticket/11551] Fix error in system tab if get_remote_file returns empty string
2013-05-20 11:55:33 -05:00
Nathan Guse
c84fc97e90 [ticket/11435] Create new template filter option (cleanup)
This allows us to only run cleanup on the last run of template compilation
and not cleanup during event parsing

PHPBB3-11435
2013-05-20 11:45:32 -05:00
Vjacheslav Trushkin
3e64c1b5d7 [ticket/11010] Fixes for number input in acp
PHPBB3-11010
2013-05-20 18:42:11 +02:00
Senky
ae2700eef2 [ticket/11010] updating tests
PHPBB3-11010
2013-05-20 18:42:08 +02:00