1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-02-25 04:23:38 +01:00

2653 Commits

Author SHA1 Message Date
Marc Alexander
3823fe355f [ticket/11148] Change expected output with disallowed content in test
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
c22983cbdb [ticket/11148] Use mimetype guesser for uploaded avatars
PHPBB3-11148
2014-06-23 21:39:24 +02:00
Marc Alexander
9bc6e641bf [ticket/11148] Add mimetype guesser to filespec and fileupload class
The mimetype guesser will be used to get the mimetype of uploaded files.
Until now, this was only used for files uploaded with plupload. If a file
doesn't have a mimetype supplied, we will now try to get the correct mimetype.

PHPBB3-11148
2014-06-23 21:37:47 +02:00
Andreas Fischer
8332671813 Merge pull request #2587 from dhruvgoel92/ticket/11528
[ticket/11528] Refactor install_board( ) into a new mink class

* dhruvgoel92/ticket/11528:
  [ticket/11528] Change click_submit() to accept id as param
  [ticket/11528] Handle case when config file cant be written by installer
  [ticket/11528] Change NULL to null
  [ticket/11528] Fix spaces and slashes as per guidelines
  [ticket/11528] Add asserts in installation steps
  [ticket/11528] Use 'use' keyword to import classes to current scope
  [ticket/11528] Move parent::tearDown() to end of tearDown()
  [ticket/11528] Call parent::tearDown in overrided tearDown method
  [ticket/11528] Instantiate $client, $driver from functional test case
  [ticket/11528] Refactor install_board() code into a new class
  [ticket/11528] Add behat/mink and mink-goutte-driver as dependency
2014-06-23 20:38:11 +02:00
Dhruv
61fa0908bc [ticket/11528] Change click_submit() to accept id as param
PHPBB3-11528
2014-06-23 21:24:29 +05:30
Dhruv
2147a5eba5 [ticket/11528] Handle case when config file cant be written by installer
PHPBB3-11528
2014-06-23 21:23:47 +05:30
Cesar G
74a37259f7 Merge remote-tracking branch 'PayBas/ticket/12608' into develop-ascraeus
* PayBas/ticket/12608:
  [ticket/12608] Change CSS classes to prevent styling conflicts
  [ticket/12608] Add subSilver
  [ticket/12608] Changed get_styling() to get_style_class()
  [ticket/12608] Remove somewhat redundant reported color style
  [ticket/12608] Improved LTR and various bugfixes
  [ticket/12608] Clean up whitespace
  [ticket/12608] Add styling (CSS class) options to notifications
  [ticket/12608] Updated tests
  [ticket/12608] Improve notifications drop-down menu styling in header
2014-06-22 15:44:06 -07:00
Andreas Fischer
4f2acbaed2 Merge pull request #2629 from nickvergessen/ticket/12747
[ticket/12747] Drop support for Firebird

* nickvergessen/ticket/12747:
  [ticket/12747] Remove some methods which are not used anymore
  [ticket/12747] Drop support for Firebird

Conflicts:
	phpBB/phpbb/db/driver/firebird.php
2014-06-22 23:41:14 +02:00
Dhruv
f0e115fdcc [ticket/11528] Change NULL to null
PHPBB3-11528
2014-06-23 01:26:22 +05:30
Dhruv
a92c1d1ec0 [ticket/11528] Fix spaces and slashes as per guidelines
PHPBB3-11528
2014-06-23 01:26:21 +05:30
Dhruv
f5aa9732d1 [ticket/11528] Add asserts in installation steps
PHPBB3-11528
2014-06-23 01:26:19 +05:30
Dhruv
2d1a998003 [ticket/11528] Use 'use' keyword to import classes to current scope
PHPBB3-11528
2014-06-23 01:26:18 +05:30
Dhruv
c26fa6a15b [ticket/11528] Move parent::tearDown() to end of tearDown()
PHPBB3-11528
2014-06-23 01:26:17 +05:30
Dhruv
019b345171 [ticket/11528] Call parent::tearDown in overrided tearDown method
PHPBB3-11528
2014-06-23 01:26:16 +05:30
Dhruv
648cbbd9a0 [ticket/11528] Instantiate $client, $driver from functional test case
Make mink test case an abstract class, instantiate $driver, $client
from its child class i.e. functional test case.

PHPBB3-11528
2014-06-23 01:26:14 +05:30
Dhruv
01f350a614 [ticket/11528] Refactor install_board() code into a new class
PHPBB3-11528
2014-06-23 01:26:13 +05:30
Joas Schilling
7afc13b4db Merge pull request #2615 from Dragooon/ticket/12730
[ticket/12730] Add Google+ profile field

* Dragooon/ticket/12730:
  [ticket/12730] Update Google+ button class to use proper identification
  [ticket/12730] Update maxlen for type_googleplus to 255
  [ticket/12730] Fix type_googleplus_test to use same validation rule as the field
  [ticket/12730] Update field_length to be 20 by default for Google+
  [ticket/12730] Google+ field_order should be 13
  [ticket/12730] Switch service name to googleplus for type_googleplus
  [ticket/12730] Restore field_length to 10 for type_googleplus
  [ticket/12730] Add functional test for Google+ field
  [ticket/12730] Value shouldn't be escaped for schema_data.sql
  [ticket/12730] Missing newline at type_googleplus_test.php
  [ticket/12730] Set field_active to 1 for Google+ field
  [ticket/12730] Add unit test for type_googleplus
  [ticket/12730] Add missing brackets to type_googleplus.php
  [ticket/12730] Update field_order for Google+ CPF
  [ticket/12730] Use string template for Google+ CPF instead of a new one
  [ticket/12730] Minor formatting fixes
  [ticket/12730] Incorrect indentation for type_googleplus
  [ticket/12730] Spaces in block header
  [ticket/12730] Add a Google+ field by default
  [ticket/12730] Add Google+ profile field type
2014-06-22 19:40:56 +02:00
Joas Schilling
dc7ed58bf5 [ticket/12747] Remove some methods which are not used anymore
PHPBB3-12747
2014-06-22 19:31:40 +02:00
Joas Schilling
40d264654c Merge pull request #2631 from Nicofuma/ticket/12752
[ticket/12752] Cron list tests fail on windows with ansi support

* Nicofuma/ticket/12752:
  [ticket/12752] Cron list tests fail on windows with ansi support
2014-06-21 00:40:55 +02:00
Shitiz Garg
ff057dfc8e [ticket/12730] Fix type_googleplus_test to use same validation rule as the field
PHPBB3-12730
2014-06-21 03:49:59 +05:30
Shitiz Garg
ea0e073c12 [ticket/12730] Add functional test for Google+ field
PHPBB3-12730
2014-06-21 03:35:19 +05:30
Shitiz Garg
b50744ae09 [ticket/12730] Missing newline at type_googleplus_test.php
PHPBB3-12730
2014-06-21 03:32:34 +05:30
Shitiz Garg
30cce1ed49 [ticket/12730] Add unit test for type_googleplus
PHPBB3-12730
2014-06-21 03:31:45 +05:30
Joas Schilling
18bf45ab1b Merge pull request #2628 from Dragooon/ticket/12731
[ticket/12731] Add YouTube custom profile field

* Dragooon/ticket/12731:
  [ticket/12731] Add functional test for youtube field
  [ticket/12731] Set field_active to 1 for YouTube field
  [ticket/12731] Add YouTube custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
2014-06-20 23:42:54 +02:00
Joas Schilling
3c38fcce40 Merge pull request #2621 from Dragooon/ticket/12732
[ticket/12732] Add Skype custom profile field

* Dragooon/ticket/12732:
  [ticket/12732] Update schema.json for Skype
  [ticket/12732] Add functional test for Skype profile field
  [ticket/12732] Values shouldn't be escaped for schema_data.sql
  [ticket/12732] Set field_active to 1 for Skype's field
  [ticket/12732] Add unit tests for ALPHA_PUNCTUATION
  [ticket/12732] Missing comma after validation definition
  [ticket/12732] Improve ALPHA_PUNCTUATION description
  [ticket/12732] Use user info instead of chat as default Skype action
  [ticket/12732] Add Skype custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
	tests/profilefields/type_string_test.php
2014-06-20 23:39:54 +02:00
Joas Schilling
b9890c6a4c Merge pull request #2612 from Dragooon/ticket/12733
[ticket/12733] Add Twitter custom profile field

* Dragooon/ticket/12733:
  [ticket/12733] Add functional test for twitter profile field
  [ticket/12733] Values needn't be escaped for schema_data.sql
  [ticket/12733] Set field_active to 1 for Twitter
  [ticket/12733] Convert spaces to tabs
  [ticket/12733] Fix spacing for block header in profilefield_twitter.php
  [ticket/12733] Update schema.json
  [ticket/12733] Add Twitter custom profile field

Conflicts:
	phpBB/install/schemas/schema.json
	phpBB/install/schemas/schema_data.sql
	phpBB/language/en/memberlist.php
	tests/functional/ucp_profile_test.php
2014-06-20 23:37:51 +02:00
Joas Schilling
8595fee040 Merge pull request #2611 from Dragooon/ticket/12729
[ticket/12729] Add Facebook custom profile field

* Dragooon/ticket/12729:
  [ticket/12729] Add functional test for Facebook field
  [ticket/12730] Values needn't be escaped for schema_data.sql
  [ticket/12729] Set field_active as 1 for Facebook profile field
  [ticket/12729] Add unit test for ALPHA_DOTS validation
  [ticket/12729] Move ALPHA_DOTS to above ALPHA_SPACERS
  [ticket/12729] Convert spaces to tabs
  [ticket/12729] Fix block header spacing for profilefield_facebook.php
  [ticket/12729] Update schema.json
  [ticket/12729] Unnecessary whitespace in profilefield_facebook.php
  [ticket/12729] Cleanup schema_data.sql for Facebook field
  [ticket/12729] Add Facebook custom profile field
2014-06-20 23:36:26 +02:00
Tristan Darricau
0404d3b910 [ticket/12752] Cron list tests fail on windows with ansi support
PHPBB3-12752
2014-06-20 19:12:58 +02:00
Shitiz Garg
aeeaf2f6ef [ticket/12729] Add functional test for Facebook field
PHPBB3-12729
2014-06-20 21:20:04 +05:30
Shitiz Garg
51b4dc7077 [ticket/12731] Add functional test for youtube field
PHPBB3-12731
2014-06-20 21:17:23 +05:30
Shitiz Garg
10b466848a [ticket/12732] Add functional test for Skype profile field
PHPBB3-12732
2014-06-20 21:13:29 +05:30
Shitiz Garg
cdfcbfc6d0 [ticket/12733] Add functional test for twitter profile field
PHPBB3-12733
2014-06-20 21:12:02 +05:30
Joas Schilling
a5ca7479b2 Merge pull request #2626 from dhruvgoel92/ticket/12746
[ticket/12746] Init phpbb_dispatcher being used by delete_post()

* dhruvgoel92/ticket/12746:
  [ticket/12746] Init phpbb_dispatcher being used by delete_post()
2014-06-20 16:02:18 +02:00
Shitiz Garg
fc6cb02e1f [ticket/12729] Add unit test for ALPHA_DOTS validation
PHPBB3-12729
2014-06-20 18:12:26 +05:30
Shitiz Garg
9b85e4b141 [ticket/12732] Add unit tests for ALPHA_PUNCTUATION
PHPBB3-12732
2014-06-20 16:43:15 +05:30
Joas Schilling
04164affe6 [ticket/12747] Drop support for Firebird
PHPBB3-12747
2014-06-20 12:35:42 +02:00
Dhruv
37fd00b298 [ticket/12738] Add $config to constructor in notification test
PHPBB3-12738
2014-06-20 16:01:11 +05:30
Joas Schilling
70d4ede9b2 Merge pull request #2459 from Dragooon/ticket/12514
[ticket/12514] Add tests for profile fields

* Dragooon/ticket/12514: (28 commits)
  [ticket/12514] Fix array formatting for tests
  [ticket/12514] Fix indention for type_url_test.php
  [ticket/12514] Missed a few spaces in comments
  [ticket/12514] Convert spaces to tabs
  [ticket/12514] Add a few additional tests for type_dropdown
  [ticket/12514] Add a few additional tests for type_int
  [ticket/12514] Fix some formatting for tests
  [ticket/12514] Add a few more tests for type_date
  [ticket/12514] Remove spaces in header blocks
  [ticket/12514] Use generic domain name for URL test
  [ticket/12514] Update file headers to represent the current format
  [ticket/12514] Remove get_ prefix from data providers
  [ticket/12514] Add a few more validation cases for type_string_test
  [ticket/12514] Minor fault in type_bool_test.php
  [ticket/12514] Remove tests/profiles as they're no longer required
  [ticket/12514] Fix type_int_test to correctly respect boundaries
  [ticket/12514] Multi value GET parameters are invalid for phpBB
  [ticket/12514] Add unit test for type_url custom profile field
  [ticket/12514] Add unit test for type_date custom profile field
  [ticket/12514] Add unit test for type_bool custom profile field
  ...
2014-06-20 12:14:23 +02:00
Dhruv
eeb2c128f5 [ticket/12738] Fix tests with new config object injection
PHPBB3-12738
2014-06-20 15:40:23 +05:30
Dhruv
752b5b6628 [ticket/12746] Init phpbb_dispatcher being used by delete_post()
PHPBB3-12746
2014-06-20 15:30:04 +05:30
Shitiz Garg
4472a492da [ticket/12514] Fix array formatting for tests
PHPBB3-12514
2014-06-20 14:47:20 +05:30
Shitiz Garg
3ac73a831a [ticket/12514] Fix indention for type_url_test.php
PHPBB3-12514
2014-06-20 14:41:59 +05:30
Joas Schilling
b855f5fc6a Merge pull request #2566 from marc1706/ticket/11711
[ticket/11711] Inform user of unsupported characters while posting

* marc1706/ticket/11711:
  [ticket/11711] Improve coding and comments of character check
  [ticket/11711] Reduce size of tests and also test topic titles
  [ticket/11711] Improve checks for unsupported characters and check subject
  [ticket/11711] Inform user of unsupported characters while posting
2014-06-20 10:51:58 +02:00
Tristan Darricau
8595b2ae86 [ticket/12716] Add regression test
PHPBB3-12716
2014-06-19 21:04:43 +02:00
Shitiz Garg
f076b43915 [ticket/12514] Missed a few spaces in comments
PHPBB3-12514
2014-06-18 18:18:15 +05:30
Shitiz Garg
d1f517ad65 [ticket/12514] Convert spaces to tabs
PHPBB3-12514
2014-06-18 17:54:15 +05:30
Shitiz Garg
9f478de2ca [ticket/12514] Add a few additional tests for type_dropdown
PHPBB3-12514
2014-06-18 17:48:56 +05:30
Shitiz Garg
566f76a6b0 [ticket/12514] Add a few additional tests for type_int
PHPBB3-12514
2014-06-18 17:48:47 +05:30
Shitiz Garg
e820143e87 [ticket/12514] Fix some formatting for tests
PHPBB3-12514
2014-06-18 01:48:34 +05:30
Shitiz Garg
f549a6ce9f [ticket/12514] Add a few more tests for type_date
PHPBB3-12514
2014-06-18 01:40:40 +05:30