1
0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-05 05:55:15 +02:00

107 Commits

Author SHA1 Message Date
rxu
1eb81e9b2a
[ticket/17142] Fix class inheritance issues
PHPBB3-17142
2023-06-08 10:11:54 +07:00
rxu
7adee3c50d
[ticket/17142] Fix DBMS+cache related PHP warnings while installing
PHPBB3-17142
2023-06-08 00:59:32 +07:00
Marc Alexander
b5c316c9c3
[ticket/8071] Make nextid alias of sql_last_inserted_id and add deprecation
PHPBB3-8071
2023-01-31 17:17:42 +01:00
lionel-rowe
9fb98201f2 [ticket/8071] Add sql_last_inserted_id alias for sql_nextid
Fixes [DBAL function sql_nextid - name is
misleading](https://tracker.phpbb.com/browse/PHPBB3-8071).

Per the tracker issue:
> This function gets the ID of the last inserted row, not the ID of the next row
to be inserted (which is difficult due to different autoincrement steps and also
lends itself nicely to race conditions).

@iwisdom replied that the naming is consistent with how PHP itself names this
functionality, but the link they posted doesn't support that (I guess this is
referring to a much older version of PHP? The comment is from 2009).

PHPBB3-8071
2022-04-26 15:03:42 +01:00
Tristan Darricau
ede9a6815a [ticket/16897] Ignores sqlite3 warnings when an explain query plan query fails
PHPBB3-16897
2021-10-28 21:52:03 +02:00
rxu
721a39502a
[ticket/16840] Add PHP 8.0 / 8.1 builds for Windows tests
Also fix Postrges PHP 8.1 related issue.

PHPBB3-16840
2021-08-07 16:50:45 +07:00
Marc Alexander
ecc79ea2ec
Merge branch 'prep-release-3.3.4' into 3.3.x 2021-05-01 21:51:16 +02:00
rxu
3d5639a844
[ticket/16749] Explicitly set default MySQLi error mode
PHPBB3-16749
2021-04-04 17:11:59 +07:00
Marc Alexander
4ce8224c2c
[ticket/16740] Use is_resource() to check whether connect id is still valid
PHPBB3-16740
2021-03-31 21:22:14 +02:00
Marc Alexander
c99bfe116f
[ticket/16740] Improve open queries handling & do not close freed connection
PHPBB3-16740
2021-03-28 09:52:55 +02:00
Marc Alexander
645e662b11
[ticket/16740] Add method for ensuring resource is not passed to cache
PHPBB3-16740
2021-03-26 22:54:19 +01:00
rxu
2fd4dbb685
[ticket/16690] Fix htmlspecialchars and htmlspecialchars_decode default flag
PHPBB3-16690
2021-01-20 00:21:24 +07:00
Máté Bartus
b3e7c01ab6 [ticket/16671] Fix coding style
PHPBB3-166671
2020-12-31 14:50:28 +01:00
Marc Alexander
e769ac7941
Merge pull request #6052 from rxu/ticket/16607
[ticket/16607] Update Oracle DBAL driver OCI8 aliases and functions
2020-12-22 21:25:47 +01:00
rxu
46d0cf7bb4
[ticket/16607] Update Oracle DBAL driver OCI8 aliases and functions
PHPBB3-16607
2020-09-29 22:13:19 +07:00
rxu
0bc9d87891
[ticket/16538] Add identifiers quoting
If reserved word is used as identifier, it must be quoted.
If alias is used elsewhere in SQL statement, it must be quoted.

PHPBB3-16535
PHPBB3-16538
2020-08-14 04:51:11 +07:00
Marc Alexander
af97a8312c
Merge branch '3.2.x' into 3.3.x 2020-05-04 20:37:38 +02:00
mrgoldy
ed974c2c84 [ticket/16467] Fix PostgreSQL connection password
PHPBB3-16467
2020-05-04 11:49:45 +02:00
rxu
75c03dd81e
[ticket/16307] Fix SQL time reporting when debug.sql_explain parameter is set
PHPBB3-16307
2020-01-08 22:05:55 +07:00
Marc Alexander
bd02c5bd08
[ticket/16051] Remove mysql driver as it's no longer supported in PHP >= 7.0
PHPBB3-16051
2019-10-06 12:07:35 +02:00
Marc Alexander
a7c02304a5
Merge branch '3.2.x' into 3.3.x 2019-09-20 22:23:06 +02:00
Marc Alexander
4555817a8b
[ticket/security/247] Disable loading of local files on client side
SECURITY-247
2019-08-11 21:31:59 +02:00
Jakub Senko
139eb17bb7
[ticket/12624] Add debug.load_time parameter
PHPBB3-12624
2019-05-09 18:40:15 +02:00
Jakub Senko
b4d4336ef4
[ticket/12627] Add debug.sql_explain parameter
PHPBB3-12627
2019-05-09 18:29:22 +02:00
luzpaz
a9a28859d4
[ticket/15424] Multiple typo fixes in docs & comments
Fixed typos in some docs, guidelines, some non-user-facing files.

PHPBB3-15424
2019-05-08 22:20:56 +02:00
hubaishan
dc96e70d1b [ticket/15665] fix double semicolon
PHPBB3-15665
2018-11-20 15:56:02 +03:00
hubaishan
717d4840e2 [ticket/15665] Fix MSSQL crashes if upload dir>2GB
Add cast_expr_to_bigint() to mssql_base

PHPBB3-15665
2018-11-20 13:38:15 +03:00
hubaishan
b0b70589a2 [ticket/15612] Fix PHP7.2 count() bug in MSSQL driver
sqlsrv_fetch_array() function returns an array when data found,
null when no data or false on error. So we need to change null to false only.

PHPBB3-15612
2018-08-25 16:17:55 +03:00
FH
4577404fc2 [ticket/15520] sql_build_query build subquery
Fix for the building of subqueries
in sql_build_query

PHPBB3-15520
2018-02-03 21:06:12 +01:00
Derky
182a96f273 Merge pull request #4680 from marc1706/ticket/15055
[ticket/15055] Add appveyor file to allow running tests on appveyor as well
2018-01-05 22:44:34 +01:00
Marc Alexander
6f6750b629 [ticket/15055] Specify utf8 as character set in sqlsrv_connect
This is needed to be able to correctly retrieve unicode data from the db.

PHPBB3-15055
2018-01-01 18:55:25 +01:00
rxu
f8fbe37936
[ticket/14972] replace all occurrences of sizeof() with the count()
PHPBB3-14972
2018-01-01 13:56:04 +01:00
rxu
8c3808e9e7
[ticket/14972] Fix sizeof calls
As of PHP 7.2, only arrays and objects implementing the Countable interface
should be passed as a count() or sizeof() parameter.
See https://github.com/php/php-src/blob/php-7.2.0alpha2/UPGRADING#L197-L198
Also, sizeof() seems to be sheduled for deprecation, see
https://wiki.php.net/rfc/deprecations_php_7_2#suggested_deprecations

PHPBB3-14972
2018-01-01 13:08:12 +01:00
Jakub Senko
e974f338af [ticket/14739] Remove SQLite 2.8.x database driver
PHPBB3-14739
2016-11-16 17:59:28 +01:00
Jakub Senko
c64b8102b7 [ticket/10809] Remove MSSQL support
PHPBB3-10809
2016-08-02 12:06:06 +02:00
Marc Alexander
2e3f89444a Merge branch 'ticket/14136' into ticket/14136-3.2.x
Conflicts:
	phpBB/adm/style/install_update_diff.html
	phpBB/adm/style/installer_header.html
	phpBB/install/database_update.php
	phpBB/install/index.php
	phpBB/styles/subsilver2/template/overall_header.html
	phpBB/styles/subsilver2/template/simple_header.html
	phpBB/styles/subsilver2/template/ucp_pm_viewmessage_print.html
	phpBB/styles/subsilver2/template/viewtopic_print.html
2016-03-24 16:12:56 +01:00
Marc Alexander
244d171cb0 [ticket/14136] Add back X-UA-Compatible meta tag
This was previously removed without needing to. Adding it back to force
users to not emulate the page for previous versions of IE. The
imagetoolbar http-equiv tag was not restored as IE does not contain that
anymore since IE7. Also, the chome=1 has been removed from the
X-UA-Compatible content as ChromeFrame does not receive any further
updates since 2014 and is potentially broken.

PHPBB3-14136
2016-03-24 16:07:07 +01:00
Marc Alexander
7a6a16e3a5 [ticket/13454] Remove unused variables
This is part 5 and there is more to come.

PHPBB3-13454
2016-01-06 13:52:11 +01:00
Marc Alexander
73e6e5b77f [ticket/13454] Remove unused variables
This is the first part of the changes. More to come.

PHPBB3-13454
2016-01-06 13:51:19 +01:00
brunoais
a3a163dea1 [feature/sql-bool-builder] Fixing misuse of LOGICAL_OP instead of STATEMENTS
PHPBB3-13652
2015-11-24 07:31:37 +00:00
brunoais
335be2e59f [feature/sql-bool-builder] Fixing typos in previous commit
PHPBB3-13652
2015-11-12 06:52:34 +00:00
brunoais
9725f5757e [feature/sql-bool-builder] Changing syntax pt3. Don't use magic numbers
PHPBB3-13652
2015-11-11 08:38:38 +00:00
brunoais
bb260f02e0 [feature/sql-bool-builder] Changing syntax
Changing the syntax used to the one Nicofuma suggested.

PHPBB3-13652
2015-11-11 08:38:37 +00:00
Marc Alexander
df53d40922 [ticket/14044] Automatically trigger rollback on insert in transaction
This will cause the sqlite3 driver to automatically rollback transactions
if an insert fails during a transaction. Other dbms trigger a rollback
inside the sql_error() function with a rollback command. However,
this manual rollback command might fail on sqlite3 due to ongoing queries.

With this change, sqlite3 itself will abort any ongoing queries and
initiate the rollback automatically. Since manually triggered rollbacks
will fail after the rollback was started automatically, we catch
exceptions output by the exec() command during rollback and any exception
that might be thrown by fetchArray() due to aborted queries.

PHPBB3-14044
2015-10-23 20:47:56 +02:00
Marc Alexander
e0d06ee83e [ticket/14044] Fix Sqlite error in tests
PHPBB3-14044
2015-10-23 11:46:03 +02:00
Tristan Darricau
84150d0d44 [ticket/13652] Fix coding style
PHPBB3-13652
2015-10-14 17:15:09 +02:00
Tristan Darricau
cd114a68e9 Merge pull request #3441 from brunoais/feature/sql-bool-builder
[feature/sql-bool-builder] Extending DBAL query builder for boolean generation

* brunoais/feature/sql-bool-builder:
  [feature/sql-bool-builder] Improved tests output to show the SQL error.
  [feature/sql-bool-builder] Adding the IS operator to predicted operators
  [feature/sql-bool-builder] test_single_not_like
  [feature/sql-bool-builder] test_single_like
  [feature/sql-bool-builder] test_single_not_in
  [feature/sql-bool-builder] test_single_in
  [feature/sql-bool-builder] test_and_of_or_of_and
  [feature/sql-bool-builder] test_triple_and_with_in
  [feature/sql-bool-builder] test_double_and_with_not_of_and
  [feature/sql-bool-builder] test_triple_and_with_is_null
  [feature/sql-bool-builder] Prepare testing class
  [feature/sql-bool-builder] Added LIKE and NOT_LIKE to the comparations
  [feature/sql-bool-builder] Explain better the code in the first
  [feature/sql-bool-builder] Also use parenthesis for the NOT operator
  [feature/sql-bool-builder] AS keyword must be lowercase;
  [feature/sql-bool-builder] Added code to use this feature for the WHERE clause
  [feature/sql-bool-builder] Removed non-necessary spaces
  [feature/sql-bool-builder] First working version
2015-10-14 16:18:46 +02:00
Tristan Darricau
23205ca0cc Merge branch '3.1.x'
* 3.1.x:
  [ticket/13423] Set busyTimeout on connect to prevent db locking
2015-09-09 11:01:03 +02:00
Marc Alexander
ea594d00f7 [ticket/13423] Set busyTimeout on connect to prevent db locking
PHPBB3-13423
2015-09-07 12:23:49 +02:00
Andreas Fischer
0a5f7d2e51 Merge branch '3.1.x'
* 3.1.x:
  [ticket/14116] sql_affectedrows method has no arguments
2015-08-20 03:52:34 +02:00