mirror of
https://github.com/phpbb/phpbb.git
synced 2025-05-04 14:47:52 +02:00
Refactoring the continue/is_valid test to remove the confusing data provider work around, while still keeping redundancies down to a minimum. PHPBB3-11615
86 lines
2.8 KiB
PHP
86 lines
2.8 KiB
PHP
<?php
|
|
/**
|
|
*
|
|
* @package testing
|
|
* @copyright (c) 2013 phpBB Group
|
|
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
|
|
*
|
|
*/
|
|
|
|
require_once dirname(__FILE__) . '/testable_factory.php';
|
|
|
|
class phpbb_session_check_isvalid_test extends phpbb_database_test_case
|
|
{
|
|
public function getDataSet()
|
|
{
|
|
return $this->createXMLDataSet(dirname(__FILE__).'/fixtures/sessions_full.xml');
|
|
}
|
|
|
|
protected function access_with($session_id, $user_id, $user_agent, $ip)
|
|
{
|
|
global $phpbb_container, $phpbb_root_path, $phpEx;
|
|
|
|
$db = $this->new_dbal();
|
|
$config = new phpbb_config(array());
|
|
$request = $this->getMock('phpbb_request');
|
|
$user = $this->getMock('phpbb_user');
|
|
|
|
$auth_provider = new phpbb_auth_provider_db($db, $config, $request, $user, $phpbb_root_path, $phpEx);
|
|
$phpbb_container = $this->getMock('Symfony\Component\DependencyInjection\ContainerInterface');
|
|
$phpbb_container->expects($this->any())
|
|
->method('get')
|
|
->with('auth.provider.db')
|
|
->will($this->returnValue($auth_provider));
|
|
|
|
$session_factory = new phpbb_session_testable_factory;
|
|
$session_factory->merge_test_data($session_id, $user_id, $user_agent, $ip);
|
|
|
|
$session = $session_factory->get_session($db);
|
|
$session->page = array('page' => 'page', 'forum' => 0);
|
|
|
|
$session->session_begin();
|
|
$session_factory->check($this);
|
|
return $session;
|
|
}
|
|
|
|
protected function check_session_equals($expected_sessions, $message)
|
|
{
|
|
$sql = 'SELECT session_id, session_user_id
|
|
FROM phpbb_sessions
|
|
ORDER BY session_user_id';
|
|
|
|
$this->assertSqlResultEquals($expected_sessions, $sql, $message);
|
|
}
|
|
|
|
public function test_session_valid_session_exists()
|
|
{
|
|
$session = $this->access_with('bar_session000000000000000000000', '4', 'user agent', '127.0.0.1');
|
|
$session->check_cookies($this, array());
|
|
|
|
$this->check_session_equals(array(
|
|
array('session_id' => 'anon_session00000000000000000000', 'session_user_id' => 1),
|
|
array('session_id' => 'bar_session000000000000000000000', 'session_user_id' => 4),
|
|
),
|
|
'If a request comes with a valid session id with matching user agent and IP, no new session should be created.'
|
|
);
|
|
}
|
|
|
|
public function test_session_invalid_make_new_annon_session()
|
|
{
|
|
$session = $this->access_with('anon_session00000000000000000000', '4', 'user agent', '127.0.0.1');
|
|
$session->check_cookies($this, array(
|
|
'u' => array('1', null),
|
|
'k' => array(null, null),
|
|
'sid' => array($session->session_id, null),
|
|
));
|
|
|
|
$this->check_session_equals(array(
|
|
array('session_id' => $session->session_id, 'session_user_id' => 1), // use generated SID
|
|
array('session_id' => 'bar_session000000000000000000000', 'session_user_id' => 4),
|
|
),
|
|
'If a request comes with a valid session id and IP but different user id and user agent,
|
|
a new anonymous session is created and the session matching the supplied session id is deleted.'
|
|
);
|
|
}
|
|
}
|