mirror of
https://github.com/phpbb/phpbb.git
synced 2025-05-24 00:05:33 +02:00
ee875c0a43
The type of $user->data['user_id'] is (almost) guranteed to be integer since session::session_create() casts it to integer. The type of $row['user_id'] is only an integer if the DB driver adjusts the PHP type according to the DB type. This is only done by some of our not-so-popular DB drivers and is not the case for MySQL. As such this comparison is (almost) never true and a PM is also sent to the author itself when it is sent to a group the author is also a member of. Since this behaviour seems to have been accepted by the communty, the dead code is removed and current behaviour is kept. Also, checking this in the loop seems to be a rather bad idea. Introduced by 78b1c4caaa17cc8760b685ad41c19f15f9d89b68. PHPBB3-10790
ABOUT
phpBB is a free bulletin board written in PHP.
COMMUNITY
Find support and lots more on phpBB.com! Discuss the development on area51.
CONTRIBUTE
- Create an account on phpBB.com
- Create a ticket (unless there already is one)
- Read our Git Contribution Guidelines; if you're new to git, also read the introduction guide
- Send us a pull request
AUTOMATED TESTING
We have unit and functional tests in order to prevent regressions. You can view the bamboo continuous integration here or check our travis build below.
develop - 
develop-olympus - 