mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-22 16:13:35 +02:00
Code Issues Releases Wiki Activity

bridges: Remove unused functions and update scopes

Browse Source 
Many bridges implemented getDescription() which is only applicable for
bridges extending RSSExpander.

Functions that are not part of the abstract class or interface should
be in private scope for better readability.
This commit is contained in:
logmanoriginal
2016-08-06 16:00:56 +02:00
parent f99f4d23ac
commit 1d53b70272
34 changed files with 87 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bridges/CastorusBridge.php
View File

@@ -5,7 +5,7 @@ class CastorusBridge extends BridgeAbstract {
$this->name = "Castorus Bridge";
$this->uri = $this->getURI();
$this->description = "Returns the latest changes";
$this->update = "2016-08-05";
$this->update = "2016-08-06";
$this->parameters["Get latest changes"] = '[]';
$this->parameters["Get latest changes via ZIP code"] =
@@ -33,7 +33,7 @@ class CastorusBridge extends BridgeAbstract {
}
// Extracts the tile from an actitiy
function ExtractActivityTitle($activity){
private function ExtractActivityTitle($activity){
$title = $activity->find('a', 0);
if(!$title)
@@ -43,7 +43,7 @@ class CastorusBridge extends BridgeAbstract {
}
// Extracts the url from an actitiy
function ExtractActivityUrl($activity){
private function ExtractActivityUrl($activity){
$url = $activity->find('a', 0);
if(!$url)
@@ -53,7 +53,7 @@ class CastorusBridge extends BridgeAbstract {
}
// Extracts the time from an activity
function ExtractActivityTime($activity){
private function ExtractActivityTime($activity){
// Unfortunately the time is part of the parent node,
// so we have to clear all child nodes first
$nodes = $activity->find('*');
@@ -69,7 +69,7 @@ class CastorusBridge extends BridgeAbstract {
}
// Extracts the price change
function ExtractActivityPrice($activity){
private function ExtractActivityPrice($activity){
$price = $activity->find('span', 1);
if(!$price)