mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-30 03:20:30 +02:00
Code Issues Releases Wiki Activity

bridges: Remove unused functions and update scopes

Browse Source 
Many bridges implemented getDescription() which is only applicable for
bridges extending RSSExpander.

Functions that are not part of the abstract class or interface should
be in private scope for better readability.
This commit is contained in:
logmanoriginal
2016-08-06 16:00:56 +02:00
parent f99f4d23ac
commit 1d53b70272
34 changed files with 87 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
bridges/GBAtempBridge.php
View File

@@ -9,7 +9,7 @@ class GBAtempBridge extends BridgeAbstract {
$this->name = 'GBAtemp';
$this->uri = $this->getURI();
$this->description = 'GBAtemp is a user friendly underground video game community.';
$this->update = '2016-08-02';
$this->update = '2016-08-06';
$this->parameters[] =
'[
@@ -40,7 +40,7 @@ class GBAtempBridge extends BridgeAbstract {
]';
}
function ExtractFromDelimiters($string, $start, $end) {
private function ExtractFromDelimiters($string, $start, $end) {
if (strpos($string, $start) !== false) {
$section_retrieved = substr($string, strpos($string, $start) + strlen($start));
$section_retrieved = substr($section_retrieved, 0, strpos($section_retrieved, $end));
@@ -48,7 +48,7 @@ class GBAtempBridge extends BridgeAbstract {
} return false;
}
function StripWithDelimiters($string, $start, $end) {
private function StripWithDelimiters($string, $start, $end) {
while (strpos($string, $start) !== false) {
$section_to_remove = substr($string, strpos($string, $start));
$section_to_remove = substr($section_to_remove, 0, strpos($section_to_remove, $end) + strlen($end));
@@ -56,7 +56,7 @@ class GBAtempBridge extends BridgeAbstract {
} return $string;
}
function build_item($uri, $title, $author, $timestamp, $thumnail, $content) {
private function build_item($uri, $title, $author, $timestamp, $thumnail, $content) {
$item = new \Item();
$item->uri = $uri;
$item->title = $title;
@@ -67,14 +67,14 @@ class GBAtempBridge extends BridgeAbstract {
return $item;
}
function cleanup_post_content($content, $site_url) {
private function cleanup_post_content($content, $site_url) {
$content = str_replace(':arrow:', '➤', $content);
$content = str_replace('href="attachments/', 'href="'.$site_url.'attachments/', $content);
$content = $this->StripWithDelimiters($content, '<script', '</script>');
return $content;
}
function fetch_post_content($uri, $site_url) {
private function fetch_post_content($uri, $site_url) {
$html = $this->file_get_html($uri) or $this->returnError('Could not request GBAtemp: '.$uri, 500);
$content = $html->find('div.messageContent', 0)->innertext;
return $this->cleanup_post_content($content, $site_url);