mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-07-26 03:11:18 +02:00
Code Issues Releases Wiki Activity

fix: dont aquire exclusive locks (#4340)

Browse Source 
Due to bugs in logging/error-handling there sometimes are deadlocks
This commit is contained in:
Dag
2024-11-23 22:28:50 +01:00
committed by GitHub
parent e3260ff529
commit 628b30208a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
caches/FileCache.php
View File

@@ -53,7 +53,7 @@ class FileCache implements CacheInterface
'value' => $value, 'value' => $value,
]; ];
$cacheFile = $this->createCacheFile($key); $cacheFile = $this->createCacheFile($key);
$bytes = file_put_contents($cacheFile, serialize($item), LOCK_EX); $bytes = file_put_contents($cacheFile, serialize($item));
// todo: Consider tightening the permissions of the created file. It usually allow others to read, depending on umask // todo: Consider tightening the permissions of the created file. It usually allow others to read, depending on umask
if ($bytes === false) { if ($bytes === false) {
// Consider just logging the error here // Consider just logging the error here

2
lib/logger.php
View File

@@ -136,7 +136,7 @@ final class StreamHandler
$record['message'], $record['message'],
$context $context
); );
$bytes = file_put_contents($this->stream, $text, FILE_APPEND | LOCK_EX); $bytes = file_put_contents($this->stream, $text, FILE_APPEND);
} }
} }