mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-07-30 21:30:14 +02:00
Code Issues Releases Wiki Activity

Fix coding style missed by phpbcf (#2901)

Browse Source 
$ composer require --dev friendsofphp/php-cs-fixer

$ echo >.php-cs-fixer.dist.php "<?php

$finder = PhpCsFixer\Finder::create()
    ->in(__DIR__);

$rules = [
    '@PSR12' => true,
    // '@PSR12:risky' => true,
    '@PHP74Migration' => true,
    // '@PHP74Migration:risky' => true,
    // buggy, duplicates existing comment sometimes
    'no_break_comment' => false,
    'array_syntax' => true,
    'lowercase_static_reference' => true,
    'visibility_required' => false,
    // Too much noise
    'binary_operator_spaces' => false,
    'heredoc_indentation' => false,
    'trailing_comma_in_multiline' => false,
];

$config = new PhpCsFixer\Config();

return $config
    ->setRules($rules)
    // ->setRiskyAllowed(true)
    ->setFinder($finder);

"

$ vendor/bin/php-cs-fixer --version
PHP CS Fixer 3.8.0 BerSzcz against war! by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.7

$ vendor/bin/php-cs-fixer fix
$ rm .php-cs-fixer.cache
$ vendor/bin/php-cs-fixer fix
This commit is contained in:
Jan Tojnar
2022-07-08 13:00:52 +02:00
committed by GitHub
parent dbf8c5b7ae
commit 951092eef3
42 changed files with 175 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bridges/GithubIssueBridge.php
View File

@@ -274,18 +274,18 @@ class GithubIssueBridge extends BridgeAbstract
switch (count($path_segments)) {
case 2: // Project issues
list($user, $project) = $path_segments;
[$user, $project] = $path_segments;
$show_comments = 'off';
break;
case 3: // Project issues with issue comments
if ($path_segments[2] !== static::URL_PATH) {
return null;
}
list($user, $project) = $path_segments;
[$user, $project] = $path_segments;
$show_comments = 'on';
break;
case 4: // Issue comments
list($user, $project, /* issues */, $issue) = $path_segments;
[$user, $project, /* issues */, $issue] = $path_segments;
break;
default:
return null;
@@ -294,8 +294,8 @@ class GithubIssueBridge extends BridgeAbstract
return [
'u' => $user,
'p' => $project,
'c' => isset($show_comments) ? $show_comments : null,
'i' => isset($issue) ? $issue : null,
'c' => $show_comments ?? null,
'i' => $issue ?? null,
];
}
}