Fix coding style missed by phpbcf (#2901)

$ composer require --dev friendsofphp/php-cs-fixer

$ echo >.php-cs-fixer.dist.php "<?php

$finder = PhpCsFixer\Finder::create()
    ->in(__DIR__);

$rules = [
    '@PSR12' => true,
    // '@PSR12:risky' => true,
    '@PHP74Migration' => true,
    // '@PHP74Migration:risky' => true,
    // buggy, duplicates existing comment sometimes
    'no_break_comment' => false,
    'array_syntax' => true,
    'lowercase_static_reference' => true,
    'visibility_required' => false,
    // Too much noise
    'binary_operator_spaces' => false,
    'heredoc_indentation' => false,
    'trailing_comma_in_multiline' => false,
];

$config = new PhpCsFixer\Config();

return $config
    ->setRules($rules)
    // ->setRiskyAllowed(true)
    ->setFinder($finder);

"

$ vendor/bin/php-cs-fixer --version
PHP CS Fixer 3.8.0 BerSzcz against war! by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.7

$ vendor/bin/php-cs-fixer fix
$ rm .php-cs-fixer.cache
$ vendor/bin/php-cs-fixer fix

lib/BridgeAbstract.php

@@ -162,7 +162,7 @@ abstract class BridgeAbstract implements BridgeInterface
                     continue;
                 }
 
-                $type = isset($properties['type']) ? $properties['type'] : 'text';
+                $type = $properties['type'] ?? 'text';
 
                 switch ($type) {
                     case 'checkbox':

lib/Debug.php

@@ -114,7 +114,7 @@ class Debug
         $calling = end($backtrace);
         $message = $calling['file'] . ':'
             . $calling['line'] . ' class '
-            . (isset($calling['class']) ? $calling['class'] : '<no-class>') . '->'
+            . ($calling['class'] ?? '<no-class>') . '->'
             . $calling['function'] . ' - '
             . $text;
 

lib/Exceptions.php

@@ -77,7 +77,7 @@ function buildBridgeException(\Throwable $e, BridgeInterface $bridge): string
     $body = 'Error message: `'
     . $e->getMessage()
     . "`\nQuery string: `"
-    . (isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : '')
+    . ($_SERVER['QUERY_STRING'] ?? '')
     . "`\nVersion: `"
     . Configuration::getVersion()
     . '`';
@@ -105,7 +105,7 @@ function buildTransformException(\Throwable $e, BridgeInterface $bridge): string
     $body = 'Error message: `'
     . $e->getMessage()
     . "`\nQuery string: `"
-    . (isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : '')
+    . ($_SERVER['QUERY_STRING'] ?? '')
     . '`';
 
     $link = buildGitHubIssueQuery($title, $body, 'Bridge-Broken', $bridge->getMaintainer());

lib/FeedExpander.php

@@ -405,7 +405,8 @@ abstract class FeedExpander extends BridgeAbstract
             foreach ($feedItem->guid->attributes() as $attribute => $value) {
                 if (
                     $attribute === 'isPermaLink'
-                    && ($value === 'true' || (
+                    && (
+                        $value === 'true' || (
                             filter_var($feedItem->guid, FILTER_VALIDATE_URL)
                             && (empty($item['uri']) || !filter_var($item['uri'], FILTER_VALIDATE_URL))
                         )
@@ -430,7 +431,7 @@ abstract class FeedExpander extends BridgeAbstract
         } elseif (isset($dc->creator)) {
             $item['author'] = (string)$dc->creator;
         } elseif (isset($media->credit)) {
-                $item['author'] = (string)$media->credit;
+            $item['author'] = (string)$media->credit;
         }
 
         if (isset($feedItem->enclosure) && !empty($feedItem->enclosure['url'])) {

lib/html.php

@@ -140,7 +140,8 @@ function extractFromDelimiters($string, $start, $end)
         $section_retrieved = substr($string, strpos($string, $start) + strlen($start));
         $section_retrieved = substr($section_retrieved, 0, strpos($section_retrieved, $end));
         return $section_retrieved;
-    } return false;
+    }
+    return false;
 }
 
 /**