mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-27 10:04:53 +02:00
Code Issues Releases Wiki Activity

bridges: Fix default return values and function scopes

Browse Source 
getURI and getName should fall back to parent::getURI or
parent::getName respectively if it cannot build propper
return values.

Functions defined by bridges should be made private to
prevent confusion with inherited functions
This commit is contained in:
logmanoriginal
2016-12-17 16:39:18 +01:00
parent 271c71d0ac
commit 95b99d42a4
6 changed files with 34 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bridges/LeMondeInformatiqueBridge.php
View File

@@ -20,13 +20,13 @@ class LeMondeInformatiqueBridge extends FeedExpander {
return $item;
}
function StripCDATA($string) {
private function StripCDATA($string) {
$string = str_replace('<![CDATA[', '', $string);
$string = str_replace(']]>', '', $string);
return $string;
}
function StripWithDelimiters($string, $start, $end) {
private function StripWithDelimiters($string, $start, $end) {
while (strpos($string, $start) !== false) {
$section_to_remove = substr($string, strpos($string, $start));
$section_to_remove = substr($section_to_remove, 0, strpos($section_to_remove, $end) + strlen($end));
@@ -34,7 +34,7 @@ class LeMondeInformatiqueBridge extends FeedExpander {
} return $string;
}
function CleanArticle($article_html) {
private function CleanArticle($article_html) {
$article_html = $this->StripWithDelimiters($article_html, '<script', '</script>');
$article_html = $this->StripWithDelimiters($article_html, '<h1 class="cleanprint-title"', '</h1>');
return $article_html;