mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-10-28 05:36:51 +01:00
Code Issues Releases Wiki Activity

[GolemBridge] Fix multiple YouTube embeds

Browse Source 
The following test article revealed that the previous code always takes
the first youtube link on all YouTube embed spaces:
https://www.golem.de/news/free-to-play-kostenlos-skaten-ballern-und-klicken-2510-201000.html

This command changes it to opportunistically select the i-th youtube
embed link for the i-th placeholder. This might fail and produce wrong
orderings, but should be better than the previous code. The above test
article is at least completely correct.
This commit is contained in:
Mynacol
2025-10-24 12:25:00 +00:00
parent ca8a17c570
commit 9bfc5687e8
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
bridges/GolemBridge.php
View File

@@ -116,11 +116,12 @@ class GolemBridge extends FeedExpander
$article = $page->find('article', 0); $article = $page->find('article', 0);
//built youtube iframes //built youtube iframes
foreach ($article->find('.go-embed-container') as &$embedcontent) { $placeholders = $article->find('.go-embed-container');
foreach (range(0, count($placeholders) - 1) as $i) {
foreach ($page->find('script') as $ytscript) { foreach ($page->find('script') as $ytscript) {
if (preg_match('/(www.youtube.com.*?)\"/', $ytscript->innertext, $link)) { if (preg_match_all('/(www.youtube.com.*?)\"/', $ytscript->innertext, $link)) {
$link = 'https://' . str_replace('\\', '', $link[1]); $link = 'https://' . str_replace('\\', '', $link[1][$i]);
$embedcontent->innertext .= <<<EOT $placeholders[$i]->innertext .= <<<EOT
<iframe width="560" height="315" src="$link" title="YouTube video player" frameborder="0" <iframe width="560" height="315" src="$link" title="YouTube video player" frameborder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>'; referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>';