1
0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-09 10:06:33 +02:00

[phpcs] Add missing rules

- Do not add spaces after opening or before closing parenthesis

  // Wrong
  if( !is_null($var) ) {
    ...
  }

  // Right
  if(!is_null($var)) {
    ...
  }

- Add space after closing parenthesis

  // Wrong
  if(true){
    ...
  }

  // Right
  if(true) {
    ...
  }

- Add body into new line
- Close body in new line

  // Wrong
  if(true) { ... }

  // Right
  if(true) {
    ...
  }

Notice: Spaces after keywords are not detected:

  // Wrong (not detected)
  // -> space after 'if' and missing space after 'else'
  if (true) {
    ...
  } else{
    ...
  }

  // Right
  if(true) {
    ...
  } else {
    ...
  }
This commit is contained in:
logmanoriginal
2017-07-29 19:28:00 +02:00
parent 38b56bf23a
commit a4b9611e66
128 changed files with 692 additions and 694 deletions

View File

@@ -66,18 +66,18 @@ class KernelBugTrackerBridge extends BridgeAbstract {
// Get and limit comments
$comments = $html->find('div.bz_comment');
if($limit > 0 && count($comments) > $limit){
if($limit > 0 && count($comments) > $limit) {
$comments = array_slice($comments, count($comments) - $limit, $limit);
}
// Order comments
switch($sorting){
switch($sorting) {
case 'lf': $comments = array_reverse($comments, true);
case 'of':
default: // Nothing to do, keep original order
}
foreach($comments as $comment){
foreach($comments as $comment) {
$comment = $this->inlineStyles($comment);
$item = array();
@@ -99,7 +99,7 @@ class KernelBugTrackerBridge extends BridgeAbstract {
}
public function getURI(){
switch($this->queriedContext){
switch($this->queriedContext) {
case 'Bug comments':
return parent::getURI()
. '/show_bug.cgi?id='
@@ -110,7 +110,7 @@ class KernelBugTrackerBridge extends BridgeAbstract {
}
public function getName(){
switch($this->queriedContext){
switch($this->queriedContext) {
case 'Bug comments':
return 'Bug '
. $this->bugid
@@ -142,7 +142,7 @@ class KernelBugTrackerBridge extends BridgeAbstract {
* attributes.
*/
private function inlineStyles($html){
foreach($html->find('.bz_obsolete') as $element){
foreach($html->find('.bz_obsolete') as $element) {
$element->style = 'text-decoration:line-through;';
}