From ab6aca31639d919216465770e845597d4153ca27 Mon Sep 17 00:00:00 2001
From: Jan Tojnar <jtojnar@gmail.com>
Date: Tue, 5 Jul 2022 16:39:44 +0200
Subject: [PATCH] lib/Configuration: Remove redundant comment
It was just getting out of sync:
- Minimum PHP version was bumped in 8365a7a34dea6750fab4c29541ec1801cdbc83e4
- Cache directory permission check was removed in 8e2b65556f0a5eb063761d594f2fd6ac1b10d154
- Whitelist permission check was removed in d4e867f2403c6224c93d8588fadbde600aec4444
---
lib/Configuration.php | 30 ++++++++++--------------------
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/lib/Configuration.php b/lib/Configuration.php
index ce01b7df..2680ce3e 100644
--- a/lib/Configuration.php
+++ b/lib/Configuration.php
@@ -57,55 +57,45 @@ final class Configuration
* Returns an error message and aborts execution if the installation does
* not satisfy the requirements of RSS-Bridge.
*
- * **Requirements**
- * - PHP 7.1.0 or higher
- * - `openssl` extension
- * - `libxml` extension
- * - `mbstring` extension
- * - `simplexml` extension
- * - `curl` extension
- * - `json` extension
- * - The cache folder specified by {@see PATH_CACHE} requires write permission
- * - The whitelist file specified by {@see WHITELIST} requires write permission
- *
- * @link http://php.net/supported-versions.php PHP Supported Versions
- * @link http://php.net/manual/en/book.openssl.php OpenSSL
- * @link http://php.net/manual/en/book.libxml.php libxml
- * @link http://php.net/manual/en/book.mbstring.php Multibyte String (mbstring)
- * @link http://php.net/manual/en/book.simplexml.php SimpleXML
- * @link http://php.net/manual/en/book.curl.php Client URL Library (curl)
- * @link http://php.net/manual/en/book.json.php JavaScript Object Notation (json)
- *
* @return void
*/
public static function verifyInstallation()
{
// Check PHP version
+ // PHP Supported Versions: https://www.php.net/supported-versions.php
if (version_compare(PHP_VERSION, '7.4.0') === -1) {
self::reportError('RSS-Bridge requires at least PHP version 7.4.0!');
}
- // extensions check
+
+ // Extensions check
+
+ // OpenSSL: https://www.php.net/manual/en/book.openssl.php
if (!extension_loaded('openssl')) {
self::reportError('"openssl" extension not loaded. Please check "php.ini"');
}
+ // libxml: https://www.php.net/manual/en/book.libxml.php
if (!extension_loaded('libxml')) {
self::reportError('"libxml" extension not loaded. Please check "php.ini"');
}
+ // Multibyte String (mbstring): https://www.php.net/manual/en/book.mbstring.php
if (!extension_loaded('mbstring')) {
self::reportError('"mbstring" extension not loaded. Please check "php.ini"');
}
+ // SimpleXML: https://www.php.net/manual/en/book.simplexml.php
if (!extension_loaded('simplexml')) {
self::reportError('"simplexml" extension not loaded. Please check "php.ini"');
}
+ // Client URL Library (curl): https://www.php.net/manual/en/book.curl.php
// Allow RSS-Bridge to run without curl module in CLI mode without root certificates
if (!extension_loaded('curl') && !(php_sapi_name() === 'cli' && empty(ini_get('curl.cainfo')))) {
self::reportError('"curl" extension not loaded. Please check "php.ini"');
}
+ // JavaScript Object Notation (json): https://www.php.net/manual/en/book.json.php
if (!extension_loaded('json')) {
self::reportError('"json" extension not loaded. Please check "php.ini"');
}