mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-12 19:44:12 +02:00
Code Issues Releases Wiki Activity

refactor: dont create multiple instances of the cache (#3504)

Browse Source
This commit is contained in:
Dag
2023-07-08 17:03:12 +02:00
committed by GitHub
parent b594ad2de3
commit c1c8304fc0
10 changed files with 34 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
actions/DisplayAction.php
View File

@@ -87,9 +87,7 @@ class DisplayAction implements ActionInterface
)
);
$cacheFactory = new CacheFactory();
$cache = $cacheFactory->create();
$cache = RssBridge::getCache();
$cache->setScope('');
$cache->setKey($cache_params);
// This cache purge will basically delete all cache items older than 24h, regardless of scope and key
@@ -166,6 +164,9 @@ class DisplayAction implements ActionInterface
}
}
// Unfortunately need to set scope and key again because they might be modified
$cache->setScope('');
$cache->setKey($cache_params);
$cache->saveData([
'items' => array_map(function (FeedItem $item) {
return $item->toArray();
@@ -212,8 +213,7 @@ class DisplayAction implements ActionInterface
private static function logBridgeError($bridgeName, $code)
{
$cacheFactory = new CacheFactory();
$cache = $cacheFactory->create();
$cache = RssBridge::getCache();
$cache->setScope('error_reporting');
$cache->setkey([$bridgeName . '_' . $code]);

4
actions/SetBridgeCacheAction.php
View File

@@ -35,9 +35,7 @@ class SetBridgeCacheAction implements ActionInterface
$bridge->loadConfiguration();
$value = $request['value'];
$cacheFactory = new CacheFactory();
$cache = $cacheFactory->create();
$cache = RssBridge::getCache();
$cache->setScope(get_class($bridge));
if (!is_array($key)) {
// not sure if $key is an array when it comes in from request