mirror/php-rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-08-24 00:53:10 +02:00
Code Issues Releases Wiki Activity

[ParameterValidator] Refactor 'validation' into 'ParameterValidator'

Browse Source 
Adds a new class 'ParameterValidator' to replace the functions from
'validator.php', separating private functions from 'validateData' to
class private functions in the process.

Instead of echoing error messages, adds messages to a private variable,
accessible via 'getInvalidParameters'.

BridgeAbstract now adds invalid parameter names to the error message.
This commit is contained in:
logmanoriginal
2018-09-22 16:42:04 +02:00
parent e3a5a6a170
commit f853ffc07c
4 changed files with 136 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/BridgeAbstract.php
View File

@@ -195,8 +195,18 @@ abstract class BridgeAbstract implements BridgeInterface {
return;
}
if(!validateData($inputs, static::PARAMETERS)) {
returnClientError('Invalid parameters value(s)');
$validator = new ParameterValidator();
if(!$validator->validateData($inputs, static::PARAMETERS)) {
$parameters = array_map(
function($i){ return $i['name']; }, // Just display parameter names
$validator->getInvalidParameters()
);
returnClientError(
'Invalid parameters value(s): '
. implode(', ', $parameters)
);
}
// Guess the paramter context from input data