From 18484fdfcb18568fe7d5dd9ce9ebb141dbd5eb25 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Thu, 26 Oct 2017 10:36:23 +0530 Subject: [PATCH] prevent double console logs in detached mode. fixes #223 --- src/script.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/script.js b/src/script.js index d314787..1825ae1 100644 --- a/src/script.js +++ b/src/script.js @@ -1090,6 +1090,8 @@ globalConsoleContainerEl js: scope.cm.js.getValue() }; utils.log('🔎 setPreviewContent', isForced); + const targetFrame = scope.detachedWindow ? scope.detachedWindow : frame; + // If just CSS was changed (and everything shudn't be empty), // change the styles inside the iframe. if ( @@ -1098,8 +1100,8 @@ globalConsoleContainerEl currentCode.js === codeInPreview.js ) { computeCss().then(function(css) { - if (frame.contentDocument.querySelector('#webmakerstyle')) { - frame.contentDocument.querySelector( + if (targetFrame.contentDocument.querySelector('#webmakerstyle')) { + targetFrame.contentDocument.querySelector( '#webmakerstyle' ).textContent = css; } @@ -1903,6 +1905,8 @@ globalConsoleContainerEl document.body.classList.remove('is-detached-mode'); $('#js-demo-side').insertBefore(consoleEl, null); scope.detachedWindow = null; + // Update main frame preview + scope.setPreviewContent(true); } } var intervalID = window.setInterval(checkWindow, 500);