From 30afda75f35f7f842406a98ed38fcf9128d9c734 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 1 Mar 2019 16:18:11 +0530 Subject: [PATCH] change componentWillUpdate to componentDidUpdate --- src/components/Console.jsx | 9 ++++++--- src/components/ContentWrapFiles.jsx | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/components/Console.jsx b/src/components/Console.jsx index 5ad9e2c..45cf78f 100644 --- a/src/components/Console.jsx +++ b/src/components/Console.jsx @@ -24,14 +24,15 @@ class LogRow extends Component { } export class Console extends PureComponent { - componentWillUpdate(nextProps) { - if (nextProps.logs != this.props.logs) { + componentDidUpdate(previousProps) { + if (this.props.logs !== previousProps.logs) { // Scroll down after new log dom is inserted setTimeout(() => { this.logContainerEl.scrollTop = this.logContainerEl.scrollHeight; }, 1); } } + render() { const { logs, @@ -79,7 +80,9 @@ export class Console extends PureComponent { this.logContainerEl = el; }} > - {logs.map(log => )} + {logs.map(log => ( + + ))}