From 52213cdf18bc11bcf5e349ef11b4aaf7fc21cfe2 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Wed, 18 Jan 2017 02:59:55 +0530 Subject: [PATCH] eslint fixes..oke bro --- .eslintrc.json | 2 ++ src/index.html | 4 ++-- src/script.js | 22 ++++++++++++---------- 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 0119c1e..bd2bad0 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -255,8 +255,10 @@ "$all": true, "CoffeeScript": true, "Babel": true, + "ts": true, "Sass": true, "less": true, + "stylus": true, "marked": true, "jade": true, "loadJS": true, diff --git a/src/index.html b/src/index.html index baa04cb..c88189f 100644 --- a/src/index.html +++ b/src/index.html @@ -238,7 +238,7 @@

-
+
Show in new tab
-
+
diff --git a/src/script.js b/src/script.js index d62fbd3..546eb46 100644 --- a/src/script.js +++ b/src/script.js @@ -3,7 +3,7 @@ onboardModal, layoutBtn1, layoutBtn2, layoutBtn3, helpBtn, onboardModal, onboardModal, addLibraryModal, addLibraryModal, notificationsBtn, notificationsModal, notificationsModal, notificationsModal, notificationsBtn, codepenBtn, saveHtmlBtn, openBtn, saveBtn, newBtn, -settingsBtn, onboardModal, notificationsBtn */ +settingsBtn, onboardModal, notificationsBtn, onboardShowInTabOptionBtn, onboardDontShowInTabOptionBtn */ /* eslint-disable no-extra-semi */ ;(function (alertsService) { @@ -478,7 +478,7 @@ settingsBtn, onboardModal, notificationsBtn */ // Last line of message is the actual message var tempArr = error.message.split('\n'); tempArr.pop(); // This is empty string in the end - showErrors('css', [ { lineNumber: +error.message.match(/stylus:(\d+):/)[1]-298, message: tempArr.pop() } ]); + showErrors('css', [ { lineNumber: +error.message.match(/stylus:(\d+):/)[1] - 298, message: tempArr.pop() } ]); } d.resolve(result); }); @@ -536,9 +536,11 @@ settingsBtn, onboardModal, notificationsBtn */ } } else if (jsMode === JsModes.TS) { try { - code = ts.transpileModule(code, { reportDiagnostics:true, compilerOptions: { noEmitOnError: true, diagnostics:true, module: ts.ModuleKind.ES2015 } }); + code = ts.transpileModule(code, { reportDiagnostics: true, compilerOptions: { noEmitOnError: true, diagnostics: true, module: ts.ModuleKind.ES2015 } }); if (code.diagnostics.length) { - throw({ description: code.diagnostics[0].messageText, lineNumber: ts.getLineOfLocalPosition(code.diagnostics[0].file,code.diagnostics[0].start) }); + + /* eslint-disable no-throw-literal */ + throw ({ description: code.diagnostics[0].messageText, lineNumber: ts.getLineOfLocalPosition(code.diagnostics[0].file,code.diagnostics[0].start) }); } } catch (e) { showErrors('js', [ { lineNumber: e.lineNumber - 1, message: e.description } ]); @@ -732,13 +734,13 @@ settingsBtn, onboardModal, notificationsBtn */ } scope.onShowInTabClicked = function () { - onboardDontShowInTabOption.classList.remove('selected'); - onboardShowInTabOption.classList.add('selected'); + onboardDontShowInTabOptionBtn.classList.remove('selected'); + onboardShowInTabOptionBtn.classList.add('selected'); trackEvent('ui', 'onboardShowInTabClick'); } scope.onDontShowInTabClicked = function () { - onboardDontShowInTabOption.classList.add('selected'); - onboardShowInTabOption.classList.remove('selected'); + onboardDontShowInTabOptionBtn.classList.add('selected'); + onboardShowInTabOptionBtn.classList.remove('selected'); trackEvent('ui', 'onboardDontShowInTabClick'); } @@ -999,9 +1001,9 @@ settingsBtn, onboardModal, notificationsBtn */ }, function () {}); chrome.storage.sync.set({ - replaceNewTab: onboardShowInTabOption.classList.contains('selected') + replaceNewTab: onboardShowInTabOptionBtn.classList.contains('selected') }, function () { - trackEvent('fn', 'setReplaceNewTabFromOnboard', onboardShowInTabOption.classList.contains('selected')); + trackEvent('fn', 'setReplaceNewTabFromOnboard', onboardShowInTabOptionBtn.classList.contains('selected')); }); }); }