mirror/php-web-maker
1
0
Fork 0
mirror of https://github.com/chinchang/web-maker.git synced 2025-06-20 06:29:18 +02:00
Code Issues Releases Wiki Activity

Fix showErrors() method of CodeEditor component

Browse Source 
- This was causing WebMaker to throw the following error whenever the
showErrors() method was called, preventing the desired behavior of showing
the errors in the CodeMirror gutter:

	Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'instance')
This commit is contained in:
Nick Hogle
2023-10-11 15:26:52 -07:00
parent bf986ce7da
commit 5952919396
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/CodeEditor.jsx
View File

@ -187,8 +187,9 @@ export default class CodeEditor extends Component {
showErrors(errors) { showErrors(errors) {
if (this.props.type === 'codemirror') { if (this.props.type === 'codemirror') {
const editor = this.instance;
errors.forEach(function (error) { errors.forEach(function (error) {
this.instance.operation(function() { editor.operation(function () {
var n = document.createElement('div'); var n = document.createElement('div');
n.setAttribute('data-title', error.message); n.setAttribute('data-title', error.message);
n.classList.add('gutter-error-marker'); n.classList.add('gutter-error-marker');
@ -235,11 +236,11 @@ export default class CodeEditor extends Component {
if (!monacoDepsDeferred) { if (!monacoDepsDeferred) {
monacoDepsDeferred = deferred(); monacoDepsDeferred = deferred();
loadCss({ url: 'lib/monaco/monaco.css', id: 'monaco-css' }); loadCss({ url: 'lib/monaco/monaco.css', id: 'monaco-css' });
import(/* webpackChunkName: "monaco" */ '../lib/monaco/monaco.bundle.js').then( import(
() => { /* webpackChunkName: "monaco" */ '../lib/monaco/monaco.bundle.js'
).then(() => {
monacoDepsDeferred.resolve(); monacoDepsDeferred.resolve();
} });
);
} }
return monacoDepsDeferred.promise; return monacoDepsDeferred.promise;
} }