From 7699d213d15789fb657ded44791ad198402578d1 Mon Sep 17 00:00:00 2001 From: Andrew Luca Date: Wed, 27 Dec 2017 00:56:10 +0200 Subject: [PATCH] Remove some duplciate code Eslint complexity drops from 27 to 25 --- src/script.js | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/src/script.js b/src/script.js index aa48bf0..050e0c0 100644 --- a/src/script.js +++ b/src/script.js @@ -2174,30 +2174,18 @@ globalConsoleContainerEl, externalLibrarySearchInput, keyboardShortcutsModal closeAllOverlays(); } - if (ARROW_DOWN && isSavedItemsPaneOpen) { + if (isSavedItemsPaneOpen && (ARROW_DOWN || ARROW_UP)) { // Return if no items present. if (!$all('.js-saved-item-tile').length) { return; } + + const method = ARROW_DOWN ? 'nextUntil' : 'previousUntil' + selectedItemElement = $('.js-saved-item-tile.selected'); if (selectedItemElement) { selectedItemElement.classList.remove('selected'); - selectedItemElement - .nextUntil('.js-saved-item-tile:not(.hide)') - .classList.add('selected'); - } else { - $('.js-saved-item-tile:not(.hide)').classList.add('selected'); - } - $('.js-saved-item-tile.selected').scrollIntoView(false); - } else if (ARROW_UP && isSavedItemsPaneOpen) { - if (!$all('.js-saved-item-tile').length) { - return; - } - selectedItemElement = $('.js-saved-item-tile.selected'); - if (selectedItemElement) { - selectedItemElement.classList.remove('selected'); - selectedItemElement - .previousUntil('.js-saved-item-tile:not(.hide)') + selectedItemElement[method]('.js-saved-item-tile:not(.hide)') .classList.add('selected'); } else { $('.js-saved-item-tile:not(.hide)').classList.add('selected');