mirror/php-web-maker
1
0
Fork 0
mirror of https://github.com/chinchang/web-maker.git synced 2025-08-02 11:30:22 +02:00
Code Issues Releases Wiki Activity

SplitPane: fix retaining both width/height on pane bug

Browse Source
This commit is contained in:
Kushagra Gour
2018-11-30 10:51:11 +05:30
parent 45bf3a0bfb
commit 932bbe43dc
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/SplitPane.jsx
View File

@@ -5,7 +5,11 @@ export class SplitPane extends Component {
componentDidMount() { componentDidMount() {
this.updateSplit(); this.updateSplit();
} }
componentWillUpdate() {
if (this.splitInstance) {
this.splitInstance.destroy();
}
}
componentDidUpdate(prevProps) { componentDidUpdate(prevProps) {
if (this.hasGutter() && !this.hasPropsChanged(prevProps, this.props)) { if (this.hasGutter() && !this.hasPropsChanged(prevProps, this.props)) {
return; return;
@@ -33,13 +37,8 @@ export class SplitPane extends Component {
const { children, ...options } = this.props; const { children, ...options } = this.props;
options.gutterSize = 6; options.gutterSize = 6;
if (this.splitInstance && this.hasGutter()) {
this.splitInstance.destroy();
}
/* eslint-disable new-cap */ /* eslint-disable new-cap */
this.splitInstance = Split([...this.parent.children], options); this.splitInstance = Split([...this.parent.children], options);
console.log('recreating split');
/* eslint-enable new-cap */ /* eslint-enable new-cap */