From b8cee4b22a4725981d744acc4226c991b5cc07ff Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 2 Dec 2016 10:33:11 +0530 Subject: [PATCH] tracking fixes. --- src/analytics.js | 2 +- src/script.js | 20 ++++++++++++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/analytics.js b/src/analytics.js index 12215b6..5bfefcd 100644 --- a/src/analytics.js +++ b/src/analytics.js @@ -4,7 +4,7 @@ window.trackEvent = function (category, action, label, value) { } } -// if online, load after 2 seconds +// if online, load after sometime if (navigator.onLine) { setTimeout(function() { (function(i,s,o,g,r,a,m){ diff --git a/src/script.js b/src/script.js index b6968b7..99b9e50 100644 --- a/src/script.js +++ b/src/script.js @@ -115,7 +115,6 @@ document.body.classList.add('layout-' + mode); resetSplitting(); - trackEvent('ui', 'toggleLayout', mode); } function saveSetting(setting, value) { @@ -250,6 +249,11 @@ function createPreviewFile(html, css, js) { var contents = '\n\n\n\n\n' + html + '\n\n'; + // Track if people are actually writing code. + if (!trackEvent.hasTrackedCode && (html || css || js)) { + trackEvent('fn', 'hasCode'); + trackEvent.hasTrackedCode = true; + } var fileWritten = false; var blob = new Blob([ contents ], { type: "text/plain;charset=UTF-8" }); @@ -354,9 +358,17 @@ CodeMirror.modeURL = "lib/codemirror/mode/%N/%N.js"; - layoutBtn1.addEventListener('click', function () { saveSetting('layoutMode', 1); toggleLayout(1); return false; }); - layoutBtn2.addEventListener('click', function () { saveSetting('layoutMode', 2); toggleLayout(2); return false; }); - layoutBtn3.addEventListener('click', function () { saveSetting('layoutMode', 3); toggleLayout(3); return false; }); + function getToggleLayoutButtonListener(mode) { + return function () { + saveSetting('layoutMode', mode); + trackEvent('ui', 'toggleLayoutClick', mode); + toggleLayout(mode); + return false; + }; + } + layoutBtn1.addEventListener('click', getToggleLayoutButtonListener(1)); + layoutBtn2.addEventListener('click', getToggleLayoutButtonListener(2)); + layoutBtn3.addEventListener('click', getToggleLayoutButtonListener(3)); helpBtn.addEventListener('click', function () { helpModal.classList.toggle('is-modal-visible');