From ba3775d3ee7f5643fce6c31147642d5f14bf5344 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Mon, 5 Dec 2016 10:40:21 +0530 Subject: [PATCH] add ctrl+o and ask confirmation before removing. --- src/index.html | 5 +++-- src/script.js | 27 ++++++++++++++++++++++----- 2 files changed, 25 insertions(+), 7 deletions(-) diff --git a/src/index.html b/src/index.html index 211b1bf..0d56c50 100644 --- a/src/index.html +++ b/src/index.html @@ -374,7 +374,7 @@ transform: translateX(100%); } .saved-items-pane.is-open { - transition-duration: 0.45s; + transition-duration: 0.4s; transform: translateX(0); } .is-modal-visible ~ .modal-overlay, @@ -448,6 +448,7 @@ position: absolute; right: 8px; top: 6px; + z-index: 1; color: rgba(255,255,255,0.3); border-radius: 50%; background: rgba(255,255,255,0.05); @@ -646,7 +647,7 @@ Open - +
diff --git a/src/script.js b/src/script.js index e4dd0ee..3970df6 100644 --- a/src/script.js +++ b/src/script.js @@ -318,6 +318,9 @@ } function removeItem(itemId) { var itemTile = document.querySelector('.js-saved-item-tile[data-item-id="' + itemId + '"]'); + var answer = confirm(`Are you sure you want to delete "${savedItems[itemId].title}"?`); + if (!answer) { return; } + itemTile.remove(); // Remove from items list chrome.storage.local.get({ @@ -774,20 +777,34 @@ }); + function closeAllOverlays() { + helpModal.classList.remove('is-modal-visible'); + notificationsModal.classList.remove('is-modal-visible'); + addLibraryModal.classList.remove('is-modal-visible'); + toggleSavedItemsPane(false); + } + window.addEventListener('keydown', function (event) { - if ((event.ctrlKey || event.metaKey) && (event.keyCode === 83)){ + // Implement Ctrl + S + if ((event.ctrlKey || event.metaKey) && (event.keyCode === 83)) { event.preventDefault(); saveFile(); trackEvent('ui', 'saveFileKeyboardShortcut'); } + // Implement Ctrl + O + else if ((event.ctrlKey || event.metaKey) && (event.keyCode === 79)) { + event.preventDefault(); + openSavedItemsPane(); + trackEvent('ui', 'openCreationKeyboardShortcut'); + } + else if (event.keyCode === 27) { + closeAllOverlays(); + } }); window.addEventListener('click', function(e) { if (typeof e.target.className === 'string' && e.target.className.indexOf('modal-overlay') !== -1) { - helpModal.classList.remove('is-modal-visible'); - notificationsModal.classList.remove('is-modal-visible'); - addLibraryModal.classList.remove('is-modal-visible'); - toggleSavedItemsPane(false); + closeAllOverlays(); } }); window.addEventListener('dblclick', function(e) {