From de3dc48aee781537a083c3e8e2cca0db9479f154 Mon Sep 17 00:00:00 2001 From: Matt Price Date: Thu, 13 Dec 2018 14:52:33 -0500 Subject: [PATCH 1/2] add test for development version before setting `BASE_PATH` This change should make it possible to run web-maker in dev mode with no problems. --- src/utils.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/utils.js b/src/utils.js index ba6c662..8d7c26f 100644 --- a/src/utils.js +++ b/src/utils.js @@ -15,7 +15,12 @@ window.chrome.i18n = { window.$all = selector => [...document.querySelectorAll(selector)]; window.IS_EXTENSION = !!window.chrome.extension; -export const BASE_PATH = window.chrome.extension || window.DEBUG ? '/' : '/app'; +export const BASE_PATH = + window.chrome.extension || + window.DEBUG || + process.env.NODE_ENV == 'development' + ? '/' + : '/app'; var alphaNum = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'; From 5bf9fbd7e73b3324f12a2ce1fe2d70d937f299b8 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 14 Dec 2018 12:19:10 +0530 Subject: [PATCH 2/2] Use strict equality --- src/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils.js b/src/utils.js index 8d7c26f..089f7a9 100644 --- a/src/utils.js +++ b/src/utils.js @@ -18,7 +18,7 @@ window.IS_EXTENSION = !!window.chrome.extension; export const BASE_PATH = window.chrome.extension || window.DEBUG || - process.env.NODE_ENV == 'development' + process.env.NODE_ENV === 'development' ? '/' : '/app';