From 977f71e16937c14c6117dd00fd0c390987c0c0c5 Mon Sep 17 00:00:00 2001 From: Basit Ali Date: Sat, 12 Aug 2017 00:46:58 +0500 Subject: [PATCH 01/14] Ability to configure whether to preserve console logs on preview refresh or not. --- src/index.html | 3 +++ src/script.js | 9 ++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/index.html b/src/index.html index f507c84..b5ecd6e 100644 --- a/src/index.html +++ b/src/index.html @@ -455,6 +455,9 @@ +

diff --git a/src/script.js b/src/script.js index 60ca0af..f9eaede 100644 --- a/src/script.js +++ b/src/script.js @@ -1042,6 +1042,10 @@ customEditorFontInput } scope.setPreviewContent = function(isForced) { + if( !prefs.preserveConsoleLogs ) { + scope.clearConsole(); + } + var currentCode = { html: scope.cm.html.getValue(), css: scope.cm.css.getValue(), @@ -1588,6 +1592,7 @@ customEditorFontInput $('[data-setting=editorCustomFont]').value = prefs.editorCustomFont; $('[data-setting=autoSave]').checked = prefs.autoSave; $('[data-setting=autoComplete]').checked = prefs.autoComplete; + $('[data-setting=preserveConsoleLogs]').checked = prefs.preserveConsoleLogs; } /** @@ -2154,7 +2159,8 @@ customEditorFontInput editorFont: 'FiraCode', editorCustomFont: '', autoSave: true, - autoComplete: true + autoComplete: true, + preserveConsoleLogs: true }, function syncGetCallback(result) { if (result.preserveLastCode && lastCode) { @@ -2190,6 +2196,7 @@ customEditorFontInput prefs.editorCustomFont = result.editorCustomFont; prefs.autoSave = result.autoSave; prefs.autoComplete = result.autoComplete; + prefs.preserveConsoleLogs = result.preserveConsoleLogs; updateSettingsInUi(); scope.updateSetting(); From 935cab53147405769a204850ec6a1df84a16e1f8 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 1 Sep 2017 09:42:00 +0530 Subject: [PATCH 02/14] set onboardmodal event as soon as the modal is seen --- src/script.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/script.js b/src/script.js index 60ca0af..fdaf18c 100644 --- a/src/script.js +++ b/src/script.js @@ -2206,15 +2206,14 @@ customEditorFontInput if (!result.lastSeenVersion) { onboardModal.classList.add('is-modal-visible'); trackEvent('ui', 'onboardModalSeen'); - // set the current version as seen on closing the onboard modal + chrome.storage.sync.set( + { + lastSeenVersion: version + }, + function() {} + ); + // set some initial preferences on closing the onboard modal utils.once(document, 'overlaysClosed', function() { - chrome.storage.sync.set( - { - lastSeenVersion: version - }, - function() {} - ); - chrome.storage.sync.set( { replaceNewTab: onboardShowInTabOptionBtn.classList.contains( From aa1108919e1facaf9ab0e3361bc3190e36571115 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 1 Sep 2017 09:48:26 +0530 Subject: [PATCH 03/14] add charset utf8 in preview html. fixes #173 --- src/script.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/script.js b/src/script.js index fdaf18c..058a6a3 100644 --- a/src/script.js +++ b/src/script.js @@ -924,6 +924,7 @@ customEditorFontInput }, ''); var contents = '\n\n' + + '\n' + externalCss + '\n' + '