mirror/php-web-maker
1
0
Fork 0
mirror of https://github.com/chinchang/web-maker.git synced 2025-08-01 19:10:22 +02:00
Code Issues Releases Wiki Activity

Fix issue 546: Tab key not working in JS editor when using CodeMirror

Browse Source 
- The check for the Emmet option was short-circuiting the logic for
inserting a Tab.  Note that the emmet option is only enabled on HTML and
CSS editors, (and not the JS editor), which is why the `Tab` key works in
those editors, but not the JS editor.
This commit is contained in:
Nick Hogle
2023-10-11 16:19:45 -07:00
parent bf986ce7da
commit d6e7cd3a8e
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/components/CodeEditor.jsx
View File

@@ -344,18 +344,18 @@ export default class CodeEditor extends Component {
if (didEmmetWork === true) { if (didEmmetWork === true) {
return; return;
} }
const input = $('[data-setting=indentWith]:checked'); }
if ( const input = $('[data-setting=indentWith]:checked');
!editor.somethingSelected() && if (
(!prefs.indentWith || prefs.indentWith === 'spaces') !editor.somethingSelected() &&
) { (!prefs.indentWith || prefs.indentWith === 'spaces')
// softtabs adds spaces. This is required because by default tab key will put tab, but we want ) {
// to indent with spaces if `spaces` is preferred mode of indentation. // softtabs adds spaces. This is required because by default tab key will put tab, but we want
// `somethingSelected` needs to be checked otherwise, all selected code is replaced with softtab. // to indent with spaces if `spaces` is preferred mode of indentation.
CodeMirror.commands.insertSoftTab(editor); // `somethingSelected` needs to be checked otherwise, all selected code is replaced with softtab.
} else { CodeMirror.commands.insertSoftTab(editor);
CodeMirror.commands.defaultTab(editor); } else {
} CodeMirror.commands.defaultTab(editor);
} }
}, },
Enter: 'emmetInsertLineBreak' Enter: 'emmetInsertLineBreak'