From 1510197aba30e2aff022b990dadd53e449bdf35e Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 13 May 2016 00:20:34 +0530 Subject: [PATCH 1/2] remove default replacing for new tab and make it optional. --- src/eventPage.js | 22 ++++++++++++++++++++++ src/manifest.json | 14 ++++++++++---- 2 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 src/eventPage.js diff --git a/src/eventPage.js b/src/eventPage.js new file mode 100644 index 0000000..3422c4a --- /dev/null +++ b/src/eventPage.js @@ -0,0 +1,22 @@ +chrome.tabs.onCreated.addListener(function (tab) { + + console.log('created', arguments) + if (tab.url === 'chrome://newtab/') { + chrome.tabs.update(tab.id, { + url: chrome.extension.getURL('index.html') + }, function callback() { + console.log('ho gaya'); + }); + } + +}); + +chrome.tabs.onUpdated.addListener(function () { + + console.log('updated', arguments) + +}); + +chrome.browserAction.onClicked.addListener(function(activeTab) { + chrome.tabs.create({ url: chrome.extension.getURL('index.html'), selected: true }); +}); diff --git a/src/manifest.json b/src/manifest.json index 4fd3b48..4b578e5 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -3,13 +3,19 @@ "version": "1.3", "manifest_version": 2, "description": "Convert new tabs into an offline playground for your web experiments", - "chrome_url_overrides" : { - "newtab": "index.html" - }, "homepage_url": "https://kushagragour.in/lab/web-maker", "permissions": [ - "storage" + "storage", + "tabs" ], + "browser_action": { + "default_title": "Start Web Maker", + "default_icon": "icon-16.png" + }, + "background": { + "scripts": [ "eventPage.js" ], + "persistent": false + }, "content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'", "icons": { "16": "icon-16.png", From c1ef1064698acf7b91d460ff7b9a2ea5529f5574 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 13 May 2016 02:30:25 +0530 Subject: [PATCH 2/2] remove tab permission. --- src/eventPage.js | 21 +-------------------- src/manifest.json | 9 +++++---- 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/src/eventPage.js b/src/eventPage.js index 3422c4a..036d97b 100644 --- a/src/eventPage.js +++ b/src/eventPage.js @@ -1,22 +1,3 @@ -chrome.tabs.onCreated.addListener(function (tab) { - - console.log('created', arguments) - if (tab.url === 'chrome://newtab/') { - chrome.tabs.update(tab.id, { - url: chrome.extension.getURL('index.html') - }, function callback() { - console.log('ho gaya'); - }); - } - -}); - -chrome.tabs.onUpdated.addListener(function () { - - console.log('updated', arguments) - -}); - chrome.browserAction.onClicked.addListener(function(activeTab) { chrome.tabs.create({ url: chrome.extension.getURL('index.html'), selected: true }); -}); +}); \ No newline at end of file diff --git a/src/manifest.json b/src/manifest.json index 4b578e5..9fb4c31 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -5,18 +5,19 @@ "description": "Convert new tabs into an offline playground for your web experiments", "homepage_url": "https://kushagragour.in/lab/web-maker", "permissions": [ - "storage", - "tabs" + "storage" ], + "chrome_url_overrides" : { + "newtab": "index.html" + }, "browser_action": { - "default_title": "Start Web Maker", + "default_title": "Web Maker", "default_icon": "icon-16.png" }, "background": { "scripts": [ "eventPage.js" ], "persistent": false }, - "content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'", "icons": { "16": "icon-16.png", "48": "icon-48.png"