show correct save item notifcation at correct time.

src/itemService.js

@@ -54,22 +54,46 @@
 		},
 
 		async setItem(id, item) {
-			if (!window.user) {
-				return new Promise(resolve => resolve());
+			const d = deferred();
+			var remotePromise;
+			// TODO: check why we need to save locally always?
+			const obj = {
+				[id]: item
+			};
+			db.local.set(obj, () => {
+				// Is extension OR is app but logged out OR is logged in but offline
+				// If logged in but offline, resolve immediately so
+				// that you see the feedback msg immediately and not wait for
+				// later sync.
+				if (window.IS_EXTENSION || !window.user || !navigator.onLine) {
+					d.resolve();
+				}
+			});
+
+			// If `id` is `code`, this is a call on unloadbefore to save the last open thing.
+			// Do not presist that on remote.
+			if (id === 'code') {
+				// No deferred required here as this gets called on unloadbefore
+				return false;
 			}
-			var remoteDb = await window.db.getDb();
-			utils.log(`Starting to save item ${id}`);
-			item.createdBy = window.user.uid;
-			return remoteDb
-				.collection('items')
-				.doc(id)
-				.set(item, {
-					merge: true
-				})
-				.then(arg => {
-					utils.log('Document written', arg);
-				})
-				.catch(error => utils.log(error));
+			if (window.user) {
+				var remoteDb = await window.db.getDb();
+				utils.log(`Starting to save item ${id}`);
+				item.createdBy = window.user.uid;
+				remotePromise = remoteDb
+					.collection('items')
+					.doc(id)
+					.set(item, {
+						merge: true
+					})
+					.then(arg => {
+						utils.log('Document written', arg);
+						d.resolve();
+					})
+					.catch(d.reject);
+				}
+
+			return (window.user && navigator.onLine) ? remotePromise : d.promise;
 		},
 
 		/**