From f7c926e68a42755d08ca0fdea39222a0768e45b5 Mon Sep 17 00:00:00 2001 From: Kushagra Gour Date: Fri, 22 Jun 2018 20:35:18 +0530 Subject: [PATCH] add check on externalLibs before using --- src/components/app.jsx | 3 +++ src/utils.js | 30 +++++++++++++++++------------- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/src/components/app.jsx b/src/components/app.jsx index 821bedd..3cc3c7b 100644 --- a/src/components/app.jsx +++ b/src/components/app.jsx @@ -513,6 +513,9 @@ export default class App extends Component { updateExternalLibCount() { // Calculate no. of external libs var noOfExternalLibs = 0; + if (!this.state.currentItem.externalLibs) { + return; + } noOfExternalLibs += this.state.currentItem.externalLibs.js .split('\n') .filter(lib => !!lib).length; diff --git a/src/utils.js b/src/utils.js index ebde9b3..1a91547 100644 --- a/src/utils.js +++ b/src/utils.js @@ -307,19 +307,23 @@ export function getCompleteHtml(html, css, js, item, isForExport) { if (!item) { return ''; } - var externalJs = item.externalLibs.js - .split('\n') - .reduce(function(scripts, url) { - return scripts + (url ? '\n' : ''); - }, ''); - var externalCss = item.externalLibs.css - .split('\n') - .reduce(function(links, url) { - return ( - links + - (url ? '\n' : '') - ); - }, ''); + var externalJs = '', + externalCss = ''; + if (item.externalLibs) { + externalJs = item.externalLibs.js + .split('\n') + .reduce(function(scripts, url) { + return scripts + (url ? '\n' : ''); + }, ''); + externalCss = item.externalLibs.css + .split('\n') + .reduce(function(links, url) { + return ( + links + + (url ? '\n' : '') + ); + }, ''); + } var contents = '\n' + '\n\n' +