mirror/processwire
1
0
Fork 0
mirror of https://github.com/processwire/processwire.git synced 2025-08-13 10:15:28 +02:00
Code Issues Releases Wiki Activity

Update Page::matches() to perform comparison with database rather than in-memory per processwire/processwire-issues#1701

Browse Source
This commit is contained in:
Ryan Cramer
2023-08-04 10:30:56 -04:00
parent 6266d1d86b
commit 13114afe08
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wire/core/PageComparison.php
View File

@@ -5,7 +5,7 @@
*
* Provides implementation for Page comparison functions.
*
* ProcessWire 3.x, Copyright 2020 by Ryan Cramer
* ProcessWire 3.x, Copyright 2023 by Ryan Cramer
* https://processwire.com
*
*/
@@ -237,7 +237,14 @@ class PageComparison {
// unknown data type to match
return false;
}
$selectors->add(new SelectorEqual('id', $page->id))->add(new SelectorEqual('include', 'all'));
return $page->wire()->pages->count($selectors) > 0;
/*
* the following is for performing in-memory matches, left here for reference
*
$matches = false;
foreach($selectors as $selector) {
@@ -269,6 +276,7 @@ class PageComparison {
}
return $matches;
*/
}
/**