From 3bd27723b2fe9ebc7ce4234620525b4ff53f6b9a Mon Sep 17 00:00:00 2001 From: Ryan Cramer Date: Fri, 22 Nov 2024 10:44:30 -0500 Subject: [PATCH] Fix issue processwire/processwire-issues#1999 --- wire/core/AdminThemeFramework.php | 4 ++-- wire/modules/Process/ProcessPageEdit/ProcessPageEdit.module | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/wire/core/AdminThemeFramework.php b/wire/core/AdminThemeFramework.php index 557be9d6..04f9fa75 100644 --- a/wire/core/AdminThemeFramework.php +++ b/wire/core/AdminThemeFramework.php @@ -193,8 +193,8 @@ abstract class AdminThemeFramework extends AdminTheme { * */ public function getHeadline() { - $headline = $this->wire('processHeadline'); - if(!$headline) $headline = $this->wire()->page->get('title|name'); + $headline = (string) $this->wire('processHeadline'); + if(!strlen($headline)) $headline = $this->wire()->page->get('title|name'); if($headline !== 'en' && $this->wire()->languages) $headline = $this->_($headline); return $this->sanitizer->entities1($headline); } diff --git a/wire/modules/Process/ProcessPageEdit/ProcessPageEdit.module b/wire/modules/Process/ProcessPageEdit/ProcessPageEdit.module index 637e2deb..f7f98c4c 100644 --- a/wire/modules/Process/ProcessPageEdit/ProcessPageEdit.module +++ b/wire/modules/Process/ProcessPageEdit/ProcessPageEdit.module @@ -3345,14 +3345,14 @@ class ProcessPageEdit extends Process implements WirePageEditor, ConfigurableMod } else { $title = (string) $title; } - if(empty($title)) { + if(!strlen("$title")) { if($this->pages->names()->isUntitledPageName($page->name)) { $title = $page->template->getLabel(); } else { $title = $page->get('name'); } } - if(empty($title)) $title = $page->name; + if(!strlen("$title")) $title = $page->name; } else if($this->parent && $this->parent->id) { $titlePage = $this->parent; $title = rtrim($this->parent->path, '/') . '/[...]'; @@ -3380,7 +3380,7 @@ class ProcessPageEdit extends Process implements WirePageEditor, ConfigurableMod $headline = $titlePage->get('title|name'); } - if(empty($headline)) $headline = $title; + if(!strlen("$headline")) $headline = $title; $this->headline($headline); $this->browserTitle($browserTitle);